diff options
| author | Andreas Fritiofson <andreas.fritiofson@gmail.com> | 2013-09-28 16:07:14 +0200 |
|---|---|---|
| committer | Spencer Oliver <spen@spen-soft.co.uk> | 2013-10-07 19:03:02 +0000 |
| commit | 2a0ed1ee7f2d0402cbadd93c8d3019bdb5f9370e (patch) | |
| tree | ccde8837c27474057e2e6498006b2010111c17dc /src/jtag/tcl.c | |
| parent | 4f885215816624df7bc19523ea2da94ca90772f3 (diff) | |
jtag/tcl: Fix double free in jtag newtap argument parsing
Found when grepping for void* casts. I'm pretty sure there are about
*picking a number out of the blue* 0.31 bugs per pointer cast in OpenOCD.
Verified by valgrind, i.e.:
valgrind openocd -f interface/jtagkey.cfg -c "jtag newtap dummy cpu -irlen foo"
Change-Id: Idc12e8f18036cc908fdb572828fa46563be14242
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1665
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Diffstat (limited to 'src/jtag/tcl.c')
| -rw-r--r-- | src/jtag/tcl.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index d0020cd3..227222ef 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -467,7 +467,6 @@ static int jim_newtap_ir_param(Jim_Nvp *n, Jim_GetOptInfo *goi, if (e != JIM_OK) { Jim_SetResultFormatted(goi->interp, "option: %s bad parameter", n->name); - free((void *)pTap->dotted_name); return e; } switch (n->value) { |