diff options
| author | Marek Vasut <marek.vasut@gmail.com> | 2019-03-01 13:56:44 +0100 |
|---|---|---|
| committer | Freddie Chopin <freddie.chopin@gmail.com> | 2019-03-23 17:43:17 +0000 |
| commit | 2b66816a4d88f1c15468b3d307b59f1242a6a4be (patch) | |
| tree | 6b63bc208eae084fd8141c669c3b1d56142d2130 | |
| parent | 8f518d3592dd80bfc7637d16498f2994038ab77c (diff) | |
mips32: pracc: Fix UPPER/LOWER macros
These macros are missing parenthesis around the argument, which can
lead to side effects, add them. Replace the argument name to avoid
conflict with uint32_t data type, since the macro can be applied to
other data types as well.
Change-Id: I32d2ffec6c062795d7c8bb23d1dfa3378bfc3a58
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Reviewed-on: http://openocd.zylin.com/4994
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
| -rw-r--r-- | src/target/mips32_pracc.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/target/mips32_pracc.h b/src/target/mips32_pracc.h index 888c847c..cc11540b 100644 --- a/src/target/mips32_pracc.h +++ b/src/target/mips32_pracc.h @@ -39,8 +39,8 @@ #define PRACC_OUT_OFFSET (MIPS32_PRACC_PARAM_OUT - MIPS32_PRACC_BASE_ADDR) #define MIPS32_FASTDATA_HANDLER_SIZE 0x80 -#define UPPER16(uint32_t) (uint32_t >> 16) -#define LOWER16(uint32_t) (uint32_t & 0xFFFF) +#define UPPER16(addr) ((addr) >> 16) +#define LOWER16(addr) ((addr) & 0xFFFF) #define NEG16(v) (((~(v)) + 1) & 0xFFFF) #define SWAP16(v) ((LOWER16(v) << 16) | (UPPER16(v))) /*#define NEG18(v) (((~(v)) + 1) & 0x3FFFF)*/ |