diff options
Diffstat (limited to 'lib/Support')
-rw-r--r-- | lib/Support/Program.cpp | 5 | ||||
-rw-r--r-- | lib/Support/Unix/Program.inc | 13 | ||||
-rw-r--r-- | lib/Support/Windows/Program.inc | 9 |
3 files changed, 13 insertions, 14 deletions
diff --git a/lib/Support/Program.cpp b/lib/Support/Program.cpp index fa816f68c8..01860b082d 100644 --- a/lib/Support/Program.cpp +++ b/lib/Support/Program.cpp @@ -28,11 +28,10 @@ Program::ExecuteAndWait(const Path& path, const Path** redirects, unsigned secondsToWait, unsigned memoryLimit, - std::string* ErrMsg, - const char* SignalPrefix) { + std::string* ErrMsg) { Program prg; if (prg.Execute(path, args, envp, redirects, memoryLimit, ErrMsg)) - return prg.Wait(path, secondsToWait, ErrMsg, SignalPrefix); + return prg.Wait(path, secondsToWait, ErrMsg); else return -1; } diff --git a/lib/Support/Unix/Program.inc b/lib/Support/Unix/Program.inc index 86f3aa9eac..346baf1744 100644 --- a/lib/Support/Unix/Program.inc +++ b/lib/Support/Unix/Program.inc @@ -298,8 +298,7 @@ Program::Execute(const Path &path, const char **args, const char **envp, int Program::Wait(const sys::Path &path, unsigned secondsToWait, - std::string* ErrMsg, - const char* SignalPrefix) + std::string* ErrMsg) { #ifdef HAVE_SYS_WAIT_H struct sigaction Act, Old; @@ -339,7 +338,7 @@ Program::Wait(const sys::Path &path, else MakeErrMsg(ErrMsg, "Child timed out", 0); - return -1; // Timeout detected + return -2; // Timeout detected } else if (errno != EINTR) { MakeErrMsg(ErrMsg, "Error waiting for child process"); return -1; @@ -377,15 +376,15 @@ Program::Wait(const sys::Path &path, } } else if (WIFSIGNALED(status)) { if (ErrMsg) { - if (SignalPrefix) - *ErrMsg = SignalPrefix; - *ErrMsg += strsignal(WTERMSIG(status)); + *ErrMsg = strsignal(WTERMSIG(status)); #ifdef WCOREDUMP if (WCOREDUMP(status)) *ErrMsg += " (core dumped)"; #endif } - return -1; + // Return a special value to indicate that the process received an unhandled + // signal during execution as opposed to failing to execute. + return -2; } return result; #else diff --git a/lib/Support/Windows/Program.inc b/lib/Support/Windows/Program.inc index b685bb8b85..e486e6ec23 100644 --- a/lib/Support/Windows/Program.inc +++ b/lib/Support/Windows/Program.inc @@ -332,8 +332,7 @@ Program::Execute(const Path& path, int Program::Wait(const Path &path, unsigned secondsToWait, - std::string* ErrMsg, - const char* /*SignalPrefix*/) { + std::string* ErrMsg) { if (Data_ == 0) { MakeErrMsg(ErrMsg, "Process not started!"); return -1; @@ -350,7 +349,8 @@ Program::Wait(const Path &path, if (WaitForSingleObject(hProcess, millisecondsToWait) == WAIT_TIMEOUT) { if (!TerminateProcess(hProcess, 1)) { MakeErrMsg(ErrMsg, "Failed to terminate timed-out program."); - return -1; + // -2 indicates a crash or timeout as opposed to failure to execute. + return -2; } WaitForSingleObject(hProcess, INFINITE); } @@ -363,7 +363,8 @@ Program::Wait(const Path &path, if (!rc) { SetLastError(err); MakeErrMsg(ErrMsg, "Failed getting status for program."); - return -1; + // -2 indicates a crash or timeout as opposed to failure to execute. + return -2; } return status; |