diff options
| -rw-r--r-- | lib/Target/CBackend/CBackend.cpp | 9 | ||||
| -rw-r--r-- | lib/Target/CBackend/Writer.cpp | 9 |
2 files changed, 16 insertions, 2 deletions
diff --git a/lib/Target/CBackend/CBackend.cpp b/lib/Target/CBackend/CBackend.cpp index 0fd3046021..258c287878 100644 --- a/lib/Target/CBackend/CBackend.cpp +++ b/lib/Target/CBackend/CBackend.cpp @@ -693,7 +693,14 @@ void CWriter::printModule(Module *M) { Out << " __attribute__((common))"; else if (I->hasWeakLinkage()) Out << " __attribute__((weak))"; - if (!I->getInitializer()->isNullValue()) { + + // If the initializer is not null, emit the initializer. If it is null, + // we try to avoid emitting large amounts of zeros. The problem with + // this, however, occurs when the variable has weak linkage. In this + // case, the assembler will complain about the variable being both weak + // and common, so we disable this optimization. + if (!I->getInitializer()->isNullValue() || + I->hasWeakLinkage()) { Out << " = " ; writeOperand(I->getInitializer()); } diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp index 0fd3046021..258c287878 100644 --- a/lib/Target/CBackend/Writer.cpp +++ b/lib/Target/CBackend/Writer.cpp @@ -693,7 +693,14 @@ void CWriter::printModule(Module *M) { Out << " __attribute__((common))"; else if (I->hasWeakLinkage()) Out << " __attribute__((weak))"; - if (!I->getInitializer()->isNullValue()) { + + // If the initializer is not null, emit the initializer. If it is null, + // we try to avoid emitting large amounts of zeros. The problem with + // this, however, occurs when the variable has weak linkage. In this + // case, the assembler will complain about the variable being both weak + // and common, so we disable this optimization. + if (!I->getInitializer()->isNullValue() || + I->hasWeakLinkage()) { Out << " = " ; writeOperand(I->getInitializer()); } |