diff options
author | Nathan Jeffords <blunted2night@gmail.com> | 2010-05-12 07:36:03 +0000 |
---|---|---|
committer | Nathan Jeffords <blunted2night@gmail.com> | 2010-05-12 07:36:03 +0000 |
commit | 62d50e89e40cb7fac444bde21bcab10fd69d68e3 (patch) | |
tree | f3c37b806575a138b1075d70fc2231ffea89eccd /lib | |
parent | 5b1b3b73f2e4fc66eb8a9273673d128b139caf03 (diff) |
stylistic change to MCSectionCOFF::PrintSwitchToSection COMDAT handling
Made a stylistic changed to the code/comments related to the unsupported COMDAT selection type IMAGE_COMDAT_SELECT_LARGEST based on from Anton Korobeynikov.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103590 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/MC/MCSectionCOFF.cpp | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/lib/MC/MCSectionCOFF.cpp b/lib/MC/MCSectionCOFF.cpp index 786bc7bc03..d57bb0cd52 100644 --- a/lib/MC/MCSectionCOFF.cpp +++ b/lib/MC/MCSectionCOFF.cpp @@ -50,9 +50,6 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, if (getCharacteristics() & MCSectionCOFF::IMAGE_SCN_LNK_COMDAT) { switch (Selection) { - default: - assert (0 && "unsupported COFF selection type"); - break; case IMAGE_COMDAT_SELECT_NODUPLICATES: OS << "\t.linkonce one_only\n"; break; @@ -65,12 +62,15 @@ void MCSectionCOFF::PrintSwitchToSection(const MCAsmInfo &MAI, case IMAGE_COMDAT_SELECT_EXACT_MATCH: OS << "\t.linkonce same_contents\n"; break; - // ".linkonce largest" is not documented as being an option. - // It seems odd that a link attribute designed essentially for PE/COFF - // wouldn't support all the options (at least as of binutils 2.20) - //case IMAGE_COMDAT_SELECT_LARGEST: + //NOTE: as of binutils 2.20, there is no way to specifiy select largest + // with the .linkonce directive. For now, we treat it as an invalid + // comdat selection value. + case IMAGE_COMDAT_SELECT_LARGEST: // OS << "\t.linkonce largest\n"; // break; + default: + assert (0 && "unsupported COFF selection type"); + break; } } } |