diff options
author | Nadav Rotem <nrotem@apple.com> | 2013-04-14 03:22:20 +0000 |
---|---|---|
committer | Nadav Rotem <nrotem@apple.com> | 2013-04-14 03:22:20 +0000 |
commit | f7eaf29cf70a545f5b717c638db83ba6e8b6b3c5 (patch) | |
tree | 0255d593fb604b50db8fea3a3f87a6871cd8f161 /lib/Transforms | |
parent | ef596e1a80a9790efbc905c57b4e06ba6addb95a (diff) |
SLPVectorizer: add initial support for reduction variable vectorization.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179470 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms')
-rw-r--r-- | lib/Transforms/Vectorize/SLPVectorizer.cpp | 89 | ||||
-rw-r--r-- | lib/Transforms/Vectorize/VecUtils.cpp | 10 | ||||
-rw-r--r-- | lib/Transforms/Vectorize/VecUtils.h | 3 |
3 files changed, 95 insertions, 7 deletions
diff --git a/lib/Transforms/Vectorize/SLPVectorizer.cpp b/lib/Transforms/Vectorize/SLPVectorizer.cpp index 209d287743..2f55a007f2 100644 --- a/lib/Transforms/Vectorize/SLPVectorizer.cpp +++ b/lib/Transforms/Vectorize/SLPVectorizer.cpp @@ -26,6 +26,7 @@ #include "llvm/Analysis/Verifier.h" #include "llvm/IR/DataLayout.h" #include "llvm/IR/Instructions.h" +#include "llvm/IR/IntrinsicInst.h" #include "llvm/IR/Module.h" #include "llvm/IR/Type.h" #include "llvm/IR/Value.h" @@ -38,7 +39,7 @@ using namespace llvm; static cl::opt<int> -SLPCostThreshold("slp-threshold", cl::init(1), cl::Hidden, +SLPCostThreshold("slp-threshold", cl::init(0), cl::Hidden, cl::desc("Only vectorize trees if the gain is above this " "number. (gain = -cost of vectorization)")); namespace { @@ -63,7 +64,7 @@ struct SLPVectorizer : public BasicBlockPass { /// object. We sort the stores to their base objects to reduce the cost of the /// quadratic search on the stores. TODO: We can further reduce this cost /// if we flush the chain creation every time we run into a memory barrier. - bool CollectStores(BasicBlock *BB, BoUpSLP &R) { + bool collectStores(BasicBlock *BB, BoUpSLP &R) { for (BasicBlock::iterator it = BB->begin(), e = BB->end(); it != e; ++it) { StoreInst *SI = dyn_cast<StoreInst>(it); if (!SI) @@ -84,7 +85,79 @@ struct SLPVectorizer : public BasicBlockPass { return true; } - bool RollStoreChains(BoUpSLP &R) { + bool tryToVectorizePair(BinaryOperator *A, BinaryOperator *B, BoUpSLP &R) { + if (!A || !B) return false; + BoUpSLP::ValueList VL; + VL.push_back(A); + VL.push_back(B); + int Cost = R.getTreeCost(VL); + DEBUG(dbgs()<<"SLP: Cost of pair:" << Cost << ".\n"); + if (Cost >= -SLPCostThreshold) return false; + DEBUG(dbgs()<<"SLP: Vectorizing pair.\n"); + R.vectorizeArith(VL); + return true; + } + + bool tryToVectorizeCandidate(BinaryOperator *V, BoUpSLP &R) { + if (!V) return false; + BinaryOperator *A = dyn_cast<BinaryOperator>(V->getOperand(0)); + BinaryOperator *B = dyn_cast<BinaryOperator>(V->getOperand(1)); + // Try to vectorize V. + if (tryToVectorizePair(A, B, R)) return true; + + // Try to skip B. + if (B && B->hasOneUse()) { + BinaryOperator *B0 = dyn_cast<BinaryOperator>(B->getOperand(0)); + BinaryOperator *B1 = dyn_cast<BinaryOperator>(B->getOperand(1)); + if (tryToVectorizePair(A, B0, R)) { + B->moveBefore(V); + return true; + } + if (tryToVectorizePair(A, B1, R)) { + B->moveBefore(V); + return true; + } + } + + // Try to slip A. + if (A && A->hasOneUse()) { + BinaryOperator *A0 = dyn_cast<BinaryOperator>(A->getOperand(0)); + BinaryOperator *A1 = dyn_cast<BinaryOperator>(A->getOperand(1)); + if (tryToVectorizePair(A0, B, R)) { + A->moveBefore(V); + return true; + } + if (tryToVectorizePair(A1, B, R)) { + A->moveBefore(V); + return true; + } + } + return 0; + } + + bool vectorizeReductions(BasicBlock *BB, BoUpSLP &R) { + bool Changed = false; + for (BasicBlock::iterator it = BB->begin(), e = BB->end(); it != e; ++it) { + if (isa<DbgInfoIntrinsic>(it)) continue; + PHINode *P = dyn_cast<PHINode>(it); + if (!P) return Changed; + // Check that the PHI is a reduction PHI. + if (P->getNumIncomingValues() != 2) return Changed; + Value *Rdx = (P->getIncomingBlock(0) == BB ? P->getIncomingValue(0) : + (P->getIncomingBlock(1) == BB ? P->getIncomingValue(1) : 0)); + // Check if this is a Binary Operator. + BinaryOperator *BI = dyn_cast_or_null<BinaryOperator>(Rdx); + if (!BI) continue; + + Value *Inst = BI->getOperand(0); + if (Inst == P) Inst = BI->getOperand(1); + Changed |= tryToVectorizeCandidate(dyn_cast<BinaryOperator>(Inst), R); + } + + return Changed; + } + + bool rollStoreChains(BoUpSLP &R) { bool Changed = false; // Attempt to sort and vectorize each of the store-groups. for (StoreListMap::iterator it = StoreRefs.begin(), e = StoreRefs.end(); @@ -116,13 +189,15 @@ struct SLPVectorizer : public BasicBlockPass { // he store instructions. BoUpSLP R(&BB, SE, DL, TTI, AA); - if (!CollectStores(&BB, R)) - return false; + bool Changed = vectorizeReductions(&BB, R); + + if (!collectStores(&BB, R)) + return Changed; - bool Changed = RollStoreChains(R); - if (Changed) { + if (rollStoreChains(R)) { DEBUG(dbgs()<<"SLP: vectorized in \""<<BB.getParent()->getName()<<"\"\n"); DEBUG(verifyFunction(*BB.getParent())); + Changed |= true; } return Changed; diff --git a/lib/Transforms/Vectorize/VecUtils.cpp b/lib/Transforms/Vectorize/VecUtils.cpp index d8be0ae721..4d075c505d 100644 --- a/lib/Transforms/Vectorize/VecUtils.cpp +++ b/lib/Transforms/Vectorize/VecUtils.cpp @@ -208,6 +208,16 @@ Value *BoUpSLP::isUnsafeToSink(Instruction *Src, Instruction *Dst) { return 0; } +void BoUpSLP::vectorizeArith(ValueList &Operands) { + Value *Vec = vectorizeTree(Operands, Operands.size()); + BasicBlock::iterator Loc = cast<Instruction>(Vec); + IRBuilder<> Builder(++Loc); + for (unsigned i = 0, e = Operands.size(); i != e; ++i) { + Value *S = Builder.CreateExtractElement(Vec, Builder.getInt32(i)); + Operands[i]->replaceAllUsesWith(S); + } +} + int BoUpSLP::getTreeCost(ValueList &VL) { // Get rid of the list of stores that were removed, and from the // lists of instructions with multiple users. diff --git a/lib/Transforms/Vectorize/VecUtils.h b/lib/Transforms/Vectorize/VecUtils.h index 808fb10f9f..f865236ff8 100644 --- a/lib/Transforms/Vectorize/VecUtils.h +++ b/lib/Transforms/Vectorize/VecUtils.h @@ -66,6 +66,9 @@ struct BoUpSLP { /// \returns true if the basic block was modified. bool vectorizeStores(StoreList &Stores, int costThreshold); + /// \brief Vectorize a group of scalars into a vector tree. + void vectorizeArith(ValueList &Operands); + private: /// \returns This method contains the recursive part of getTreeCost. int getTreeCost_rec(ValueList &VL, unsigned Depth); |