diff options
author | Nadav Rotem <nrotem@apple.com> | 2012-08-28 12:23:22 +0000 |
---|---|---|
committer | Nadav Rotem <nrotem@apple.com> | 2012-08-28 12:23:22 +0000 |
commit | a694e2a6910a33596ca706e2c6fc713f02b64c50 (patch) | |
tree | 3473f813bd38422141de802167a4e7522339a708 /lib/Transforms | |
parent | 9753f0b9b4ab33919c5010acb6a7b2dc1e875aff (diff) |
Make sure that we don't call getZExtValue on values > 64 bits.
Thanks Benjamin for noticing this.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162749 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms')
-rw-r--r-- | lib/Transforms/InstCombine/InstCombineMulDivRem.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp b/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp index e104a0a979..5eba463ec0 100644 --- a/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp +++ b/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp @@ -462,11 +462,11 @@ Instruction *InstCombiner::visitUDiv(BinaryOperator &I) { } } - // Udiv ((Lshl x, c1) , c2) -> x / (C1 * 1<<C2); - if (Constant *C = dyn_cast<Constant>(Op1)) { + // Udiv ((Lshl x, C1) , C2) -> x / (C2 * 1<<C1); + if (ConstantInt *C2 = dyn_cast<ConstantInt>(Op1)) { Value *X = 0, *C1 = 0; - if (match(Op0, m_LShr(m_Value(X), m_Value(C1)))) { - uint64_t NC = cast<ConstantInt>(C)->getZExtValue() * + if (match(Op0, m_LShr(m_Value(X), m_Value(C1))) && C2->getBitWidth() < 65) { + uint64_t NC = cast<ConstantInt>(C2)->getZExtValue() * (1<< cast<ConstantInt>(C1)->getZExtValue()); return BinaryOperator::CreateUDiv(X, ConstantInt::get(I.getType(), NC)); } @@ -543,11 +543,11 @@ Instruction *InstCombiner::visitSDiv(BinaryOperator &I) { ConstantExpr::getNeg(RHS)); } - // Sdiv ((Ashl x, c1) , c2) -> x / (C1 * 1<<C2); - if (Constant *C = dyn_cast<Constant>(Op1)) { + // Sdiv ((Ashl x, C1) , C2) -> x / (C2 * 1<<C1); + if (ConstantInt *C2 = dyn_cast<ConstantInt>(Op1)) { Value *X = 0, *C1 = 0; - if (match(Op0, m_AShr(m_Value(X), m_Value(C1)))) { - uint64_t NC = cast<ConstantInt>(C)->getZExtValue() * + if (match(Op0, m_AShr(m_Value(X), m_Value(C1))) && C2->getBitWidth() < 65) { + uint64_t NC = cast<ConstantInt>(C2)->getZExtValue() * (1<< cast<ConstantInt>(C1)->getZExtValue()); return BinaryOperator::CreateSDiv(X, ConstantInt::get(I.getType(), NC)); } |