diff options
author | Dan Gohman <gohman@apple.com> | 2009-02-24 02:00:40 +0000 |
---|---|---|
committer | Dan Gohman <gohman@apple.com> | 2009-02-24 02:00:40 +0000 |
commit | 0001e56f15215ae4bc5fffb82eec5c4828b888f0 (patch) | |
tree | c14953e84d899048fdcd5828b6b2b4ecac2ccb2a /lib/Transforms/Scalar/InstructionCombining.cpp | |
parent | c34fea3935dcc0cab13cfb5cb60471bd49089230 (diff) |
Fix a ValueTracking rule: RHS means operand 1, not 0. Add a simple
ashr instcombine to help expose this code. And apply the fix to
SelectionDAG's copy of this code too.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@65364 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Transforms/Scalar/InstructionCombining.cpp')
-rw-r--r-- | lib/Transforms/Scalar/InstructionCombining.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 7f2cab96ec..62554a5e91 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -7031,7 +7031,12 @@ Instruction *InstCombiner::visitAShr(BinaryOperator &I) { MaskedValueIsZero(Op0, APInt::getSignBit(I.getType()->getPrimitiveSizeInBits()))) return BinaryOperator::CreateLShr(Op0, I.getOperand(1)); - + + // Arithmetic shifting an all-sign-bit value is a no-op. + unsigned NumSignBits = ComputeNumSignBits(Op0); + if (NumSignBits == Op0->getType()->getPrimitiveSizeInBits()) + return ReplaceInstUsesWith(I, Op0); + return 0; } |