diff options
author | Evan Cheng <evan.cheng@apple.com> | 2011-02-11 02:28:55 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2011-02-11 02:28:55 +0000 |
commit | c143dd4f63889ca6b4f656200f43a1fa7bbf1c34 (patch) | |
tree | 860b9364d858aeeced923401ee1cdc3bb3699bf0 /lib/Support/Debug.cpp | |
parent | 98311ecb4ae9c82baba9e3a48acf756a81c8e9a4 (diff) |
Fix buggy fcopysign lowering.
This
define float @foo(float %x, float %y) nounwind readnone {
entry:
%0 = tail call float @copysignf(float %x, float %y) nounwind readnone
ret float %0
}
Was compiled to:
vmov s0, r1
bic r0, r0, #-2147483648
vmov s1, r0
vcmpe.f32 s0, #0
vmrs apsr_nzcv, fpscr
it lt
vneglt.f32 s1, s1
vmov r0, s1
bx lr
This fails to copy the sign of -0.0f because it's lost during the float to int
conversion. Also, it's sub-optimal when the inputs are in GPR registers.
Now it uses integer and + or operations when it's profitable. And it's correct!
lsrs r1, r1, #31
bfi r0, r1, #31, #1
bx lr
rdar://8984306
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@125357 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/Debug.cpp')
0 files changed, 0 insertions, 0 deletions