diff options
author | Bill Wendling <isanbard@gmail.com> | 2010-07-15 23:32:40 +0000 |
---|---|---|
committer | Bill Wendling <isanbard@gmail.com> | 2010-07-15 23:32:40 +0000 |
commit | e9bf7e692e56656ef13b33af86624d0fdcd578fb (patch) | |
tree | 2cb585a3c4d0fbf8bb51f00db689241d03af0ad0 /lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | |
parent | 60108e96bbc5432f4fe06ba313e64448e97a0e15 (diff) |
Handle code gen for the unreachable instruction if it's the only instruction in
the function. We'll just turn it into a "trap" instruction instead.
The problem with not handling this is that it might generate a prologue without
the equivalent epilogue to go with it:
$ cat t.ll
define void @foo() {
entry:
unreachable
}
$ llc -o - t.ll -relocation-model=pic -disable-fp-elim -unwind-tables
.section __TEXT,__text,regular,pure_instructions
.globl _foo
.align 4, 0x90
_foo: ## @foo
Leh_func_begin0:
## BB#0: ## %entry
pushq %rbp
Ltmp0:
movq %rsp, %rbp
Ltmp1:
Leh_func_end0:
...
The unwind tables then have bad data in them causing all sorts of problems.
Fixes <rdar://problem/8096481>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@108473 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp')
-rw-r--r-- | lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index 458e865a6b..1fa887c69e 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -796,6 +796,7 @@ void SelectionDAGBuilder::visit(unsigned Opcode, const User &I) { #define HANDLE_INST(NUM, OPCODE, CLASS) \ case Instruction::OPCODE: visit##OPCODE((CLASS&)I); break; #include "llvm/Instruction.def" +#undef HANDLE_INST } // Assign the ordering to the freshly created DAG nodes. @@ -2194,6 +2195,19 @@ void SelectionDAGBuilder::visitIndirectBr(const IndirectBrInst &I) { getValue(I.getAddress()))); } +void SelectionDAGBuilder::visitUnreachable(const UnreachableInst &I) { + // If the function consists of a single "unreachable" instruction, emit a + // "trap". This prevents the back-ends from generating empty functions or + // functions which have a prologue, but no epilogue. + const BasicBlock *BB = I.getParent(); + const Function *F = BB->getParent(); + + if (F->size() == 1 && BB->size() == 1 && + isa<UnreachableInst>(BB->getTerminator())) + DAG.setRoot(DAG.getNode(ISD::TRAP, getCurDebugLoc(), + MVT::Other, getRoot())); +} + void SelectionDAGBuilder::visitFSub(const User &I) { // -0.0 - X --> fneg const Type *Ty = I.getType(); |