diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-07-15 22:13:34 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-07-15 22:13:34 +0000 |
| commit | fd2934f190fc13b60f8e5dd9639008d721b170f8 (patch) | |
| tree | 016bf4fc8d33ec33dcdc6ad4fe5f705233d82622 | |
| parent | f05522974b3c1b9dc2644831364e19d5132e751b (diff) | |
Don't restrict the set of instructions where we try to constant-fold the
operands; it's possible to end up with a constant-foldable operand to
most instructions, even those which can't trap.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@75845 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Transforms/Scalar/InstructionCombining.cpp | 4 | ||||
| -rw-r--r-- | test/Transforms/InstCombine/fold-bin-operand.ll | 13 |
2 files changed, 14 insertions, 3 deletions
diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 4160ee7dc1..fd87e30f96 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -13021,9 +13021,7 @@ bool InstCombiner::DoOneIteration(Function &F, unsigned Iteration) { continue; } - if (TD && - (I->getType()->getTypeID() == Type::VoidTyID || - I->isTrapping())) { + if (TD) { // See if we can constant fold its operands. for (User::op_iterator i = I->op_begin(), e = I->op_end(); i != e; ++i) if (ConstantExpr *CE = dyn_cast<ConstantExpr>(i)) diff --git a/test/Transforms/InstCombine/fold-bin-operand.ll b/test/Transforms/InstCombine/fold-bin-operand.ll new file mode 100644 index 0000000000..e884e1948e --- /dev/null +++ b/test/Transforms/InstCombine/fold-bin-operand.ll @@ -0,0 +1,13 @@ +; RUN: llvm-as < %s | opt -instcombine | llvm-dis | not grep icmp + +define i1 @f(i1 %x) { + %b = and i1 %x, icmp eq (i8* inttoptr (i32 1 to i8*), i8* inttoptr (i32 2 to i8*)) + ret i1 %b +} + +; FIXME: This doesn't fold at the moment! +; define i32 @f(i32 %x) { +; %b = add i32 %x, zext (i1 icmp eq (i8* inttoptr (i32 1000000 to i8*), i8* inttoptr (i32 2000000 to i8*)) to i32) +; ret i32 %b +;} + |