diff options
author | Dan Gohman <gohman@apple.com> | 2008-09-05 01:15:35 +0000 |
---|---|---|
committer | Dan Gohman <gohman@apple.com> | 2008-09-05 01:15:35 +0000 |
commit | f52550b50ee2d076dfad077bbe81b11f1300ab03 (patch) | |
tree | aa75128a5faac178037d0cb5f3a16b14374340a8 | |
parent | 087c8507e592bbbede1746f07bd44b28559e3684 (diff) |
Fix X86FastISel code for comparisons and conditional branches
to check the result of getRegForValue before using it, and
to check for illegal operand types.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@55819 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Target/X86/X86FastISel.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/lib/Target/X86/X86FastISel.cpp b/lib/Target/X86/X86FastISel.cpp index ef813e622a..1314f63682 100644 --- a/lib/Target/X86/X86FastISel.cpp +++ b/lib/Target/X86/X86FastISel.cpp @@ -263,10 +263,16 @@ bool X86FastISel::X86SelectCmp(Instruction *I) { CmpInst *CI = cast<CmpInst>(I); unsigned Op0Reg = getRegForValue(CI->getOperand(0)); + if (Op0Reg == 0) return false; unsigned Op1Reg = getRegForValue(CI->getOperand(1)); + if (Op1Reg == 0) return false; + + MVT VT = TLI.getValueType(I->getOperand(0)->getType()); + if (!TLI.isTypeLegal(VT)) + return false; unsigned Opc; - switch (TLI.getValueType(I->getOperand(0)->getType()).getSimpleVT()) { + switch (VT.getSimpleVT()) { case MVT::i8: Opc = X86::CMP8rr; break; case MVT::i16: Opc = X86::CMP16rr; break; case MVT::i32: Opc = X86::CMP32rr; break; @@ -398,6 +404,7 @@ bool X86FastISel::X86SelectZExt(Instruction *I) { if (I->getType() == Type::Int8Ty && I->getOperand(0)->getType() == Type::Int1Ty) { unsigned ResultReg = getRegForValue(I->getOperand(0)); + if (ResultReg == 0) return false; UpdateValueMap(I, ResultReg); return true; } @@ -409,6 +416,7 @@ bool X86FastISel::X86SelectBranch(Instruction *I) { BranchInst *BI = cast<BranchInst>(I); // Unconditional branches are selected by tablegen-generated code. unsigned OpReg = getRegForValue(BI->getCondition()); + if (OpReg == 0) return false; MachineBasicBlock *TrueMBB = MBBMap[BI->getSuccessor(0)]; MachineBasicBlock *FalseMBB = MBBMap[BI->getSuccessor(1)]; |