diff options
| author | Duncan Sands <baldrick@free.fr> | 2009-11-17 08:34:52 +0000 |
|---|---|---|
| committer | Duncan Sands <baldrick@free.fr> | 2009-11-17 08:34:52 +0000 |
| commit | 8dc071a6e522ea5e3eb265e28b410be8f57cffb2 (patch) | |
| tree | 8e883176448a697851693aba331698b02bf4143e | |
| parent | 5f9843f68fa2941a2c9930aa5cc920c38920f277 (diff) | |
Following a suggestion of Daniel Dunbar, stop people passing the name
as the isSigned bool to CreateIntCast by having this resolve to a call
to a private method, rather than by using a gcc attribute.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@89067 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | include/llvm/Support/Compiler.h | 8 | ||||
| -rw-r--r-- | include/llvm/Support/IRBuilder.h | 8 |
2 files changed, 5 insertions, 11 deletions
diff --git a/include/llvm/Support/Compiler.h b/include/llvm/Support/Compiler.h index 5c414f8d56..da31f98628 100644 --- a/include/llvm/Support/Compiler.h +++ b/include/llvm/Support/Compiler.h @@ -78,12 +78,4 @@ #define NORETURN #endif -#if defined(__GNUC__) && ((__GNUC__ > 4)||(__GNUC__ == 4 && __GNUC_MINOR__ > 2)) -#define ERROR_IF_USED __attribute__((error("wrong usage"))) -#elif defined(__APPLE__) -#define ERROR_IF_USED __attribute__((unavailable)) -#else -#define ERROR_IF_USED -#endif - #endif diff --git a/include/llvm/Support/IRBuilder.h b/include/llvm/Support/IRBuilder.h index 1d3c08c637..2db2477a9e 100644 --- a/include/llvm/Support/IRBuilder.h +++ b/include/llvm/Support/IRBuilder.h @@ -709,9 +709,11 @@ public: return Folder.CreateIntCast(VC, DestTy, isSigned); return Insert(CastInst::CreateIntegerCast(V, DestTy, isSigned), Name); } - // Provided to resolve 'CreateIntCast(Ptr, Ptr, "...")', instead of converting - // the string to 'bool' for the isSigned parameter. - ERROR_IF_USED Value *CreateIntCast(Value *, const Type *, const char *); +private: + // Provided to resolve 'CreateIntCast(Ptr, Ptr, "...")', giving a compile time + // error, instead of converting the string to bool for the isSigned parameter. + Value *CreateIntCast(Value *, const Type *, const char *); // DO NOT IMPLEMENT +public: Value *CreateFPCast(Value *V, const Type *DestTy, const Twine &Name = "") { if (V->getType() == DestTy) return V; |