diff options
| author | Chris Lattner <sabre@nondot.org> | 2010-04-17 20:45:56 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2010-04-17 20:45:56 +0000 |
| commit | 77e80deabcdbb84b9dbc76152ecc4d606aec0bfd (patch) | |
| tree | 466052e1cff8893272af8c2f589374498ffee38d | |
| parent | b5f6af644ebe504479a74341ae8b0c706e7a5fcc (diff) | |
reject forward references to functions whose type don't match
up with the definition (and fix a broken testcase). PR6491.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@101670 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/AsmParser/LLParser.cpp | 4 | ||||
| -rw-r--r-- | test/Bitcode/memcpy.ll | 2 |
2 files changed, 5 insertions, 1 deletions
diff --git a/lib/AsmParser/LLParser.cpp b/lib/AsmParser/LLParser.cpp index fe8e9c7f07..aa887d2177 100644 --- a/lib/AsmParser/LLParser.cpp +++ b/lib/AsmParser/LLParser.cpp @@ -2787,6 +2787,10 @@ bool LLParser::ParseFunctionHeader(Function *&Fn, bool isDefine) { ForwardRefVals.find(FunctionName); if (FRVI != ForwardRefVals.end()) { Fn = M->getFunction(FunctionName); + if (Fn->getType() != PFT) + return Error(FRVI->second.second, "invalid forward reference to " + "function '" + FunctionName + "' with wrong type!"); + ForwardRefVals.erase(FRVI); } else if ((Fn = M->getFunction(FunctionName))) { // If this function already exists in the symbol table, then it is diff --git a/test/Bitcode/memcpy.ll b/test/Bitcode/memcpy.ll index b6573b5f62..299eb1ed41 100644 --- a/test/Bitcode/memcpy.ll +++ b/test/Bitcode/memcpy.ll @@ -20,4 +20,4 @@ declare void @llvm.memset.i32(i8*, i8, i32, i32) declare void @llvm.memmove.i32(i8*, i8*, i32, i32) -declare void @llvm.memmove.i64(i8*, i8*, i32, i32) +declare void @llvm.memmove.i64(i8*, i8*, i64, i32) |