diff options
author | Dan Gohman <gohman@apple.com> | 2008-06-23 16:48:17 +0000 |
---|---|---|
committer | Dan Gohman <gohman@apple.com> | 2008-06-23 16:48:17 +0000 |
commit | 2f27e174a9a197701ec88478e2fce5d768d21176 (patch) | |
tree | af2147c18c5725b376244468f6a9e784787a8254 | |
parent | 7894ea75b5e25b2ca354a79f7b552ea941d157d8 (diff) |
Remove two convenience constructors because they're now private, and the
private implementation doesn't really need the convenience.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@52629 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/llvm/Instructions.h | 13 | ||||
-rw-r--r-- | lib/VMCore/Instructions.cpp | 18 |
2 files changed, 4 insertions, 27 deletions
diff --git a/include/llvm/Instructions.h b/include/llvm/Instructions.h index 403e82aea1..f9e0a2e5ce 100644 --- a/include/llvm/Instructions.h +++ b/include/llvm/Instructions.h @@ -1520,13 +1520,6 @@ class ExtractValueInst : public UnaryInstruction { InputIterator IdxBegin, InputIterator IdxEnd, const std::string &Name, BasicBlock *InsertAtEnd); - /// Constructors - These two constructors are convenience methods because one - /// and two index extractvalue instructions are so common. - ExtractValueInst(Value *Agg, unsigned Idx, const std::string &Name = "", - Instruction *InsertBefore = 0); - ExtractValueInst(Value *Agg, unsigned Idx, - const std::string &Name, BasicBlock *InsertAtEnd); - // allocate space for exactly one operand void *operator new(size_t s) { return User::operator new(s, 1); @@ -1555,12 +1548,14 @@ public: static ExtractValueInst *Create(Value *Agg, unsigned Idx, const std::string &Name = "", Instruction *InsertBefore = 0) { - return new ExtractValueInst(Agg, Idx, Name, InsertBefore); + unsigned Idxs[1] = { Idx }; + return new ExtractValueInst(Agg, Idxs, Idxs + 1, Name, InsertBefore); } static ExtractValueInst *Create(Value *Agg, unsigned Idx, const std::string &Name, BasicBlock *InsertAtEnd) { - return new ExtractValueInst(Agg, Idx, Name, InsertAtEnd); + unsigned Idxs[1] = { Idx }; + return new ExtractValueInst(Agg, Idxs, Idxs + 1, Name, InsertAtEnd); } virtual ExtractValueInst *clone() const; diff --git a/lib/VMCore/Instructions.cpp b/lib/VMCore/Instructions.cpp index 1ce58eb6e7..4bcd560ee8 100644 --- a/lib/VMCore/Instructions.cpp +++ b/lib/VMCore/Instructions.cpp @@ -1465,24 +1465,6 @@ const Type* ExtractValueInst::getIndexedType(const Type *Agg, return getIndexedType(Agg, &Idx, 1); } -ExtractValueInst::ExtractValueInst(Value *Agg, - unsigned Idx, - const std::string &Name, - BasicBlock *InsertAtEnd) - : UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)), - ExtractValue, Agg, InsertAtEnd) { - init(Idx, Name); -} - -ExtractValueInst::ExtractValueInst(Value *Agg, - unsigned Idx, - const std::string &Name, - Instruction *InsertBefore) - : UnaryInstruction(checkType(getIndexedType(Agg->getType(), &Idx, 1)), - ExtractValue, Agg, InsertBefore) { - init(Idx, Name); -} - //===----------------------------------------------------------------------===// // BinaryOperator Class //===----------------------------------------------------------------------===// |