diff options
| author | Dan Gohman <gohman@apple.com> | 2011-09-14 18:33:34 +0000 |
|---|---|---|
| committer | Dan Gohman <gohman@apple.com> | 2011-09-14 18:33:34 +0000 |
| commit | 1d2fd75e3b60314210934078915aa573a2727854 (patch) | |
| tree | 5937947797f3f5222a8e95a436537de87562e572 | |
| parent | 211048286bef00ffcf04b1b3e1bb3de3de79965a (diff) | |
Don't mark objc_retainBlock as nounwind. It calls user copy constructors
which could theoretically throw.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@139710 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Transforms/Scalar/ObjCARC.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/Transforms/Scalar/ObjCARC.cpp b/lib/Transforms/Scalar/ObjCARC.cpp index f978f571c6..f7e0cd4fe1 100644 --- a/lib/Transforms/Scalar/ObjCARC.cpp +++ b/lib/Transforms/Scalar/ObjCARC.cpp @@ -425,9 +425,10 @@ static bool IsAlwaysTail(InstructionClass Class) { /// IsNoThrow - Test if the given class represents instructions which are always /// safe to mark with the nounwind attribute.. static bool IsNoThrow(InstructionClass Class) { + // objc_retainBlock is not nounwind because it calls user copy constructors + // which could theoretically throw. return Class == IC_Retain || Class == IC_RetainRV || - Class == IC_RetainBlock || Class == IC_Release || Class == IC_Autorelease || Class == IC_AutoreleaseRV || @@ -1605,7 +1606,8 @@ Constant *ObjCARCOpt::getRetainBlockCallee(Module *M) { std::vector<Type *> Params; Params.push_back(PointerType::getUnqual(Type::getInt8Ty(C))); AttrListPtr Attributes; - Attributes.addAttr(~0u, Attribute::NoUnwind); + // objc_retainBlock is not nounwind because it calls user copy constructors + // which could theoretically throw. RetainBlockCallee = M->getOrInsertFunction( "objc_retainBlock", |