diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2010-10-28 19:39:57 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2010-10-28 19:39:57 +0000 |
| commit | 1973d4379250a88938a9358c12d96e96bdc8dede (patch) | |
| tree | 7fb1ee424640436ed3a9495428a636726fce5803 | |
| parent | 9f36e7389fcd3079417eb141881b5c3743b389e5 (diff) | |
Defined weak symbols should have non-zero value.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@117585 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 7 | ||||
| -rw-r--r-- | test/MC/ELF/weak.s | 4 |
2 files changed, 5 insertions, 6 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index 813e4ac259..dbe0dd870f 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -438,10 +438,9 @@ static uint64_t SymbolValue(MCSymbolData &Data, const MCAsmLayout &Layout) { if (!Symbol.isInSection()) return 0; - if (!Data.isCommon() && !(Data.getFlags() & ELF_STB_Weak)) - if (MCFragment *FF = Data.getFragment()) - return Layout.getSymbolAddress(&Data) - - Layout.getSectionAddress(FF->getParent()); + if (MCFragment *FF = Data.getFragment()) + return Layout.getSymbolAddress(&Data) - + Layout.getSectionAddress(FF->getParent()); return 0; } diff --git a/test/MC/ELF/weak.s b/test/MC/ELF/weak.s index 332b91bf76..f1a66b5e03 100644 --- a/test/MC/ELF/weak.s +++ b/test/MC/ELF/weak.s @@ -5,7 +5,7 @@ .weak foo .long foo -// And that bar is after all local symbols +// And that bar is after all local symbols and has non zero value. .weak bar bar: @@ -15,7 +15,7 @@ bar: //CHECK-NEXT: ('st_type', 0x00000000) //CHECK-NEXT: ('st_other', 0x00000000) //CHECK-NEXT: ('st_shndx', 0x00000001) -//CHECK-NEXT: ('st_value', 0x00000000) +//CHECK-NEXT: ('st_value', 0x00000004) //CHECK-NEXT: ('st_size', 0x00000000) //CHECK-NEXT: ), //CHECK-NEXT: # Symbol 0x00000005 |