diff options
| author | Evan Cheng <evan.cheng@apple.com> | 2007-06-04 18:54:57 +0000 |
|---|---|---|
| committer | Evan Cheng <evan.cheng@apple.com> | 2007-06-04 18:54:57 +0000 |
| commit | 111354ff99c2480246b8eac905c60a30e9c589d3 (patch) | |
| tree | 210cd817cd1f82a2330564186a513d91dafe9586 | |
| parent | 5ea069fdda612676ead7c9b49d570c5872b2e57c (diff) | |
Misuse of hasExternalLinkage(), should be checking isDeclaration().
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@37419 91177308-0d34-0410-b5e6-96231b3b80d8
| -rwxr-xr-x | lib/Target/X86/X86ATTAsmPrinter.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/Target/X86/X86ATTAsmPrinter.cpp b/lib/Target/X86/X86ATTAsmPrinter.cpp index 17de053007..e3bb967f2a 100755 --- a/lib/Target/X86/X86ATTAsmPrinter.cpp +++ b/lib/Target/X86/X86ATTAsmPrinter.cpp @@ -286,7 +286,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo, } if (printStub(TM, Subtarget)) { - // Link-once, External, or Weakly-linked global variables need + // Link-once, declaration, or Weakly-linked global variables need // non-lazily-resolved stubs if (GV->isDeclaration() || GV->hasWeakLinkage() || @@ -351,7 +351,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo, else O << "@GOTOFF"; } else if (Subtarget->isPICStyleRIPRel() && !NotRIPRel) { - if ((GV->hasExternalLinkage() || + if ((GV->isDeclaration() || GV->hasWeakLinkage() || GV->hasLinkOnceLinkage()) && TM.getRelocationModel() != Reloc::Static) |