aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/vt6655
AgeCommit message (Collapse)Author
2014-07-24staging: vt6655: Fix disassociated messages every 10 secondsMalcolm Priestley
byReAssocCount is incremented every second resulting in disassociated message being send every 10 seconds whether connection or not. byReAssocCount should only advance while eCommandState is in WLAN_ASSOCIATE_WAIT Change existing scope to if condition. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-07-24staging: vt6655: Fix Warning on boot handle_irq_event_percpu.Malcolm Priestley
WARNING: CPU: 0 PID: 929 at /home/apw/COD/linux/kernel/irq/handle.c:147 handle_irq_event_percpu+0x1d1/0x1e0() irq 17 handler device_intr+0x0/0xa80 [vt6655_stage] enabled interrupts Using spin_lock_irqsave appears to fix this. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28staging: vt6655: refactor iwctl_giwaplist() to avoid -Wframe-larger-than warn.Konrad Zapalowicz
This commit refactors the iwctl_giwaplist() function so that the sparse warning "the frame size of 1292 bytes is larger than 1024 bytes [-Wframe-larger-than=]" is no more. The root cause of this warning were two arrays allocated on the stack and this commit changes this - these arrays are now kmalloc'ed. As a result the function is refactored and hopefully stil working the same. I were not able to test these changes so at least the carefull review is more than welcomed. Note that my changes has broadened the set of error codes that this function can return. The new error code is ENOMEM. Luckily, this is no issue. Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6655: Remove useless return variablesPeter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15staging: vt6655: fix checkpatch bracing issuesGuido Martínez
This patchs fixes tons of warnings such as: WARNING: braces {} are not necessary for single statement blocks #354: FILE: drivers/staging/vt6655/wmgr.c:354: + for (ii = 0; ii < WLAN_BSSID_LEN; ii++) { + pMgmt->abyDesireBSSID[ii] = 0xFF; + } Please note: this patch only fixes bracing issues (and there is still a lot to do); so if you run checkpatch it _will_ throw a lot of errors. Use --test-only=braces Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15staging: vt6655: remove dead codeGuido Martínez
Remove dead code in many places on this driver. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-15Staging: vt6655: tether: fixed a brace coding style issueNicolas Del Piano
Fixed a coding style issue. Signed-off-by: Nicolas Del Piano <ndel314@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655: removed incorrect casting in ioctl.cSilvio Fricke
This patch fixes the following type of sparse warnings: drivers/staging/vt6655/ioctl.c:308:104: warning: cast from restricted gfp_t drivers/staging/vt6655/ioctl.c:579:109: warning: cast from restricted gfp_t Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655: removed incorrect casting in wpactl.cSilvio Fricke
This patch fixes the following type of sparse warnings: drivers/staging/vt6655/wpactl.c:596:47: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:638:68: warning: cast from restricted gfp_t drivers/staging/vt6655/wpactl.c:860:42: warning: cast from restricted gfp_t Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18Staging: vt6655: iwctl.c: fix a sparse warningJimmy Li
fix a sparse warning and do some clean up. iwctl.c:1846:35: expected restricted gfp_t [usertype] flags Signed-off-by: Jimmy Li <coder.liss@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655: remove mention of nonexistent function CARDbSetBasicRateGuido Martínez
Comments mention a function CARDbSetBasicRate, but it never existed in the source tree. Remove all mention of it. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655: fix DBG_PRT and PRINT_K macrosGuido Martínez
Wrap both macros inside a 'do { ... } while(0)' to prevent breakage if used within another 'if'. Also fix a usage of DBG_PRT with a missing semicolon. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655,vt6656: fix sparse error "unexpected unlock"Cédric Cabessa
Signed-off-by: Cédric Cabessa <ced@ryick.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: vt6655: fix sparse warningIoana Ileana
Added missing static qualifier Signed-off-by: Ioana Ileana <ioana.ileana@telecom-paristech.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging:vt6655: Fix sparse warnings of using plain integer as NULL pointerHimangi Saraogi
This patch fixes the following sparse warnings: drivers/staging/vt6655/wmgr.c:970:42: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:971:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:972:38: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:973:43: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4110:37: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4111:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4112:34: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4113:30: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4114:35: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:4123:32: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1815:41: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1816:34: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1817:30: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:1818:35: warning: Using plain integer as NULL pointer drivers/staging/vt6655/wmgr.c:2075:63: warning: Using plain integer as NULL pointer The following coccinelle script was used to achieve this: @rule1@ expression *x; @@ ( - x = 0; + x = NULL; | - (x == 0) + (x == NULL) | - (x != 0) + (x != NULL) ) Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-16staging: vt6655: Fix line over 80 characters.Gulsah Kose
Fix checkpatch.pl issues with line over 80 characters in 80211mgr.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: vt6655: Remove unnecessary braces in aes_ccmp.cJelena Bjelja
This patch fixes the checkpatch warnings: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging:vt6655: Fix open brace placement related errorJelena Bjelja
This patch fixes the following checkpatch error in aes_ccmp.c: ERROR: that open brace { should be on the previous line Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-13staging: vt6655 : Fix placement of open braceAshley Smith
This patch fixes the checkpatch warning "that open brace { should be on the previous line" for a non-function statement block. Signed-off-by: Ashley Smith <ashley@eclipso.ch> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-08staging: vt6655: 64 bit fix sizeof long TKIP micMalcolm Priestley
Change to u32 and fix debug message format Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: vt6655: 64 bit fixes TKIP mic correct sizeof long.Malcolm Priestley
Correct to endian base type __le32. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: vt6655: 64 bit fixes :TKIP mode micheal.c sizeof long.Malcolm Priestley
Fix MIC_vGetMIC and MIC_vInit to u32 Fix calling functions to u32 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: vt6655: 64 bit fixes: MACvSetKeyEntry correct sizeof long,Malcolm Priestley
Use u32 to correct the pointer of pdwKey and the size of dwData. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: vt6655: 64 bit Correct alignment of tx/rx structures.Malcolm Priestley
Aligment of pointers on 64 bit is incorrect. Align to 64 bit using aligned 8 bytes and remove structure packing. This allows the device to run on both 32 and 64 bit Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-13staging: vt6655: Fix memory leak in wpa_ioctl()Christian Engelmayer
Fix a memory leak in the wpa_ioctl() error handling path so that 'param' is also freed correctly in case of an unsupported ioctl. Detected by Coverity: CID 144380. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: fix printk usage in wpactl.cMartin Hofmann
This patch fixes the usage of printk in wpactl.c concering one missing log level occurence and some whitespaces before a newline. Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: remove typedefs in wpactl.hMartin Hofmann
wpactl.h contained some typedefs for enums. These were removed in this patch. Also, a typedef for a type "unsigned long long" that was only instantiated in one place was removed and its declaration altered. Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: fix indentation in wroute.cMartin Hofmann
This patch fixes indentation style belonging to function calls as well as some run-away closing parentheses when calling functions. Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: remove unnecessary braces in wroute.cMartin Hofmann
This patch removes some unnecessary braces concerning if-statements in the file wroute.c Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: remove casts in wroute.cMartin Hofmann
The file wroute.c contained some silly casts. This patch removes them. Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08vt6655: balance faulty parentheses in 80211hdr.hMartin Hofmann
The file 80211hdr.h contained the macro WLAN_GET_FC_PRVER(n). The big endian fashion of this macro had unbalanced parentheses. This patch removes the parentheses in question. Signed-off-by: Martin Hofmann <martin.hofmann@studium.uni-erlangen.de> Signed-off-by: Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-01-08staging: vt6655: check too restrictive (off by one)Dan Carpenter
key_len == MAX_KEY_LEN is valid but we return an error. Introduced-by: 6b7200fe0a59 ('Staging: vt6655: memory corruption in check in wpa_set_wpadev()') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-17staging: delete non-required instances of include <linux/init.h>Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include <linux/init.h>. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-02staging: remove DEFINE_PCI_DEVICE_TABLE macroJingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-12-02Merge v3.13-rc2 into staging-nextGreg Kroah-Hartman
we want these fixes in here. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-25Staging: vt6655-6: potential NULL dereference in hostap_disable_hostapd()Dan Carpenter
We fixed this to use free_netdev() instead of kfree() but unfortunately free_netdev() doesn't accept NULL pointers. Smatch complains about this, it's not something I discovered through testing. Fixes: 3030d40b5036 ('staging: vt6655: use free_netdev instead of kfree') Fixes: 0a438d5b381e ('staging: vt6656: use free_netdev instead of kfree') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-11staging: vt6655: delete explicit comparison to boolTeodora Baluta
This patch fixes all bool tests by deleting the comparison. Most of these were detected using coccinelle and silence the following type of coccinelle warnings for drivers/staging/vt6655/bssdb.c file: WARNING: Comparison to bool Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-11staging: vt6655: delete unnecessary whitespace before a quoted newlineTeodora Baluta
This patch silences the following type of warnings: WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-11staging: vt6655: use netdev_* instead of printkTeodora Baluta
Checkpatch.pl gave the following warnings WARNING: printk() should include KERN_ facility level After fixing these with KERN_INFO facility level, it was suggested to use netdev_ instead of printk() with KERN_INFO facility. Used netdev_dbg for the statements inside of PLICE_DEBUG #ifdef, as debugging shouldn't rely on compile options and netdev_info for one printk which wasn't inside any #ifdef PLICE_DEBUG. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: remove unneeded semicolonTeodora Baluta
This patch deletes any unneeded semicolons in driver vt6655 as detected by coccinelle. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: fix comparison of bool to 0/1Teodora Baluta
This patch corrects comparison of bool to 0/1 for file drivers/staging/vt6655/rxtx.c. The following type of coccinelle detected warnings are silenced: WARNING: Comparison of bool to 0/1 Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: fix assignment of bool to 0Teodora Baluta
This patch fixes the following warnings detected using coccinelle for drivers/staging/wmgr.c file: drivers/staging/vt6655/wmgr.c:2335:1-22: WARNING: Assignment of bool to 0/1 drivers/staging/vt6655/wmgr.c:2338:1-27: WARNING: Assignment of bool to 0/1 Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: delete explicit comparison to boolTeodora Baluta
This patch fixes the following type of coccinelle detected warnings for driver vt6655: WARNING: Comparison to bool Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: put brace on previous lineTeodora Baluta
Place braces on same line for code statements. Fix the following checkpatch.pl type of error for drivers/staging/vt6655/bssdb.c file: ERROR: that open brace { should be on the previous line Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: put trailing statements on next lineTeodora Baluta
This patch fixes the following type of checkpatch.pl errors in drivers/staging/vt6655/bssdb.c file: ERROR: trailing statements should be on next line Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: remove braces for single statement blocksTeodora Baluta
This patch removes braces for single statement blocks, clearing these types of checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: replace C99 comments wtih C89 commentsTeodora Baluta
This patch replaces C99 comments with /* .. */ comments. Any commented code is deleted. Signed-off-by: Teodora Baluta <teobaluta@gmail.com> Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-11-10staging: vt6655: fixed sparse warning for static declaration in wpa2.cArchana kumari
This patch fixes sparse warning for static declaration in wpa2.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Josh Triplett <josh@joshtriplett.org> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-27staging: vt6655: fixed use of unnecessary braces in baseband.cArchana kumari
This patch fixes use of unnecessary braces in baseband.c Signed-off-by: Archana kumari <archanakumari959@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-10-27Staging: vt6655: Fix Sparse Warning for Static Declarations in wpa.cEbru Akagunduz
This patch fixes the Sparse Warning "symbol was not declared. Should it be static?" in wpa.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2025-12-24 16:17:52 +0000