diff options
Diffstat (limited to 'net/rfkill')
| -rw-r--r-- | net/rfkill/Kconfig | 2 | ||||
| -rw-r--r-- | net/rfkill/core.c | 13 | ||||
| -rw-r--r-- | net/rfkill/rfkill-gpio.c | 223 | 
3 files changed, 95 insertions, 143 deletions
diff --git a/net/rfkill/Kconfig b/net/rfkill/Kconfig index 78efe895b66..4c10e7e6c9f 100644 --- a/net/rfkill/Kconfig +++ b/net/rfkill/Kconfig @@ -36,7 +36,7 @@ config RFKILL_REGULATOR  config RFKILL_GPIO  	tristate "GPIO RFKILL driver" -	depends on RFKILL && GPIOLIB && HAVE_CLK +	depends on RFKILL && GPIOLIB  	default n  	help  	  If you say yes here you get support of a generic gpio RFKILL diff --git a/net/rfkill/core.c b/net/rfkill/core.c index 1bacc107994..b3b16c070a7 100644 --- a/net/rfkill/core.c +++ b/net/rfkill/core.c @@ -14,9 +14,7 @@   * GNU General Public License for more details.   *   * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the - * Free Software Foundation, Inc., - * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + * along with this program; if not, see <http://www.gnu.org/licenses/>.   */  #include <linux/kernel.h> @@ -791,7 +789,8 @@ void rfkill_resume_polling(struct rfkill *rfkill)  	if (!rfkill->ops->poll)  		return; -	schedule_work(&rfkill->poll_work.work); +	queue_delayed_work(system_power_efficient_wq, +			   &rfkill->poll_work, 0);  }  EXPORT_SYMBOL(rfkill_resume_polling); @@ -896,7 +895,8 @@ static void rfkill_poll(struct work_struct *work)  	 */  	rfkill->ops->poll(rfkill, rfkill->data); -	schedule_delayed_work(&rfkill->poll_work, +	queue_delayed_work(system_power_efficient_wq, +		&rfkill->poll_work,  		round_jiffies_relative(POLL_INTERVAL));  } @@ -960,7 +960,8 @@ int __must_check rfkill_register(struct rfkill *rfkill)  	INIT_WORK(&rfkill->sync_work, rfkill_sync_work);  	if (rfkill->ops->poll) -		schedule_delayed_work(&rfkill->poll_work, +		queue_delayed_work(system_power_efficient_wq, +			&rfkill->poll_work,  			round_jiffies_relative(POLL_INTERVAL));  	if (!rfkill->persistent || rfkill_epo_lock_active) { diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index fb076cd6f80..14c98e48f26 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -24,51 +24,37 @@  #include <linux/platform_device.h>  #include <linux/clk.h>  #include <linux/slab.h> +#include <linux/acpi.h> +#include <linux/gpio/consumer.h>  #include <linux/rfkill-gpio.h> -enum rfkill_gpio_clk_state { -	UNSPECIFIED = 0, -	PWR_ENABLED, -	PWR_DISABLED -}; +struct rfkill_gpio_data { +	const char		*name; +	enum rfkill_type	type; +	struct gpio_desc	*reset_gpio; +	struct gpio_desc	*shutdown_gpio; -#define PWR_CLK_SET(_RF, _EN) \ -	((_RF)->pwr_clk_enabled = (!(_EN) ? PWR_ENABLED : PWR_DISABLED)) -#define PWR_CLK_ENABLED(_RF) ((_RF)->pwr_clk_enabled == PWR_ENABLED) -#define PWR_CLK_DISABLED(_RF) ((_RF)->pwr_clk_enabled != PWR_ENABLED) +	struct rfkill		*rfkill_dev; +	struct clk		*clk; -struct rfkill_gpio_data { -	struct rfkill_gpio_platform_data	*pdata; -	struct rfkill				*rfkill_dev; -	char					*reset_name; -	char					*shutdown_name; -	enum rfkill_gpio_clk_state		pwr_clk_enabled; -	struct clk				*pwr_clk; +	bool			clk_enabled;  };  static int rfkill_gpio_set_power(void *data, bool blocked)  {  	struct rfkill_gpio_data *rfkill = data; -	if (blocked) { -		if (gpio_is_valid(rfkill->pdata->shutdown_gpio)) -			gpio_direction_output(rfkill->pdata->shutdown_gpio, 0); -		if (gpio_is_valid(rfkill->pdata->reset_gpio)) -			gpio_direction_output(rfkill->pdata->reset_gpio, 0); -		if (rfkill->pwr_clk && PWR_CLK_ENABLED(rfkill)) -			clk_disable(rfkill->pwr_clk); -	} else { -		if (rfkill->pwr_clk && PWR_CLK_DISABLED(rfkill)) -			clk_enable(rfkill->pwr_clk); -		if (gpio_is_valid(rfkill->pdata->reset_gpio)) -			gpio_direction_output(rfkill->pdata->reset_gpio, 1); -		if (gpio_is_valid(rfkill->pdata->shutdown_gpio)) -			gpio_direction_output(rfkill->pdata->shutdown_gpio, 1); -	} +	if (!blocked && !IS_ERR(rfkill->clk) && !rfkill->clk_enabled) +		clk_enable(rfkill->clk); -	if (rfkill->pwr_clk) -		PWR_CLK_SET(rfkill, blocked); +	gpiod_set_value_cansleep(rfkill->shutdown_gpio, !blocked); +	gpiod_set_value_cansleep(rfkill->reset_gpio, !blocked); + +	if (blocked && !IS_ERR(rfkill->clk) && rfkill->clk_enabled) +		clk_disable(rfkill->clk); + +	rfkill->clk_enabled = blocked;  	return 0;  } @@ -77,149 +63,114 @@ static const struct rfkill_ops rfkill_gpio_ops = {  	.set_block = rfkill_gpio_set_power,  }; -static int rfkill_gpio_probe(struct platform_device *pdev) +static int rfkill_gpio_acpi_probe(struct device *dev, +				  struct rfkill_gpio_data *rfkill)  { -	struct rfkill_gpio_data *rfkill; -	struct rfkill_gpio_platform_data *pdata = pdev->dev.platform_data; -	int ret = 0; -	int len = 0; +	const struct acpi_device_id *id; -	if (!pdata) { -		pr_warn("%s: No platform data specified\n", __func__); -		return -EINVAL; -	} +	id = acpi_match_device(dev->driver->acpi_match_table, dev); +	if (!id) +		return -ENODEV; -	/* make sure at-least one of the GPIO is defined and that -	 * a name is specified for this instance */ -	if (!pdata->name || (!gpio_is_valid(pdata->reset_gpio) && -		!gpio_is_valid(pdata->shutdown_gpio))) { -		pr_warn("%s: invalid platform data\n", __func__); -		return -EINVAL; -	} +	rfkill->name = dev_name(dev); +	rfkill->type = (unsigned)id->driver_data; -	rfkill = kzalloc(sizeof(*rfkill), GFP_KERNEL); -	if (!rfkill) -		return -ENOMEM; - -	if (pdata->gpio_runtime_setup) { -		ret = pdata->gpio_runtime_setup(pdev); -		if (ret) { -			pr_warn("%s: can't set up gpio\n", __func__); -			goto fail_alloc; -		} -	} +	return 0; +} -	rfkill->pdata = pdata; +static int rfkill_gpio_probe(struct platform_device *pdev) +{ +	struct rfkill_gpio_platform_data *pdata = pdev->dev.platform_data; +	struct rfkill_gpio_data *rfkill; +	struct gpio_desc *gpio; +	int ret; -	len = strlen(pdata->name); -	rfkill->reset_name = kzalloc(len + 7, GFP_KERNEL); -	if (!rfkill->reset_name) { -		ret = -ENOMEM; -		goto fail_alloc; -	} +	rfkill = devm_kzalloc(&pdev->dev, sizeof(*rfkill), GFP_KERNEL); +	if (!rfkill) +		return -ENOMEM; -	rfkill->shutdown_name = kzalloc(len + 10, GFP_KERNEL); -	if (!rfkill->shutdown_name) { -		ret = -ENOMEM; -		goto fail_reset_name; +	if (ACPI_HANDLE(&pdev->dev)) { +		ret = rfkill_gpio_acpi_probe(&pdev->dev, rfkill); +		if (ret) +			return ret; +	} else if (pdata) { +		rfkill->name = pdata->name; +		rfkill->type = pdata->type; +	} else { +		return -ENODEV;  	} -	snprintf(rfkill->reset_name, len + 6 , "%s_reset", pdata->name); -	snprintf(rfkill->shutdown_name, len + 9, "%s_shutdown", pdata->name); +	rfkill->clk = devm_clk_get(&pdev->dev, NULL); -	if (pdata->power_clk_name) { -		rfkill->pwr_clk = clk_get(&pdev->dev, pdata->power_clk_name); -		if (IS_ERR(rfkill->pwr_clk)) { -			pr_warn("%s: can't find pwr_clk.\n", __func__); -			ret = PTR_ERR(rfkill->pwr_clk); -			goto fail_shutdown_name; -		} +	gpio = devm_gpiod_get_index(&pdev->dev, "reset", 0); +	if (!IS_ERR(gpio)) { +		ret = gpiod_direction_output(gpio, 0); +		if (ret) +			return ret; +		rfkill->reset_gpio = gpio;  	} -	if (gpio_is_valid(pdata->reset_gpio)) { -		ret = gpio_request(pdata->reset_gpio, rfkill->reset_name); -		if (ret) { -			pr_warn("%s: failed to get reset gpio.\n", __func__); -			goto fail_clock; -		} +	gpio = devm_gpiod_get_index(&pdev->dev, "shutdown", 1); +	if (!IS_ERR(gpio)) { +		ret = gpiod_direction_output(gpio, 0); +		if (ret) +			return ret; +		rfkill->shutdown_gpio = gpio;  	} -	if (gpio_is_valid(pdata->shutdown_gpio)) { -		ret = gpio_request(pdata->shutdown_gpio, rfkill->shutdown_name); -		if (ret) { -			pr_warn("%s: failed to get shutdown gpio.\n", __func__); -			goto fail_reset; -		} +	/* Make sure at-least one of the GPIO is defined and that +	 * a name is specified for this instance +	 */ +	if ((!rfkill->reset_gpio && !rfkill->shutdown_gpio) || !rfkill->name) { +		dev_err(&pdev->dev, "invalid platform data\n"); +		return -EINVAL;  	} -	rfkill->rfkill_dev = rfkill_alloc(pdata->name, &pdev->dev, pdata->type, -					  &rfkill_gpio_ops, rfkill); -	if (!rfkill->rfkill_dev) { -		ret = -ENOMEM; -		goto fail_shutdown; -	} +	rfkill->rfkill_dev = rfkill_alloc(rfkill->name, &pdev->dev, +					  rfkill->type, &rfkill_gpio_ops, +					  rfkill); +	if (!rfkill->rfkill_dev) +		return -ENOMEM;  	ret = rfkill_register(rfkill->rfkill_dev);  	if (ret < 0) -		goto fail_rfkill; +		return ret;  	platform_set_drvdata(pdev, rfkill); -	dev_info(&pdev->dev, "%s device registered.\n", pdata->name); +	dev_info(&pdev->dev, "%s device registered.\n", rfkill->name);  	return 0; - -fail_rfkill: -	rfkill_destroy(rfkill->rfkill_dev); -fail_shutdown: -	if (gpio_is_valid(pdata->shutdown_gpio)) -		gpio_free(pdata->shutdown_gpio); -fail_reset: -	if (gpio_is_valid(pdata->reset_gpio)) -		gpio_free(pdata->reset_gpio); -fail_clock: -	if (rfkill->pwr_clk) -		clk_put(rfkill->pwr_clk); -fail_shutdown_name: -	kfree(rfkill->shutdown_name); -fail_reset_name: -	kfree(rfkill->reset_name); -fail_alloc: -	kfree(rfkill); - -	return ret;  }  static int rfkill_gpio_remove(struct platform_device *pdev)  {  	struct rfkill_gpio_data *rfkill = platform_get_drvdata(pdev); -	struct rfkill_gpio_platform_data *pdata = pdev->dev.platform_data; -	if (pdata->gpio_runtime_close) -		pdata->gpio_runtime_close(pdev);  	rfkill_unregister(rfkill->rfkill_dev);  	rfkill_destroy(rfkill->rfkill_dev); -	if (gpio_is_valid(rfkill->pdata->shutdown_gpio)) -		gpio_free(rfkill->pdata->shutdown_gpio); -	if (gpio_is_valid(rfkill->pdata->reset_gpio)) -		gpio_free(rfkill->pdata->reset_gpio); -	if (rfkill->pwr_clk && PWR_CLK_ENABLED(rfkill)) -		clk_disable(rfkill->pwr_clk); -	if (rfkill->pwr_clk) -		clk_put(rfkill->pwr_clk); -	kfree(rfkill->shutdown_name); -	kfree(rfkill->reset_name); -	kfree(rfkill);  	return 0;  } +#ifdef CONFIG_ACPI +static const struct acpi_device_id rfkill_acpi_match[] = { +	{ "BCM2E1A", RFKILL_TYPE_BLUETOOTH }, +	{ "BCM2E39", RFKILL_TYPE_BLUETOOTH }, +	{ "BCM2E3D", RFKILL_TYPE_BLUETOOTH }, +	{ "BCM4752", RFKILL_TYPE_GPS }, +	{ "LNV4752", RFKILL_TYPE_GPS }, +	{ }, +}; +#endif +  static struct platform_driver rfkill_gpio_driver = {  	.probe = rfkill_gpio_probe,  	.remove = rfkill_gpio_remove,  	.driver = { -		   .name = "rfkill_gpio", -		   .owner = THIS_MODULE, +		.name = "rfkill_gpio", +		.owner = THIS_MODULE, +		.acpi_match_table = ACPI_PTR(rfkill_acpi_match),  	},  };  | 
