diff options
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_attr_remote.c | 2 | ||||
| -rw-r--r-- | fs/xfs/xfs_bmap.c | 32 | ||||
| -rw-r--r-- | fs/xfs/xfs_bmap_util.c | 15 | ||||
| -rw-r--r-- | fs/xfs/xfs_buf.c | 37 | ||||
| -rw-r--r-- | fs/xfs/xfs_buf.h | 11 | ||||
| -rw-r--r-- | fs/xfs/xfs_buf_item.c | 21 | ||||
| -rw-r--r-- | fs/xfs/xfs_dir2_node.c | 26 | ||||
| -rw-r--r-- | fs/xfs/xfs_iops.c | 3 | ||||
| -rw-r--r-- | fs/xfs/xfs_log_recover.c | 13 | ||||
| -rw-r--r-- | fs/xfs/xfs_qm.c | 80 | ||||
| -rw-r--r-- | fs/xfs/xfs_trans_buf.c | 13 | 
11 files changed, 169 insertions, 84 deletions
diff --git a/fs/xfs/xfs_attr_remote.c b/fs/xfs/xfs_attr_remote.c index 739e0a52ded..5549d69ddb4 100644 --- a/fs/xfs/xfs_attr_remote.c +++ b/fs/xfs/xfs_attr_remote.c @@ -110,7 +110,7 @@ xfs_attr3_rmt_verify(  	if (be32_to_cpu(rmt->rm_bytes) > fsbsize - sizeof(*rmt))  		return false;  	if (be32_to_cpu(rmt->rm_offset) + -				be32_to_cpu(rmt->rm_bytes) >= XATTR_SIZE_MAX) +				be32_to_cpu(rmt->rm_bytes) > XATTR_SIZE_MAX)  		return false;  	if (rmt->rm_owner == 0)  		return false; diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index 3ef11b22e75..3b2c14b6f0f 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c @@ -1635,7 +1635,7 @@ xfs_bmap_last_extent(   * blocks at the end of the file which do not start at the previous data block,   * we will try to align the new blocks at stripe unit boundaries.   * - * Returns 0 in bma->aeof if the file (fork) is empty as any new write will be + * Returns 1 in bma->aeof if the file (fork) is empty as any new write will be   * at, or past the EOF.   */  STATIC int @@ -1650,9 +1650,14 @@ xfs_bmap_isaeof(  	bma->aeof = 0;  	error = xfs_bmap_last_extent(NULL, bma->ip, whichfork, &rec,  				     &is_empty); -	if (error || is_empty) +	if (error)  		return error; +	if (is_empty) { +		bma->aeof = 1; +		return 0; +	} +  	/*  	 * Check if we are allocation or past the last extent, or at least into  	 * the last delayed allocated extent. @@ -3643,10 +3648,19 @@ xfs_bmap_btalloc(  	int		isaligned;  	int		tryagain;  	int		error; +	int		stripe_align;  	ASSERT(ap->length);  	mp = ap->ip->i_mount; + +	/* stripe alignment for allocation is determined by mount parameters */ +	stripe_align = 0; +	if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC)) +		stripe_align = mp->m_swidth; +	else if (mp->m_dalign) +		stripe_align = mp->m_dalign; +  	align = ap->userdata ? xfs_get_extsz_hint(ap->ip) : 0;  	if (unlikely(align)) {  		error = xfs_bmap_extsize_align(mp, &ap->got, &ap->prev, @@ -3655,6 +3669,8 @@ xfs_bmap_btalloc(  		ASSERT(!error);  		ASSERT(ap->length);  	} + +  	nullfb = *ap->firstblock == NULLFSBLOCK;  	fb_agno = nullfb ? NULLAGNUMBER : XFS_FSB_TO_AGNO(mp, *ap->firstblock);  	if (nullfb) { @@ -3730,7 +3746,7 @@ xfs_bmap_btalloc(  	 */  	if (!ap->flist->xbf_low && ap->aeof) {  		if (!ap->offset) { -			args.alignment = mp->m_dalign; +			args.alignment = stripe_align;  			atype = args.type;  			isaligned = 1;  			/* @@ -3755,13 +3771,13 @@ xfs_bmap_btalloc(  			 * of minlen+alignment+slop doesn't go up  			 * between the calls.  			 */ -			if (blen > mp->m_dalign && blen <= args.maxlen) -				nextminlen = blen - mp->m_dalign; +			if (blen > stripe_align && blen <= args.maxlen) +				nextminlen = blen - stripe_align;  			else  				nextminlen = args.minlen; -			if (nextminlen + mp->m_dalign > args.minlen + 1) +			if (nextminlen + stripe_align > args.minlen + 1)  				args.minalignslop = -					nextminlen + mp->m_dalign - +					nextminlen + stripe_align -  					args.minlen - 1;  			else  				args.minalignslop = 0; @@ -3783,7 +3799,7 @@ xfs_bmap_btalloc(  		 */  		args.type = atype;  		args.fsbno = ap->blkno; -		args.alignment = mp->m_dalign; +		args.alignment = stripe_align;  		args.minlen = nextminlen;  		args.minalignslop = 0;  		isaligned = 1; diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c index 5887e41c032..82e0dab46ee 100644 --- a/fs/xfs/xfs_bmap_util.c +++ b/fs/xfs/xfs_bmap_util.c @@ -287,6 +287,7 @@ xfs_bmapi_allocate(  	INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker);  	queue_work(xfs_alloc_wq, &args->work);  	wait_for_completion(&done); +	destroy_work_on_stack(&args->work);  	return args->result;  } @@ -1187,7 +1188,12 @@ xfs_zero_remaining_bytes(  		XFS_BUF_UNWRITE(bp);  		XFS_BUF_READ(bp);  		XFS_BUF_SET_ADDR(bp, xfs_fsb_to_db(ip, imap.br_startblock)); -		xfsbdstrat(mp, bp); + +		if (XFS_FORCED_SHUTDOWN(mp)) { +			error = XFS_ERROR(EIO); +			break; +		} +		xfs_buf_iorequest(bp);  		error = xfs_buf_iowait(bp);  		if (error) {  			xfs_buf_ioerror_alert(bp, @@ -1200,7 +1206,12 @@ xfs_zero_remaining_bytes(  		XFS_BUF_UNDONE(bp);  		XFS_BUF_UNREAD(bp);  		XFS_BUF_WRITE(bp); -		xfsbdstrat(mp, bp); + +		if (XFS_FORCED_SHUTDOWN(mp)) { +			error = XFS_ERROR(EIO); +			break; +		} +		xfs_buf_iorequest(bp);  		error = xfs_buf_iowait(bp);  		if (error) {  			xfs_buf_ioerror_alert(bp, diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index c7f0b77dcb0..afe7645e4b2 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -698,7 +698,11 @@ xfs_buf_read_uncached(  	bp->b_flags |= XBF_READ;  	bp->b_ops = ops; -	xfsbdstrat(target->bt_mount, bp); +	if (XFS_FORCED_SHUTDOWN(target->bt_mount)) { +		xfs_buf_relse(bp); +		return NULL; +	} +	xfs_buf_iorequest(bp);  	xfs_buf_iowait(bp);  	return bp;  } @@ -1089,7 +1093,7 @@ xfs_bioerror(   * This is meant for userdata errors; metadata bufs come with   * iodone functions attached, so that we can track down errors.   */ -STATIC int +int  xfs_bioerror_relse(  	struct xfs_buf	*bp)  { @@ -1152,7 +1156,7 @@ xfs_bwrite(  	ASSERT(xfs_buf_islocked(bp));  	bp->b_flags |= XBF_WRITE; -	bp->b_flags &= ~(XBF_ASYNC | XBF_READ | _XBF_DELWRI_Q); +	bp->b_flags &= ~(XBF_ASYNC | XBF_READ | _XBF_DELWRI_Q | XBF_WRITE_FAIL);  	xfs_bdstrat_cb(bp); @@ -1164,25 +1168,6 @@ xfs_bwrite(  	return error;  } -/* - * Wrapper around bdstrat so that we can stop data from going to disk in case - * we are shutting down the filesystem.  Typically user data goes thru this - * path; one of the exceptions is the superblock. - */ -void -xfsbdstrat( -	struct xfs_mount	*mp, -	struct xfs_buf		*bp) -{ -	if (XFS_FORCED_SHUTDOWN(mp)) { -		trace_xfs_bdstrat_shut(bp, _RET_IP_); -		xfs_bioerror_relse(bp); -		return; -	} - -	xfs_buf_iorequest(bp); -} -  STATIC void  _xfs_buf_ioend(  	xfs_buf_t		*bp, @@ -1516,6 +1501,12 @@ xfs_wait_buftarg(  			struct xfs_buf *bp;  			bp = list_first_entry(&dispose, struct xfs_buf, b_lru);  			list_del_init(&bp->b_lru); +			if (bp->b_flags & XBF_WRITE_FAIL) { +				xfs_alert(btp->bt_mount, +"Corruption Alert: Buffer at block 0x%llx had permanent write failures!\n" +"Please run xfs_repair to determine the extent of the problem.", +					(long long)bp->b_bn); +			}  			xfs_buf_rele(bp);  		}  		if (loop++ != 0) @@ -1799,7 +1790,7 @@ __xfs_buf_delwri_submit(  	blk_start_plug(&plug);  	list_for_each_entry_safe(bp, n, io_list, b_list) { -		bp->b_flags &= ~(_XBF_DELWRI_Q | XBF_ASYNC); +		bp->b_flags &= ~(_XBF_DELWRI_Q | XBF_ASYNC | XBF_WRITE_FAIL);  		bp->b_flags |= XBF_WRITE;  		if (!wait) { diff --git a/fs/xfs/xfs_buf.h b/fs/xfs/xfs_buf.h index e6568336101..1cf21a4a9f2 100644 --- a/fs/xfs/xfs_buf.h +++ b/fs/xfs/xfs_buf.h @@ -45,6 +45,7 @@ typedef enum {  #define XBF_ASYNC	 (1 << 4) /* initiator will not wait for completion */  #define XBF_DONE	 (1 << 5) /* all pages in the buffer uptodate */  #define XBF_STALE	 (1 << 6) /* buffer has been staled, do not find it */ +#define XBF_WRITE_FAIL	 (1 << 24)/* async writes have failed on this buffer */  /* I/O hints for the BIO layer */  #define XBF_SYNCIO	 (1 << 10)/* treat this buffer as synchronous I/O */ @@ -70,6 +71,7 @@ typedef unsigned int xfs_buf_flags_t;  	{ XBF_ASYNC,		"ASYNC" }, \  	{ XBF_DONE,		"DONE" }, \  	{ XBF_STALE,		"STALE" }, \ +	{ XBF_WRITE_FAIL,	"WRITE_FAIL" }, \  	{ XBF_SYNCIO,		"SYNCIO" }, \  	{ XBF_FUA,		"FUA" }, \  	{ XBF_FLUSH,		"FLUSH" }, \ @@ -80,6 +82,7 @@ typedef unsigned int xfs_buf_flags_t;  	{ _XBF_DELWRI_Q,	"DELWRI_Q" }, \  	{ _XBF_COMPOUND,	"COMPOUND" } +  /*   * Internal state flags.   */ @@ -269,9 +272,6 @@ extern void xfs_buf_unlock(xfs_buf_t *);  /* Buffer Read and Write Routines */  extern int xfs_bwrite(struct xfs_buf *bp); - -extern void xfsbdstrat(struct xfs_mount *, struct xfs_buf *); -  extern void xfs_buf_ioend(xfs_buf_t *,	int);  extern void xfs_buf_ioerror(xfs_buf_t *, int);  extern void xfs_buf_ioerror_alert(struct xfs_buf *, const char *func); @@ -282,6 +282,8 @@ extern void xfs_buf_iomove(xfs_buf_t *, size_t, size_t, void *,  #define xfs_buf_zero(bp, off, len) \  	    xfs_buf_iomove((bp), (off), (len), NULL, XBRW_ZERO) +extern int xfs_bioerror_relse(struct xfs_buf *); +  static inline int xfs_buf_geterror(xfs_buf_t *bp)  {  	return bp ? bp->b_error : ENOMEM; @@ -301,7 +303,8 @@ extern void xfs_buf_terminate(void);  #define XFS_BUF_ZEROFLAGS(bp) \  	((bp)->b_flags &= ~(XBF_READ|XBF_WRITE|XBF_ASYNC| \ -			    XBF_SYNCIO|XBF_FUA|XBF_FLUSH)) +			    XBF_SYNCIO|XBF_FUA|XBF_FLUSH| \ +			    XBF_WRITE_FAIL))  void xfs_buf_stale(struct xfs_buf *bp);  #define XFS_BUF_UNSTALE(bp)	((bp)->b_flags &= ~XBF_STALE) diff --git a/fs/xfs/xfs_buf_item.c b/fs/xfs/xfs_buf_item.c index a64f67ba25d..2227b9b050b 100644 --- a/fs/xfs/xfs_buf_item.c +++ b/fs/xfs/xfs_buf_item.c @@ -496,6 +496,14 @@ xfs_buf_item_unpin(  	}  } +/* + * Buffer IO error rate limiting. Limit it to no more than 10 messages per 30 + * seconds so as to not spam logs too much on repeated detection of the same + * buffer being bad.. + */ + +DEFINE_RATELIMIT_STATE(xfs_buf_write_fail_rl_state, 30 * HZ, 10); +  STATIC uint  xfs_buf_item_push(  	struct xfs_log_item	*lip, @@ -524,6 +532,14 @@ xfs_buf_item_push(  	trace_xfs_buf_item_push(bip); +	/* has a previous flush failed due to IO errors? */ +	if ((bp->b_flags & XBF_WRITE_FAIL) && +	    ___ratelimit(&xfs_buf_write_fail_rl_state, "XFS:")) { +		xfs_warn(bp->b_target->bt_mount, +"Detected failing async write on buffer block 0x%llx. Retrying async write.\n", +			 (long long)bp->b_bn); +	} +  	if (!xfs_buf_delwri_queue(bp, buffer_list))  		rval = XFS_ITEM_FLUSHING;  	xfs_buf_unlock(bp); @@ -1096,8 +1112,9 @@ xfs_buf_iodone_callbacks(  		xfs_buf_ioerror(bp, 0); /* errno of 0 unsets the flag */ -		if (!XFS_BUF_ISSTALE(bp)) { -			bp->b_flags |= XBF_WRITE | XBF_ASYNC | XBF_DONE; +		if (!(bp->b_flags & (XBF_STALE|XBF_WRITE_FAIL))) { +			bp->b_flags |= XBF_WRITE | XBF_ASYNC | +				       XBF_DONE | XBF_WRITE_FAIL;  			xfs_buf_iorequest(bp);  		} else {  			xfs_buf_relse(bp); diff --git a/fs/xfs/xfs_dir2_node.c b/fs/xfs/xfs_dir2_node.c index 56369d4509d..48c7d18f68c 100644 --- a/fs/xfs/xfs_dir2_node.c +++ b/fs/xfs/xfs_dir2_node.c @@ -2067,12 +2067,12 @@ xfs_dir2_node_lookup(   */  int						/* error */  xfs_dir2_node_removename( -	xfs_da_args_t		*args)		/* operation arguments */ +	struct xfs_da_args	*args)		/* operation arguments */  { -	xfs_da_state_blk_t	*blk;		/* leaf block */ +	struct xfs_da_state_blk	*blk;		/* leaf block */  	int			error;		/* error return value */  	int			rval;		/* operation return value */ -	xfs_da_state_t		*state;		/* btree cursor */ +	struct xfs_da_state	*state;		/* btree cursor */  	trace_xfs_dir2_node_removename(args); @@ -2084,19 +2084,18 @@ xfs_dir2_node_removename(  	state->mp = args->dp->i_mount;  	state->blocksize = state->mp->m_dirblksize;  	state->node_ents = state->mp->m_dir_node_ents; -	/* -	 * Look up the entry we're deleting, set up the cursor. -	 */ + +	/* Look up the entry we're deleting, set up the cursor. */  	error = xfs_da3_node_lookup_int(state, &rval);  	if (error) -		rval = error; -	/* -	 * Didn't find it, upper layer screwed up. -	 */ +		goto out_free; + +	/* Didn't find it, upper layer screwed up. */  	if (rval != EEXIST) { -		xfs_da_state_free(state); -		return rval; +		error = rval; +		goto out_free;  	} +  	blk = &state->path.blk[state->path.active - 1];  	ASSERT(blk->magic == XFS_DIR2_LEAFN_MAGIC);  	ASSERT(state->extravalid); @@ -2107,7 +2106,7 @@ xfs_dir2_node_removename(  	error = xfs_dir2_leafn_remove(args, blk->bp, blk->index,  		&state->extrablk, &rval);  	if (error) -		return error; +		goto out_free;  	/*  	 * Fix the hash values up the btree.  	 */ @@ -2122,6 +2121,7 @@ xfs_dir2_node_removename(  	 */  	if (!error)  		error = xfs_dir2_node_to_leaf(state); +out_free:  	xfs_da_state_free(state);  	return error;  } diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index 27e0e544e96..104455b8046 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -618,7 +618,8 @@ xfs_setattr_nonsize(  		}  		if (!gid_eq(igid, gid)) {  			if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) { -				ASSERT(!XFS_IS_PQUOTA_ON(mp)); +				ASSERT(xfs_sb_version_has_pquotino(&mp->m_sb) || +				       !XFS_IS_PQUOTA_ON(mp));  				ASSERT(mask & ATTR_GID);  				ASSERT(gdqp);  				olddquot2 = xfs_qm_vop_chown(tp, ip, diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index b6b669df40f..eae16920655 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -193,7 +193,10 @@ xlog_bread_noalign(  	bp->b_io_length = nbblks;  	bp->b_error = 0; -	xfsbdstrat(log->l_mp, bp); +	if (XFS_FORCED_SHUTDOWN(log->l_mp)) +		return XFS_ERROR(EIO); + +	xfs_buf_iorequest(bp);  	error = xfs_buf_iowait(bp);  	if (error)  		xfs_buf_ioerror_alert(bp, __func__); @@ -4397,7 +4400,13 @@ xlog_do_recover(  	XFS_BUF_READ(bp);  	XFS_BUF_UNASYNC(bp);  	bp->b_ops = &xfs_sb_buf_ops; -	xfsbdstrat(log->l_mp, bp); + +	if (XFS_FORCED_SHUTDOWN(log->l_mp)) { +		xfs_buf_relse(bp); +		return XFS_ERROR(EIO); +	} + +	xfs_buf_iorequest(bp);  	error = xfs_buf_iowait(bp);  	if (error) {  		xfs_buf_ioerror_alert(bp, __func__); diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c index 14a4996cfec..dd88f0e27bd 100644 --- a/fs/xfs/xfs_qm.c +++ b/fs/xfs/xfs_qm.c @@ -134,8 +134,6 @@ xfs_qm_dqpurge(  {  	struct xfs_mount	*mp = dqp->q_mount;  	struct xfs_quotainfo	*qi = mp->m_quotainfo; -	struct xfs_dquot	*gdqp = NULL; -	struct xfs_dquot	*pdqp = NULL;  	xfs_dqlock(dqp);  	if ((dqp->dq_flags & XFS_DQ_FREEING) || dqp->q_nrefs != 0) { @@ -143,21 +141,6 @@ xfs_qm_dqpurge(  		return EAGAIN;  	} -	/* -	 * If this quota has a hint attached, prepare for releasing it now. -	 */ -	gdqp = dqp->q_gdquot; -	if (gdqp) { -		xfs_dqlock(gdqp); -		dqp->q_gdquot = NULL; -	} - -	pdqp = dqp->q_pdquot; -	if (pdqp) { -		xfs_dqlock(pdqp); -		dqp->q_pdquot = NULL; -	} -  	dqp->dq_flags |= XFS_DQ_FREEING;  	xfs_dqflock(dqp); @@ -206,11 +189,47 @@ xfs_qm_dqpurge(  	XFS_STATS_DEC(xs_qm_dquot_unused);  	xfs_qm_dqdestroy(dqp); +	return 0; +} + +/* + * Release the group or project dquot pointers the user dquots maybe carrying + * around as a hint, and proceed to purge the user dquot cache if requested. +*/ +STATIC int +xfs_qm_dqpurge_hints( +	struct xfs_dquot	*dqp, +	void			*data) +{ +	struct xfs_dquot	*gdqp = NULL; +	struct xfs_dquot	*pdqp = NULL; +	uint			flags = *((uint *)data); + +	xfs_dqlock(dqp); +	if (dqp->dq_flags & XFS_DQ_FREEING) { +		xfs_dqunlock(dqp); +		return EAGAIN; +	} + +	/* If this quota has a hint attached, prepare for releasing it now */ +	gdqp = dqp->q_gdquot; +	if (gdqp) +		dqp->q_gdquot = NULL; + +	pdqp = dqp->q_pdquot; +	if (pdqp) +		dqp->q_pdquot = NULL; + +	xfs_dqunlock(dqp);  	if (gdqp) -		xfs_qm_dqput(gdqp); +		xfs_qm_dqrele(gdqp);  	if (pdqp) -		xfs_qm_dqput(pdqp); +		xfs_qm_dqrele(pdqp); + +	if (flags & XFS_QMOPT_UQUOTA) +		return xfs_qm_dqpurge(dqp, NULL); +  	return 0;  } @@ -222,8 +241,18 @@ xfs_qm_dqpurge_all(  	struct xfs_mount	*mp,  	uint			flags)  { -	if (flags & XFS_QMOPT_UQUOTA) -		xfs_qm_dquot_walk(mp, XFS_DQ_USER, xfs_qm_dqpurge, NULL); +	/* +	 * We have to release group/project dquot hint(s) from the user dquot +	 * at first if they are there, otherwise we would run into an infinite +	 * loop while walking through radix tree to purge other type of dquots +	 * since their refcount is not zero if the user dquot refers to them +	 * as hint. +	 * +	 * Call the special xfs_qm_dqpurge_hints() will end up go through the +	 * general xfs_qm_dqpurge() against user dquot cache if requested. +	 */ +	xfs_qm_dquot_walk(mp, XFS_DQ_USER, xfs_qm_dqpurge_hints, &flags); +  	if (flags & XFS_QMOPT_GQUOTA)  		xfs_qm_dquot_walk(mp, XFS_DQ_GROUP, xfs_qm_dqpurge, NULL);  	if (flags & XFS_QMOPT_PQUOTA) @@ -2082,24 +2111,21 @@ xfs_qm_vop_create_dqattach(  	ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));  	ASSERT(XFS_IS_QUOTA_RUNNING(mp)); -	if (udqp) { +	if (udqp && XFS_IS_UQUOTA_ON(mp)) {  		ASSERT(ip->i_udquot == NULL); -		ASSERT(XFS_IS_UQUOTA_ON(mp));  		ASSERT(ip->i_d.di_uid == be32_to_cpu(udqp->q_core.d_id));  		ip->i_udquot = xfs_qm_dqhold(udqp);  		xfs_trans_mod_dquot(tp, udqp, XFS_TRANS_DQ_ICOUNT, 1);  	} -	if (gdqp) { +	if (gdqp && XFS_IS_GQUOTA_ON(mp)) {  		ASSERT(ip->i_gdquot == NULL); -		ASSERT(XFS_IS_GQUOTA_ON(mp));  		ASSERT(ip->i_d.di_gid == be32_to_cpu(gdqp->q_core.d_id));  		ip->i_gdquot = xfs_qm_dqhold(gdqp);  		xfs_trans_mod_dquot(tp, gdqp, XFS_TRANS_DQ_ICOUNT, 1);  	} -	if (pdqp) { +	if (pdqp && XFS_IS_PQUOTA_ON(mp)) {  		ASSERT(ip->i_pdquot == NULL); -		ASSERT(XFS_IS_PQUOTA_ON(mp));  		ASSERT(xfs_get_projid(ip) == be32_to_cpu(pdqp->q_core.d_id));  		ip->i_pdquot = xfs_qm_dqhold(pdqp); diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c index c035d11b773..647b6f1d892 100644 --- a/fs/xfs/xfs_trans_buf.c +++ b/fs/xfs/xfs_trans_buf.c @@ -314,7 +314,18 @@ xfs_trans_read_buf_map(  			ASSERT(bp->b_iodone == NULL);  			XFS_BUF_READ(bp);  			bp->b_ops = ops; -			xfsbdstrat(tp->t_mountp, bp); + +			/* +			 * XXX(hch): clean up the error handling here to be less +			 * of a mess.. +			 */ +			if (XFS_FORCED_SHUTDOWN(mp)) { +				trace_xfs_bdstrat_shut(bp, _RET_IP_); +				xfs_bioerror_relse(bp); +			} else { +				xfs_buf_iorequest(bp); +			} +  			error = xfs_buf_iowait(bp);  			if (error) {  				xfs_buf_ioerror_alert(bp, __func__);  | 
