diff options
Diffstat (limited to 'drivers/staging/comedi/range.c')
| -rw-r--r-- | drivers/staging/comedi/range.c | 46 | 
1 files changed, 22 insertions, 24 deletions
diff --git a/drivers/staging/comedi/range.c b/drivers/staging/comedi/range.c index 8fde55495d3..b6849545b81 100644 --- a/drivers/staging/comedi/range.c +++ b/drivers/staging/comedi/range.c @@ -83,8 +83,10 @@ int do_rangeinfo_ioctl(struct comedi_device *dev,  	}  	if (RANGE_LENGTH(it.range_type) != lr->length) { -		DPRINTK("wrong length %d should be %d (0x%08x)\n", -			RANGE_LENGTH(it.range_type), lr->length, it.range_type); +		dev_dbg(dev->class_dev, +			"wrong length %d should be %d (0x%08x)\n", +			RANGE_LENGTH(it.range_type), +			lr->length, it.range_type);  		return -EINVAL;  	} @@ -123,7 +125,8 @@ static int aref_invalid(struct comedi_subdevice *s, unsigned int chanspec)  	default:  		break;  	} -	DPRINTK("subdevice does not support aref %i", aref); +	dev_dbg(s->device->class_dev, "subdevice does not support aref %i", +		aref);  	return 1;  } @@ -140,28 +143,23 @@ int comedi_check_chanlist(struct comedi_subdevice *s, int n,  	unsigned int chanspec;  	int chan, range_len, i; -	if (s->range_table || s->range_table_list) { -		for (i = 0; i < n; i++) { -			chanspec = chanlist[i]; -			chan = CR_CHAN(chanspec); -			if (s->range_table) -				range_len = s->range_table->length; -			else if (s->range_table_list && chan < s->n_chan) -				range_len = s->range_table_list[chan]->length; -			else -				range_len = 0; -			if (chan >= s->n_chan || -			    CR_RANGE(chanspec) >= range_len || -			    aref_invalid(s, chanspec)) { -				dev_warn(dev->class_dev, -					 "bad chanlist[%d]=0x%08x chan=%d range length=%d\n", -					 i, chanspec, chan, range_len); -				return -EINVAL; -			} +	for (i = 0; i < n; i++) { +		chanspec = chanlist[i]; +		chan = CR_CHAN(chanspec); +		if (s->range_table) +			range_len = s->range_table->length; +		else if (s->range_table_list && chan < s->n_chan) +			range_len = s->range_table_list[chan]->length; +		else +			range_len = 0; +		if (chan >= s->n_chan || +		    CR_RANGE(chanspec) >= range_len || +		    aref_invalid(s, chanspec)) { +			dev_warn(dev->class_dev, +				 "bad chanlist[%d]=0x%08x chan=%d range length=%d\n", +				 i, chanspec, chan, range_len); +			return -EINVAL;  		} -	} else { -		dev_err(dev->class_dev, "(bug) no range type list!\n"); -		return -EINVAL;  	}  	return 0;  }  | 
