diff options
Diffstat (limited to 'drivers/net/wireless/rtlwifi/rtl8192de')
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 58 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 36 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/hw.h | 7 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/phy.c | 457 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/phy.h | 49 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/reg.h | 14 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/rf.c | 6 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/rf.h | 18 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/sw.c | 3 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/trx.c | 8 | ||||
| -rw-r--r-- | drivers/net/wireless/rtlwifi/rtl8192de/trx.h | 7 | 
11 files changed, 272 insertions, 391 deletions
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c index f700f7a614b..304c443b89b 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c @@ -194,15 +194,15 @@ static void rtl92d_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)  	rtl_set_bbreg(hw, ROFDM0_LSTF, BIT(31), 1); /* hold page C counter */  	rtl_set_bbreg(hw, ROFDM1_LSTF, BIT(31), 1); /*hold page D counter */ -	ret_value = rtl_get_bbreg(hw, ROFDM0_FRAMESYNC, BMASKDWORD); +	ret_value = rtl_get_bbreg(hw, ROFDM0_FRAMESYNC, MASKDWORD);  	falsealm_cnt->cnt_fast_fsync_fail = (ret_value & 0xffff);  	falsealm_cnt->cnt_sb_search_fail = ((ret_value & 0xffff0000) >> 16); -	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER1, BMASKDWORD); +	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER1, MASKDWORD);  	falsealm_cnt->cnt_parity_fail = ((ret_value & 0xffff0000) >> 16); -	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER2, BMASKDWORD); +	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER2, MASKDWORD);  	falsealm_cnt->cnt_rate_illegal = (ret_value & 0xffff);  	falsealm_cnt->cnt_crc8_fail = ((ret_value & 0xffff0000) >> 16); -	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER3, BMASKDWORD); +	ret_value = rtl_get_bbreg(hw, ROFDM_PHYCOUNTER3, MASKDWORD);  	falsealm_cnt->cnt_mcs_fail = (ret_value & 0xffff);  	falsealm_cnt->cnt_ofdm_fail = falsealm_cnt->cnt_parity_fail +  				      falsealm_cnt->cnt_rate_illegal + @@ -214,9 +214,9 @@ static void rtl92d_dm_false_alarm_counter_statistics(struct ieee80211_hw *hw)  	if (rtlpriv->rtlhal.current_bandtype != BAND_ON_5G) {  		/* hold cck counter */  		rtl92d_acquire_cckandrw_pagea_ctl(hw, &flag); -		ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERLOWER, BMASKBYTE0); +		ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERLOWER, MASKBYTE0);  		falsealm_cnt->cnt_cck_fail = ret_value; -		ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERUPPER, BMASKBYTE3); +		ret_value = rtl_get_bbreg(hw, RCCK0_FACOUNTERUPPER, MASKBYTE3);  		falsealm_cnt->cnt_cck_fail += (ret_value & 0xff) << 8;  		rtl92d_release_cckandrw_pagea_ctl(hw, &flag);  	} else { @@ -331,11 +331,11 @@ static void rtl92d_dm_cck_packet_detection_thresh(struct ieee80211_hw *hw)  	if (de_digtable->pre_cck_pd_state != de_digtable->cur_cck_pd_state) {  		if (de_digtable->cur_cck_pd_state == CCK_PD_STAGE_LOWRSSI) {  			rtl92d_acquire_cckandrw_pagea_ctl(hw, &flag); -			rtl_set_bbreg(hw, RCCK0_CCA, BMASKBYTE2, 0x83); +			rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0x83);  			rtl92d_release_cckandrw_pagea_ctl(hw, &flag);  		} else {  			rtl92d_acquire_cckandrw_pagea_ctl(hw, &flag); -			rtl_set_bbreg(hw, RCCK0_CCA, BMASKBYTE2, 0xcd); +			rtl_set_bbreg(hw, RCCK0_CCA, MASKBYTE2, 0xcd);  			rtl92d_release_cckandrw_pagea_ctl(hw, &flag);  		}  		de_digtable->pre_cck_pd_state = de_digtable->cur_cck_pd_state; @@ -722,7 +722,7 @@ static void rtl92d_dm_rxgain_tracking_thermalmeter(struct ieee80211_hw *hw)  	RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,  		 "===> Rx Gain %x\n", u4tmp);  	for (i = RF90_PATH_A; i < rtlpriv->phy.num_total_rfpath; i++) -		rtl_set_rfreg(hw, i, 0x3C, BRFREGOFFSETMASK, +		rtl_set_rfreg(hw, i, 0x3C, RFREG_OFFSET_MASK,  			      (rtlpriv->phy.reg_rf3c[i] & (~(0xF000))) | u4tmp);  } @@ -737,7 +737,7 @@ static void rtl92d_bandtype_2_4G(struct ieee80211_hw *hw, long *temp_cckg,  	/* Query CCK default setting From 0xa24 */  	rtl92d_acquire_cckandrw_pagea_ctl(hw, &flag);  	temp_cck = rtl_get_bbreg(hw, RCCK0_TXFILTER2, -				 BMASKDWORD) & BMASKCCK; +				 MASKDWORD) & MASKCCK;  	rtl92d_release_cckandrw_pagea_ctl(hw, &flag);  	for (i = 0; i < CCK_TABLE_LENGTH; i++) {  		if (rtlpriv->dm.cck_inch14) { @@ -840,9 +840,9 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  	bool internal_pa = false;  	long ele_a = 0, ele_d, temp_cck, val_x, value32;  	long val_y, ele_c = 0; -	u8 ofdm_index[2]; +	u8 ofdm_index[3];  	s8 cck_index = 0; -	u8 ofdm_index_old[2] = {0, 0}; +	u8 ofdm_index_old[3] = {0, 0, 0};  	s8 cck_index_old = 0;  	u8 index;  	int i; @@ -896,9 +896,9 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  		rf = 1;  	if (thermalvalue) {  		ele_d = rtl_get_bbreg(hw, ROFDM0_XATxIQIMBALANCE, -				      BMASKDWORD) & BMASKOFDM_D; +				      MASKDWORD) & MASKOFDM_D;  		for (i = 0; i < OFDM_TABLE_SIZE_92D; i++) { -			if (ele_d == (ofdmswing_table[i] & BMASKOFDM_D)) { +			if (ele_d == (ofdmswing_table[i] & MASKOFDM_D)) {  				ofdm_index_old[0] = (u8) i;  				RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD, @@ -910,10 +910,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  		}  		if (is2t) {  			ele_d = rtl_get_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, -					      BMASKDWORD) & BMASKOFDM_D; +					      MASKDWORD) & MASKOFDM_D;  			for (i = 0; i < OFDM_TABLE_SIZE_92D; i++) {  				if (ele_d == -				    (ofdmswing_table[i] & BMASKOFDM_D)) { +				    (ofdmswing_table[i] & MASKOFDM_D)) {  					ofdm_index_old[1] = (u8) i;  					RT_TRACE(rtlpriv, COMP_POWER_TRACKING,  						 DBG_LOUD, @@ -1091,10 +1091,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  				value32 = (ele_d << 22) | ((ele_c & 0x3F) <<  					  16) | ele_a;  				rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, -					      BMASKDWORD, value32); +					      MASKDWORD, value32);  				value32 = (ele_c & 0x000003C0) >> 6; -				rtl_set_bbreg(hw, ROFDM0_XCTxAFE, BMASKH4BITS, +				rtl_set_bbreg(hw, ROFDM0_XCTxAFE, MASKH4BITS,  					      value32);  				value32 = ((val_x * ele_d) >> 7) & 0x01; @@ -1103,10 +1103,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  			} else {  				rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, -					      BMASKDWORD, +					      MASKDWORD,  					      ofdmswing_table  					      [(u8)ofdm_index[0]]); -				rtl_set_bbreg(hw, ROFDM0_XCTxAFE, BMASKH4BITS, +				rtl_set_bbreg(hw, ROFDM0_XCTxAFE, MASKH4BITS,  					      0x00);  				rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD,  					      BIT(24), 0x00); @@ -1118,6 +1118,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  				 val_x, val_y, ele_a, ele_c, ele_d,  				 val_x, val_y); +			if (cck_index >= CCK_TABLE_SIZE) +				cck_index = CCK_TABLE_SIZE - 1; +			if (cck_index < 0) +				cck_index = 0;  			if (rtlhal->current_bandtype == BAND_ON_2_4G) {  				/* Adjust CCK according to IQK result */  				if (!rtlpriv->dm.cck_inch14) { @@ -1200,21 +1204,21 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  						  ele_a;  					rtl_set_bbreg(hw,  						      ROFDM0_XBTxIQIMBALANCE, -						      BMASKDWORD, value32); +						      MASKDWORD, value32);  					value32 = (ele_c & 0x000003C0) >> 6;  					rtl_set_bbreg(hw, ROFDM0_XDTxAFE, -						      BMASKH4BITS, value32); +						      MASKH4BITS, value32);  					value32 = ((val_x * ele_d) >> 7) & 0x01;  					rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD,  						      BIT(28), value32);  				} else {  					rtl_set_bbreg(hw,  						      ROFDM0_XBTxIQIMBALANCE, -						      BMASKDWORD, +						      MASKDWORD,  						      ofdmswing_table  						      [(u8) ofdm_index[1]]);  					rtl_set_bbreg(hw, ROFDM0_XDTxAFE, -						      BMASKH4BITS, 0x00); +						      MASKH4BITS, 0x00);  					rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD,  						      BIT(28), 0x00);  				} @@ -1225,10 +1229,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(  			}  			RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,  				 "TxPwrTracking 0xc80 = 0x%x, 0xc94 = 0x%x RF 0x24 = 0x%x\n", -				 rtl_get_bbreg(hw, 0xc80, BMASKDWORD), -				 rtl_get_bbreg(hw, 0xc94, BMASKDWORD), +				 rtl_get_bbreg(hw, 0xc80, MASKDWORD), +				 rtl_get_bbreg(hw, 0xc94, MASKDWORD),  				 rtl_get_rfreg(hw, RF90_PATH_A, 0x24, -					       BRFREGOFFSETMASK)); +					       RFREG_OFFSET_MASK));  		}  		if ((delta_iqk > rtlefuse->delta_iqk) &&  		    (rtlefuse->delta_iqk != 0)) { diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c index 7dd8f6de055..2b08671004a 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c @@ -318,7 +318,7 @@ void rtl92de_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)  	case HW_VAR_AC_PARAM: {  		u8 e_aci = *val;  		rtl92d_dm_init_edca_turbo(hw); -		if (rtlpci->acm_method != eAcmWay2_SW) +		if (rtlpci->acm_method != EACMWAY2_SW)  			rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_ACM_CTRL,  						      &e_aci);  		break; @@ -985,9 +985,9 @@ int rtl92de_hw_init(struct ieee80211_hw *hw)  	/* set default value after initialize RF,  */  	rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER4, 0x00f00000, 0);  	rtlphy->rfreg_chnlval[0] = rtl_get_rfreg(hw, (enum radio_path)0, -			RF_CHNLBW, BRFREGOFFSETMASK); +			RF_CHNLBW, RFREG_OFFSET_MASK);  	rtlphy->rfreg_chnlval[1] = rtl_get_rfreg(hw, (enum radio_path)1, -			RF_CHNLBW, BRFREGOFFSETMASK); +			RF_CHNLBW, RFREG_OFFSET_MASK);  	/*---- Set CCK and OFDM Block "ON"----*/  	if (rtlhal->current_bandtype == BAND_ON_2_4G) @@ -1035,7 +1035,7 @@ int rtl92de_hw_init(struct ieee80211_hw *hw)  				tmp_rega = rtl_get_rfreg(hw,  						  (enum radio_path)RF90_PATH_A, -						  0x2a, BMASKDWORD); +						  0x2a, MASKDWORD);  				if (((tmp_rega & BIT(11)) == BIT(11)))  					break; @@ -1138,11 +1138,13 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw,  void rtl92de_set_check_bssid(struct ieee80211_hw *hw, bool check_bssid)  {  	struct rtl_priv *rtlpriv = rtl_priv(hw); -	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); -	u32 reg_rcr = rtlpci->receive_config; +	u32 reg_rcr;  	if (rtlpriv->psc.rfpwr_state != ERFON)  		return; + +	rtlpriv->cfg->ops->get_hw_reg(hw, HW_VAR_RCR, (u8 *)(®_rcr)); +  	if (check_bssid) {  		reg_rcr |= (RCR_CBSSID_DATA | RCR_CBSSID_BCN);  		rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_RCR, (u8 *)(®_rcr)); @@ -1194,25 +1196,7 @@ void rtl92d_linked_set_reg(struct ieee80211_hw *hw)   * mac80211 will send pkt when scan */  void rtl92de_set_qos(struct ieee80211_hw *hw, int aci)  { -	struct rtl_priv *rtlpriv = rtl_priv(hw);  	rtl92d_dm_init_edca_turbo(hw); -	return; -	switch (aci) { -	case AC1_BK: -		rtl_write_dword(rtlpriv, REG_EDCA_BK_PARAM, 0xa44f); -		break; -	case AC0_BE: -		break; -	case AC2_VI: -		rtl_write_dword(rtlpriv, REG_EDCA_VI_PARAM, 0x5e4322); -		break; -	case AC3_VO: -		rtl_write_dword(rtlpriv, REG_EDCA_VO_PARAM, 0x2f3222); -		break; -	default: -		RT_ASSERT(false, "invalid aci: %d !\n", aci); -		break; -	}  }  void rtl92de_enable_interrupt(struct ieee80211_hw *hw) @@ -1350,13 +1334,13 @@ void rtl92de_card_disable(struct ieee80211_hw *hw)  	/* c. ========RF OFF sequence==========  */  	/* 0x88c[23:20] = 0xf. */  	rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER4, 0x00f00000, 0xf); -	rtl_set_rfreg(hw, RF90_PATH_A, 0x00, BRFREGOFFSETMASK, 0x00); +	rtl_set_rfreg(hw, RF90_PATH_A, 0x00, RFREG_OFFSET_MASK, 0x00);  	/* APSD_CTRL 0x600[7:0] = 0x40 */  	rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x40);  	/* Close antenna 0,0xc04,0xd04 */ -	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKBYTE0, 0); +	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKBYTE0, 0);  	rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE, BDWORD, 0);  	/*  SYS_FUNC_EN 0x02[7:0] = 0xE2   reset BB state machine */ diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.h b/drivers/net/wireless/rtlwifi/rtl8192de/hw.h index 7c9f7a2f1e4..1bc7b1a96d4 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.h +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.h @@ -55,10 +55,9 @@ void rtl92de_set_key(struct ieee80211_hw *hw, u32 key_index,  		     u8 *p_macaddr, bool is_group, u8 enc_algo,  		     bool is_wepkey, bool clear_all); -extern void rtl92de_write_dword_dbi(struct ieee80211_hw *hw, u16 offset, -				    u32 value, u8 direct); -extern u32 rtl92de_read_dword_dbi(struct ieee80211_hw *hw, u16 offset, -				  u8 direct); +void rtl92de_write_dword_dbi(struct ieee80211_hw *hw, u16 offset, u32 value, +			     u8 direct); +u32 rtl92de_read_dword_dbi(struct ieee80211_hw *hw, u16 offset, u8 direct);  void rtl92de_suspend(struct ieee80211_hw *hw);  void rtl92de_resume(struct ieee80211_hw *hw);  void rtl92d_linked_set_reg(struct ieee80211_hw *hw); diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c index 840bac5fa2f..3d1f0dd4e52 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c @@ -30,6 +30,7 @@  #include "../wifi.h"  #include "../pci.h"  #include "../ps.h" +#include "../core.h"  #include "reg.h"  #include "def.h"  #include "phy.h" @@ -242,7 +243,7 @@ void rtl92d_phy_set_bb_reg(struct ieee80211_hw *hw,  	else if (rtlhal->during_mac0init_radiob)  		/* mac0 use phy1 write radio_b. */  		dbi_direct = BIT(3) | BIT(2); -	if (bitmask != BMASKDWORD) { +	if (bitmask != MASKDWORD) {  		if (rtlhal->during_mac1init_radioa ||  		    rtlhal->during_mac0init_radiob)  			originalvalue = rtl92de_read_dword_dbi(hw, @@ -275,20 +276,20 @@ static u32 _rtl92d_phy_rf_serial_read(struct ieee80211_hw *hw,  	u32 retvalue;  	newoffset = offset; -	tmplong = rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, BMASKDWORD); +	tmplong = rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD);  	if (rfpath == RF90_PATH_A)  		tmplong2 = tmplong;  	else -		tmplong2 = rtl_get_bbreg(hw, pphyreg->rfhssi_para2, BMASKDWORD); +		tmplong2 = rtl_get_bbreg(hw, pphyreg->rfhssi_para2, MASKDWORD);  	tmplong2 = (tmplong2 & (~BLSSIREADADDRESS)) |  		(newoffset << 23) | BLSSIREADEDGE; -	rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD,  		tmplong & (~BLSSIREADEDGE));  	udelay(10); -	rtl_set_bbreg(hw, pphyreg->rfhssi_para2, BMASKDWORD, tmplong2); +	rtl_set_bbreg(hw, pphyreg->rfhssi_para2, MASKDWORD, tmplong2);  	udelay(50);  	udelay(50); -	rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, MASKDWORD,  		tmplong | BLSSIREADEDGE);  	udelay(10);  	if (rfpath == RF90_PATH_A) @@ -321,7 +322,7 @@ static void _rtl92d_phy_rf_serial_write(struct ieee80211_hw *hw,  	newoffset = offset;  	/* T65 RF */  	data_and_addr = ((newoffset << 20) | (data & 0x000fffff)) & 0x0fffffff; -	rtl_set_bbreg(hw, pphyreg->rf3wire_offset, BMASKDWORD, data_and_addr); +	rtl_set_bbreg(hw, pphyreg->rf3wire_offset, MASKDWORD, data_and_addr);  	RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, "RFW-%d Addr[0x%x]=0x%x\n",  		 rfpath, pphyreg->rf3wire_offset, data_and_addr);  } @@ -362,7 +363,7 @@ void rtl92d_phy_set_rf_reg(struct ieee80211_hw *hw, enum radio_path rfpath,  		return;  	spin_lock_irqsave(&rtlpriv->locks.rf_lock, flags);  	if (rtlphy->rf_mode != RF_OP_BY_FW) { -		if (bitmask != BRFREGOFFSETMASK) { +		if (bitmask != RFREG_OFFSET_MASK) {  			original_value = _rtl92d_phy_rf_serial_read(hw,  				rfpath, regaddr);  			bitshift = _rtl92d_phy_calculate_bit_shift(bitmask); @@ -567,19 +568,8 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,  		 " ===> phy:Rtl819XPHY_REG_Array_PG\n");  	if (configtype == BASEBAND_CONFIG_PHY_REG) {  		for (i = 0; i < phy_reg_arraylen; i = i + 2) { -			if (phy_regarray_table[i] == 0xfe) -				mdelay(50); -			else if (phy_regarray_table[i] == 0xfd) -				mdelay(5); -			else if (phy_regarray_table[i] == 0xfc) -				mdelay(1); -			else if (phy_regarray_table[i] == 0xfb) -				udelay(50); -			else if (phy_regarray_table[i] == 0xfa) -				udelay(5); -			else if (phy_regarray_table[i] == 0xf9) -				udelay(1); -			rtl_set_bbreg(hw, phy_regarray_table[i], BMASKDWORD, +			rtl_addr_delay(phy_regarray_table[i]); +			rtl_set_bbreg(hw, phy_regarray_table[i], MASKDWORD,  				      phy_regarray_table[i + 1]);  			udelay(1);  			RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, @@ -591,7 +581,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,  		if (rtlhal->interfaceindex == 0) {  			for (i = 0; i < agctab_arraylen; i = i + 2) {  				rtl_set_bbreg(hw, agctab_array_table[i], -					BMASKDWORD, +					MASKDWORD,  					agctab_array_table[i + 1]);  				/* Add 1us delay between BB/RF register  				 * setting. */ @@ -607,7 +597,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,  			if (rtlhal->current_bandtype == BAND_ON_2_4G) {  				for (i = 0; i < agctab_arraylen; i = i + 2) {  					rtl_set_bbreg(hw, agctab_array_table[i], -						BMASKDWORD, +						MASKDWORD,  						agctab_array_table[i + 1]);  					/* Add 1us delay between BB/RF register  					 * setting. */ @@ -623,7 +613,7 @@ static bool _rtl92d_phy_config_bb_with_headerfile(struct ieee80211_hw *hw,  				for (i = 0; i < agctab_5garraylen; i = i + 2) {  					rtl_set_bbreg(hw,  						agctab_5garray_table[i], -						BMASKDWORD, +						MASKDWORD,  						agctab_5garray_table[i + 1]);  					/* Add 1us delay between BB/RF registeri  					 * setting. */ @@ -705,18 +695,7 @@ static bool _rtl92d_phy_config_bb_with_pgheaderfile(struct ieee80211_hw *hw,  	phy_regarray_table_pg = rtl8192de_phy_reg_array_pg;  	if (configtype == BASEBAND_CONFIG_PHY_REG) {  		for (i = 0; i < phy_regarray_pg_len; i = i + 3) { -			if (phy_regarray_table_pg[i] == 0xfe) -				mdelay(50); -			else if (phy_regarray_table_pg[i] == 0xfd) -				mdelay(5); -			else if (phy_regarray_table_pg[i] == 0xfc) -				mdelay(1); -			else if (phy_regarray_table_pg[i] == 0xfb) -				udelay(50); -			else if (phy_regarray_table_pg[i] == 0xfa) -				udelay(5); -			else if (phy_regarray_table_pg[i] == 0xf9) -				udelay(1); +			rtl_addr_delay(phy_regarray_table_pg[i]);  			_rtl92d_store_pwrindex_diffrate_offset(hw,  				phy_regarray_table_pg[i],  				phy_regarray_table_pg[i + 1], @@ -843,54 +822,16 @@ bool rtl92d_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,  	switch (rfpath) {  	case RF90_PATH_A:  		for (i = 0; i < radioa_arraylen; i = i + 2) { -			if (radioa_array_table[i] == 0xfe) { -				mdelay(50); -			} else if (radioa_array_table[i] == 0xfd) { -				/* delay_ms(5); */ -				mdelay(5); -			} else if (radioa_array_table[i] == 0xfc) { -				/* delay_ms(1); */ -				mdelay(1); -			} else if (radioa_array_table[i] == 0xfb) { -				udelay(50); -			} else if (radioa_array_table[i] == 0xfa) { -				udelay(5); -			} else if (radioa_array_table[i] == 0xf9) { -				udelay(1); -			} else { -				rtl_set_rfreg(hw, rfpath, radioa_array_table[i], -					      BRFREGOFFSETMASK, -					      radioa_array_table[i + 1]); -				/*  Add 1us delay between BB/RF register set. */ -				udelay(1); -			} +			rtl_rfreg_delay(hw, rfpath, radioa_array_table[i], +					RFREG_OFFSET_MASK, +					radioa_array_table[i + 1]);  		}  		break;  	case RF90_PATH_B:  		for (i = 0; i < radiob_arraylen; i = i + 2) { -			if (radiob_array_table[i] == 0xfe) { -				/* Delay specific ms. Only RF configuration -				 * requires delay. */ -				mdelay(50); -			} else if (radiob_array_table[i] == 0xfd) { -				/* delay_ms(5); */ -				mdelay(5); -			} else if (radiob_array_table[i] == 0xfc) { -				/* delay_ms(1); */ -				mdelay(1); -			} else if (radiob_array_table[i] == 0xfb) { -				udelay(50); -			} else if (radiob_array_table[i] == 0xfa) { -				udelay(5); -			} else if (radiob_array_table[i] == 0xf9) { -				udelay(1); -			} else { -				rtl_set_rfreg(hw, rfpath, radiob_array_table[i], -					      BRFREGOFFSETMASK, -					      radiob_array_table[i + 1]); -				/*  Add 1us delay between BB/RF register set. */ -				udelay(1); -			} +			rtl_rfreg_delay(hw, rfpath, radiob_array_table[i], +					RFREG_OFFSET_MASK, +					radiob_array_table[i + 1]);  		}  		break;  	case RF90_PATH_C: @@ -911,13 +852,13 @@ void rtl92d_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw)  	struct rtl_phy *rtlphy = &(rtlpriv->phy);  	rtlphy->default_initialgain[0] = -	    (u8) rtl_get_bbreg(hw, ROFDM0_XAAGCCORE1, BMASKBYTE0); +	    (u8) rtl_get_bbreg(hw, ROFDM0_XAAGCCORE1, MASKBYTE0);  	rtlphy->default_initialgain[1] = -	    (u8) rtl_get_bbreg(hw, ROFDM0_XBAGCCORE1, BMASKBYTE0); +	    (u8) rtl_get_bbreg(hw, ROFDM0_XBAGCCORE1, MASKBYTE0);  	rtlphy->default_initialgain[2] = -	    (u8) rtl_get_bbreg(hw, ROFDM0_XCAGCCORE1, BMASKBYTE0); +	    (u8) rtl_get_bbreg(hw, ROFDM0_XCAGCCORE1, MASKBYTE0);  	rtlphy->default_initialgain[3] = -	    (u8) rtl_get_bbreg(hw, ROFDM0_XDAGCCORE1, BMASKBYTE0); +	    (u8) rtl_get_bbreg(hw, ROFDM0_XDAGCCORE1, MASKBYTE0);  	RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,  		 "Default initial gain (c50=0x%x, c58=0x%x, c60=0x%x, c68=0x%x\n",  		 rtlphy->default_initialgain[0], @@ -925,9 +866,9 @@ void rtl92d_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw)  		 rtlphy->default_initialgain[2],  		 rtlphy->default_initialgain[3]);  	rtlphy->framesync = (u8)rtl_get_bbreg(hw, ROFDM0_RXDETECTOR3, -					      BMASKBYTE0); +					      MASKBYTE0);  	rtlphy->framesync_c34 = rtl_get_bbreg(hw, ROFDM0_RXDETECTOR2, -					      BMASKDWORD); +					      MASKDWORD);  	RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,  		 "Default framesync (0x%x) = 0x%x\n",  		 ROFDM0_RXDETECTOR3, rtlphy->framesync); @@ -1022,34 +963,6 @@ void rtl92d_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel)  	rtl92d_phy_rf6052_set_ofdm_txpower(hw, &ofdmpowerlevel[0], channel);  } -void rtl92d_phy_scan_operation_backup(struct ieee80211_hw *hw, u8 operation) -{ -	struct rtl_priv *rtlpriv = rtl_priv(hw); -	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); -	enum io_type iotype; - -	if (!is_hal_stop(rtlhal)) { -		switch (operation) { -		case SCAN_OPT_BACKUP: -			rtlhal->current_bandtypebackup = -						 rtlhal->current_bandtype; -			iotype = IO_CMD_PAUSE_DM_BY_SCAN; -			rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_IO_CMD, -						      (u8 *)&iotype); -			break; -		case SCAN_OPT_RESTORE: -			iotype = IO_CMD_RESUME_DM_BY_SCAN; -			rtlpriv->cfg->ops->set_hw_reg(hw, HW_VAR_IO_CMD, -						      (u8 *)&iotype); -			break; -		default: -			RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, -				 "Unknown Scan Backup operation\n"); -			break; -		} -	} -} -  void rtl92d_phy_set_bw_mode(struct ieee80211_hw *hw,  			    enum nl80211_channel_type ch_type)  { @@ -1134,7 +1047,7 @@ static void _rtl92d_phy_stop_trx_before_changeband(struct ieee80211_hw *hw)  {  	rtl_set_bbreg(hw, RFPGA0_RFMOD, BCCKEN, 0);  	rtl_set_bbreg(hw, RFPGA0_RFMOD, BOFDMEN, 0); -	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKBYTE0, 0x00); +	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKBYTE0, 0x00);  	rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE, BDWORD, 0x0);  } @@ -1196,7 +1109,7 @@ static void _rtl92d_phy_reload_imr_setting(struct ieee80211_hw *hw,  {  	struct rtl_priv *rtlpriv = rtl_priv(hw);  	u32 imr_num = MAX_RF_IMR_INDEX; -	u32 rfmask = BRFREGOFFSETMASK; +	u32 rfmask = RFREG_OFFSET_MASK;  	u8 group, i;  	unsigned long flag = 0; @@ -1239,7 +1152,7 @@ static void _rtl92d_phy_reload_imr_setting(struct ieee80211_hw *hw,  			for (i = 0; i < imr_num; i++) {  				rtl_set_rfreg(hw, (enum radio_path)rfpath,  					      rf_reg_for_5g_swchnl_normal[i], -					      BRFREGOFFSETMASK, +					      RFREG_OFFSET_MASK,  					      rf_imr_param_normal[0][0][i]);  			}  			rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER4, @@ -1357,7 +1270,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  			if (i == 0 && (rtlhal->macphymode == DUALMAC_DUALPHY)) {  				rtl_set_rfreg(hw, (enum radio_path)path,  					      rf_reg_for_c_cut_5g[i], -					      BRFREGOFFSETMASK, 0xE439D); +					      RFREG_OFFSET_MASK, 0xE439D);  			} else if (rf_reg_for_c_cut_5g[i] == RF_SYN_G4) {  				u4tmp2 = (rf_reg_pram_c_5g[index][i] &  				     0x7FF) | (u4tmp << 11); @@ -1365,11 +1278,11 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  					u4tmp2 &= ~(BIT(7) | BIT(6));  				rtl_set_rfreg(hw, (enum radio_path)path,  					      rf_reg_for_c_cut_5g[i], -					      BRFREGOFFSETMASK, u4tmp2); +					      RFREG_OFFSET_MASK, u4tmp2);  			} else {  				rtl_set_rfreg(hw, (enum radio_path)path,  					      rf_reg_for_c_cut_5g[i], -					      BRFREGOFFSETMASK, +					      RFREG_OFFSET_MASK,  					      rf_reg_pram_c_5g[index][i]);  			}  			RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, @@ -1379,7 +1292,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  				 path, index,  				 rtl_get_rfreg(hw, (enum radio_path)path,  					       rf_reg_for_c_cut_5g[i], -					       BRFREGOFFSETMASK)); +					       RFREG_OFFSET_MASK));  		}  		if (need_pwr_down)  			_rtl92d_phy_restore_rf_env(hw, path, &u4regvalue); @@ -1409,7 +1322,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  				     i++) {  					rtl_set_rfreg(hw, rfpath,  						rf_for_c_cut_5g_internal_pa[i], -						BRFREGOFFSETMASK, +						RFREG_OFFSET_MASK,  						rf_pram_c_5g_int_pa[index][i]);  					RT_TRACE(rtlpriv, COMP_RF, DBG_LOUD,  						 "offset 0x%x value 0x%x path %d index %d\n", @@ -1450,13 +1363,13 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  			if (rf_reg_for_c_cut_2g[i] == RF_SYN_G7)  				rtl_set_rfreg(hw, (enum radio_path)path,  					rf_reg_for_c_cut_2g[i], -					BRFREGOFFSETMASK, +					RFREG_OFFSET_MASK,  					(rf_reg_param_for_c_cut_2g[index][i] |  					BIT(17)));  			else  				rtl_set_rfreg(hw, (enum radio_path)path,  					      rf_reg_for_c_cut_2g[i], -					      BRFREGOFFSETMASK, +					      RFREG_OFFSET_MASK,  					      rf_reg_param_for_c_cut_2g  					      [index][i]);  			RT_TRACE(rtlpriv, COMP_RF, DBG_TRACE, @@ -1466,14 +1379,14 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)  				 rf_reg_mask_for_c_cut_2g[i], path, index,  				 rtl_get_rfreg(hw, (enum radio_path)path,  					       rf_reg_for_c_cut_2g[i], -					       BRFREGOFFSETMASK)); +					       RFREG_OFFSET_MASK));  		}  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"cosa ver 3 set RF-B, 2G, 0x28 = 0x%x !!\n",  			rf_syn_g4_for_c_cut_2g | (u4tmp << 11));  		rtl_set_rfreg(hw, (enum radio_path)path, RF_SYN_G4, -			      BRFREGOFFSETMASK, +			      RFREG_OFFSET_MASK,  			      rf_syn_g4_for_c_cut_2g | (u4tmp << 11));  		if (need_pwr_down)  			_rtl92d_phy_restore_rf_env(hw, path, &u4regvalue); @@ -1521,41 +1434,41 @@ static u8 _rtl92d_phy_patha_iqk(struct ieee80211_hw *hw, bool configpathb)  	/* path-A IQK setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path-A IQK setting!\n");  	if (rtlhal->interfaceindex == 0) { -		rtl_set_bbreg(hw, 0xe30, BMASKDWORD, 0x10008c1f); -		rtl_set_bbreg(hw, 0xe34, BMASKDWORD, 0x10008c1f); +		rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x10008c1f); +		rtl_set_bbreg(hw, 0xe34, MASKDWORD, 0x10008c1f);  	} else { -		rtl_set_bbreg(hw, 0xe30, BMASKDWORD, 0x10008c22); -		rtl_set_bbreg(hw, 0xe34, BMASKDWORD, 0x10008c22); +		rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x10008c22); +		rtl_set_bbreg(hw, 0xe34, MASKDWORD, 0x10008c22);  	} -	rtl_set_bbreg(hw, 0xe38, BMASKDWORD, 0x82140102); -	rtl_set_bbreg(hw, 0xe3c, BMASKDWORD, 0x28160206); +	rtl_set_bbreg(hw, 0xe38, MASKDWORD, 0x82140102); +	rtl_set_bbreg(hw, 0xe3c, MASKDWORD, 0x28160206);  	/* path-B IQK setting */  	if (configpathb) { -		rtl_set_bbreg(hw, 0xe50, BMASKDWORD, 0x10008c22); -		rtl_set_bbreg(hw, 0xe54, BMASKDWORD, 0x10008c22); -		rtl_set_bbreg(hw, 0xe58, BMASKDWORD, 0x82140102); -		rtl_set_bbreg(hw, 0xe5c, BMASKDWORD, 0x28160206); +		rtl_set_bbreg(hw, 0xe50, MASKDWORD, 0x10008c22); +		rtl_set_bbreg(hw, 0xe54, MASKDWORD, 0x10008c22); +		rtl_set_bbreg(hw, 0xe58, MASKDWORD, 0x82140102); +		rtl_set_bbreg(hw, 0xe5c, MASKDWORD, 0x28160206);  	}  	/* LO calibration setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "LO calibration setting!\n"); -	rtl_set_bbreg(hw, 0xe4c, BMASKDWORD, 0x00462911); +	rtl_set_bbreg(hw, 0xe4c, MASKDWORD, 0x00462911);  	/* One shot, path A LOK & IQK */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "One shot, path A LOK & IQK!\n"); -	rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xf9000000); -	rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xf8000000); +	rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xf9000000); +	rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xf8000000);  	/* delay x ms */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"Delay %d ms for One shot, path A LOK & IQK\n",  		IQK_DELAY_TIME);  	mdelay(IQK_DELAY_TIME);  	/* Check failed */ -	regeac = rtl_get_bbreg(hw, 0xeac, BMASKDWORD); +	regeac = rtl_get_bbreg(hw, 0xeac, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeac = 0x%x\n", regeac); -	rege94 = rtl_get_bbreg(hw, 0xe94, BMASKDWORD); +	rege94 = rtl_get_bbreg(hw, 0xe94, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xe94 = 0x%x\n", rege94); -	rege9c = rtl_get_bbreg(hw, 0xe9c, BMASKDWORD); +	rege9c = rtl_get_bbreg(hw, 0xe9c, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xe9c = 0x%x\n", rege9c); -	regea4 = rtl_get_bbreg(hw, 0xea4, BMASKDWORD); +	regea4 = rtl_get_bbreg(hw, 0xea4, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xea4 = 0x%x\n", regea4);  	if (!(regeac & BIT(28)) && (((rege94 & 0x03FF0000) >> 16) != 0x142) &&  	    (((rege9c & 0x03FF0000) >> 16) != 0x42)) @@ -1591,42 +1504,42 @@ static u8 _rtl92d_phy_patha_iqk_5g_normal(struct ieee80211_hw *hw,  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path A IQK!\n");  	/* path-A IQK setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path-A IQK setting!\n"); -	rtl_set_bbreg(hw, 0xe30, BMASKDWORD, 0x18008c1f); -	rtl_set_bbreg(hw, 0xe34, BMASKDWORD, 0x18008c1f); -	rtl_set_bbreg(hw, 0xe38, BMASKDWORD, 0x82140307); -	rtl_set_bbreg(hw, 0xe3c, BMASKDWORD, 0x68160960); +	rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x18008c1f); +	rtl_set_bbreg(hw, 0xe34, MASKDWORD, 0x18008c1f); +	rtl_set_bbreg(hw, 0xe38, MASKDWORD, 0x82140307); +	rtl_set_bbreg(hw, 0xe3c, MASKDWORD, 0x68160960);  	/* path-B IQK setting */  	if (configpathb) { -		rtl_set_bbreg(hw, 0xe50, BMASKDWORD, 0x18008c2f); -		rtl_set_bbreg(hw, 0xe54, BMASKDWORD, 0x18008c2f); -		rtl_set_bbreg(hw, 0xe58, BMASKDWORD, 0x82110000); -		rtl_set_bbreg(hw, 0xe5c, BMASKDWORD, 0x68110000); +		rtl_set_bbreg(hw, 0xe50, MASKDWORD, 0x18008c2f); +		rtl_set_bbreg(hw, 0xe54, MASKDWORD, 0x18008c2f); +		rtl_set_bbreg(hw, 0xe58, MASKDWORD, 0x82110000); +		rtl_set_bbreg(hw, 0xe5c, MASKDWORD, 0x68110000);  	}  	/* LO calibration setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "LO calibration setting!\n"); -	rtl_set_bbreg(hw, 0xe4c, BMASKDWORD, 0x00462911); +	rtl_set_bbreg(hw, 0xe4c, MASKDWORD, 0x00462911);  	/* path-A PA on */ -	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, BMASKDWORD, 0x07000f60); -	rtl_set_bbreg(hw, RFPGA0_XA_RFINTERFACEOE, BMASKDWORD, 0x66e60e30); +	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, MASKDWORD, 0x07000f60); +	rtl_set_bbreg(hw, RFPGA0_XA_RFINTERFACEOE, MASKDWORD, 0x66e60e30);  	for (i = 0; i < retrycount; i++) {  		/* One shot, path A LOK & IQK */  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"One shot, path A LOK & IQK!\n"); -		rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xf9000000); -		rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xf8000000); +		rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xf9000000); +		rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xf8000000);  		/* delay x ms */  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"Delay %d ms for One shot, path A LOK & IQK.\n",  			IQK_DELAY_TIME);  		mdelay(IQK_DELAY_TIME * 10);  		/* Check failed */ -		regeac = rtl_get_bbreg(hw, 0xeac, BMASKDWORD); +		regeac = rtl_get_bbreg(hw, 0xeac, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeac = 0x%x\n", regeac); -		rege94 = rtl_get_bbreg(hw, 0xe94, BMASKDWORD); +		rege94 = rtl_get_bbreg(hw, 0xe94, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xe94 = 0x%x\n", rege94); -		rege9c = rtl_get_bbreg(hw, 0xe9c, BMASKDWORD); +		rege9c = rtl_get_bbreg(hw, 0xe9c, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xe9c = 0x%x\n", rege9c); -		regea4 = rtl_get_bbreg(hw, 0xea4, BMASKDWORD); +		regea4 = rtl_get_bbreg(hw, 0xea4, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xea4 = 0x%x\n", regea4);  		if (!(regeac & TxOKBit) &&  		     (((rege94 & 0x03FF0000) >> 16) != 0x142)) { @@ -1648,9 +1561,9 @@ static u8 _rtl92d_phy_patha_iqk_5g_normal(struct ieee80211_hw *hw,  		}  	}  	/* path A PA off */ -	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, MASKDWORD,  		      rtlphy->iqk_bb_backup[0]); -	rtl_set_bbreg(hw, RFPGA0_XA_RFINTERFACEOE, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XA_RFINTERFACEOE, MASKDWORD,  		      rtlphy->iqk_bb_backup[1]);  	return result;  } @@ -1665,22 +1578,22 @@ static u8 _rtl92d_phy_pathb_iqk(struct ieee80211_hw *hw)  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path B IQK!\n");  	/* One shot, path B LOK & IQK */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "One shot, path A LOK & IQK!\n"); -	rtl_set_bbreg(hw, 0xe60, BMASKDWORD, 0x00000002); -	rtl_set_bbreg(hw, 0xe60, BMASKDWORD, 0x00000000); +	rtl_set_bbreg(hw, 0xe60, MASKDWORD, 0x00000002); +	rtl_set_bbreg(hw, 0xe60, MASKDWORD, 0x00000000);  	/* delay x ms  */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"Delay %d ms for One shot, path B LOK & IQK\n", IQK_DELAY_TIME);  	mdelay(IQK_DELAY_TIME);  	/* Check failed */ -	regeac = rtl_get_bbreg(hw, 0xeac, BMASKDWORD); +	regeac = rtl_get_bbreg(hw, 0xeac, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeac = 0x%x\n", regeac); -	regeb4 = rtl_get_bbreg(hw, 0xeb4, BMASKDWORD); +	regeb4 = rtl_get_bbreg(hw, 0xeb4, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeb4 = 0x%x\n", regeb4); -	regebc = rtl_get_bbreg(hw, 0xebc, BMASKDWORD); +	regebc = rtl_get_bbreg(hw, 0xebc, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xebc = 0x%x\n", regebc); -	regec4 = rtl_get_bbreg(hw, 0xec4, BMASKDWORD); +	regec4 = rtl_get_bbreg(hw, 0xec4, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xec4 = 0x%x\n", regec4); -	regecc = rtl_get_bbreg(hw, 0xecc, BMASKDWORD); +	regecc = rtl_get_bbreg(hw, 0xecc, MASKDWORD);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xecc = 0x%x\n", regecc);  	if (!(regeac & BIT(31)) && (((regeb4 & 0x03FF0000) >> 16) != 0x142) &&  	    (((regebc & 0x03FF0000) >> 16) != 0x42)) @@ -1708,31 +1621,31 @@ static u8 _rtl92d_phy_pathb_iqk_5g_normal(struct ieee80211_hw *hw)  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path B IQK!\n");  	/* path-A IQK setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path-A IQK setting!\n"); -	rtl_set_bbreg(hw, 0xe30, BMASKDWORD, 0x18008c1f); -	rtl_set_bbreg(hw, 0xe34, BMASKDWORD, 0x18008c1f); -	rtl_set_bbreg(hw, 0xe38, BMASKDWORD, 0x82110000); -	rtl_set_bbreg(hw, 0xe3c, BMASKDWORD, 0x68110000); +	rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x18008c1f); +	rtl_set_bbreg(hw, 0xe34, MASKDWORD, 0x18008c1f); +	rtl_set_bbreg(hw, 0xe38, MASKDWORD, 0x82110000); +	rtl_set_bbreg(hw, 0xe3c, MASKDWORD, 0x68110000);  	/* path-B IQK setting */ -	rtl_set_bbreg(hw, 0xe50, BMASKDWORD, 0x18008c2f); -	rtl_set_bbreg(hw, 0xe54, BMASKDWORD, 0x18008c2f); -	rtl_set_bbreg(hw, 0xe58, BMASKDWORD, 0x82140307); -	rtl_set_bbreg(hw, 0xe5c, BMASKDWORD, 0x68160960); +	rtl_set_bbreg(hw, 0xe50, MASKDWORD, 0x18008c2f); +	rtl_set_bbreg(hw, 0xe54, MASKDWORD, 0x18008c2f); +	rtl_set_bbreg(hw, 0xe58, MASKDWORD, 0x82140307); +	rtl_set_bbreg(hw, 0xe5c, MASKDWORD, 0x68160960);  	/* LO calibration setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "LO calibration setting!\n"); -	rtl_set_bbreg(hw, 0xe4c, BMASKDWORD, 0x00462911); +	rtl_set_bbreg(hw, 0xe4c, MASKDWORD, 0x00462911);  	/* path-B PA on */ -	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, BMASKDWORD, 0x0f600700); -	rtl_set_bbreg(hw, RFPGA0_XB_RFINTERFACEOE, BMASKDWORD, 0x061f0d30); +	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, MASKDWORD, 0x0f600700); +	rtl_set_bbreg(hw, RFPGA0_XB_RFINTERFACEOE, MASKDWORD, 0x061f0d30);  	for (i = 0; i < retrycount; i++) {  		/* One shot, path B LOK & IQK */  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"One shot, path A LOK & IQK!\n"); -		rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xfa000000); -		rtl_set_bbreg(hw, 0xe48, BMASKDWORD, 0xf8000000); +		rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xfa000000); +		rtl_set_bbreg(hw, 0xe48, MASKDWORD, 0xf8000000);  		/* delay x ms */  		RTPRINT(rtlpriv, FINIT, INIT_IQK, @@ -1740,15 +1653,15 @@ static u8 _rtl92d_phy_pathb_iqk_5g_normal(struct ieee80211_hw *hw)  		mdelay(IQK_DELAY_TIME * 10);  		/* Check failed */ -		regeac = rtl_get_bbreg(hw, 0xeac, BMASKDWORD); +		regeac = rtl_get_bbreg(hw, 0xeac, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeac = 0x%x\n", regeac); -		regeb4 = rtl_get_bbreg(hw, 0xeb4, BMASKDWORD); +		regeb4 = rtl_get_bbreg(hw, 0xeb4, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xeb4 = 0x%x\n", regeb4); -		regebc = rtl_get_bbreg(hw, 0xebc, BMASKDWORD); +		regebc = rtl_get_bbreg(hw, 0xebc, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xebc = 0x%x\n", regebc); -		regec4 = rtl_get_bbreg(hw, 0xec4, BMASKDWORD); +		regec4 = rtl_get_bbreg(hw, 0xec4, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xec4 = 0x%x\n", regec4); -		regecc = rtl_get_bbreg(hw, 0xecc, BMASKDWORD); +		regecc = rtl_get_bbreg(hw, 0xecc, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "0xecc = 0x%x\n", regecc);  		if (!(regeac & BIT(31)) &&  		    (((regeb4 & 0x03FF0000) >> 16) != 0x142)) @@ -1766,9 +1679,9 @@ static u8 _rtl92d_phy_pathb_iqk_5g_normal(struct ieee80211_hw *hw)  	}  	/* path B PA off */ -	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, MASKDWORD,  		      rtlphy->iqk_bb_backup[0]); -	rtl_set_bbreg(hw, RFPGA0_XB_RFINTERFACEOE, BMASKDWORD, +	rtl_set_bbreg(hw, RFPGA0_XB_RFINTERFACEOE, MASKDWORD,  		      rtlphy->iqk_bb_backup[2]);  	return result;  } @@ -1782,7 +1695,7 @@ static void _rtl92d_phy_save_adda_registers(struct ieee80211_hw *hw,  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Save ADDA parameters.\n");  	for (i = 0; i < regnum; i++) -		adda_backup[i] = rtl_get_bbreg(hw, adda_reg[i], BMASKDWORD); +		adda_backup[i] = rtl_get_bbreg(hw, adda_reg[i], MASKDWORD);  }  static void _rtl92d_phy_save_mac_registers(struct ieee80211_hw *hw, @@ -1807,7 +1720,7 @@ static void _rtl92d_phy_reload_adda_registers(struct ieee80211_hw *hw,  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"Reload ADDA power saving parameters !\n");  	for (i = 0; i < regnum; i++) -		rtl_set_bbreg(hw, adda_reg[i], BMASKDWORD, adda_backup[i]); +		rtl_set_bbreg(hw, adda_reg[i], MASKDWORD, adda_backup[i]);  }  static void _rtl92d_phy_reload_mac_registers(struct ieee80211_hw *hw, @@ -1835,7 +1748,7 @@ static void _rtl92d_phy_path_adda_on(struct ieee80211_hw *hw,  		pathon = rtlpriv->rtlhal.interfaceindex == 0 ?  		    0x04db25a4 : 0x0b1b25a4;  	for (i = 0; i < IQK_ADDA_REG_NUM; i++) -		rtl_set_bbreg(hw, adda_reg[i], BMASKDWORD, pathon); +		rtl_set_bbreg(hw, adda_reg[i], MASKDWORD, pathon);  }  static void _rtl92d_phy_mac_setting_calibration(struct ieee80211_hw *hw, @@ -1858,9 +1771,9 @@ static void _rtl92d_phy_patha_standby(struct ieee80211_hw *hw)  	struct rtl_priv *rtlpriv = rtl_priv(hw);  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path-A standby mode!\n"); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0x0); -	rtl_set_bbreg(hw, RFPGA0_XA_LSSIPARAMETER, BMASKDWORD, 0x00010000); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0x80800000); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0x0); +	rtl_set_bbreg(hw, RFPGA0_XA_LSSIPARAMETER, MASKDWORD, 0x00010000); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0x80800000);  }  static void _rtl92d_phy_pimode_switch(struct ieee80211_hw *hw, bool pi_mode) @@ -1871,8 +1784,8 @@ static void _rtl92d_phy_pimode_switch(struct ieee80211_hw *hw, bool pi_mode)  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"BB Switch to %s mode!\n", pi_mode ? "PI" : "SI");  	mode = pi_mode ? 0x01000100 : 0x01000000; -	rtl_set_bbreg(hw, 0x820, BMASKDWORD, mode); -	rtl_set_bbreg(hw, 0x828, BMASKDWORD, mode); +	rtl_set_bbreg(hw, 0x820, MASKDWORD, mode); +	rtl_set_bbreg(hw, 0x828, MASKDWORD, mode);  }  static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8], @@ -1903,7 +1816,7 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "IQK for 2.4G :Start!!!\n");  	if (t == 0) { -		bbvalue = rtl_get_bbreg(hw, RFPGA0_RFMOD, BMASKDWORD); +		bbvalue = rtl_get_bbreg(hw, RFPGA0_RFMOD, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "==>0x%08x\n", bbvalue);  		RTPRINT(rtlpriv, FINIT, INIT_IQK, "IQ Calibration for %s\n",  			is2t ? "2T2R" : "1T1R"); @@ -1926,40 +1839,40 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  		_rtl92d_phy_pimode_switch(hw, true);  	rtl_set_bbreg(hw, RFPGA0_RFMOD, BIT(24), 0x00); -	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKDWORD, 0x03a05600); -	rtl_set_bbreg(hw, ROFDM0_TRMUXPAR, BMASKDWORD, 0x000800e4); -	rtl_set_bbreg(hw, RFPGA0_XCD_RFINTERFACESW, BMASKDWORD, 0x22204000); +	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKDWORD, 0x03a05600); +	rtl_set_bbreg(hw, ROFDM0_TRMUXPAR, MASKDWORD, 0x000800e4); +	rtl_set_bbreg(hw, RFPGA0_XCD_RFINTERFACESW, MASKDWORD, 0x22204000);  	rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER4, 0xf00000, 0x0f);  	if (is2t) { -		rtl_set_bbreg(hw, RFPGA0_XA_LSSIPARAMETER, BMASKDWORD, +		rtl_set_bbreg(hw, RFPGA0_XA_LSSIPARAMETER, MASKDWORD,  			      0x00010000); -		rtl_set_bbreg(hw, RFPGA0_XB_LSSIPARAMETER, BMASKDWORD, +		rtl_set_bbreg(hw, RFPGA0_XB_LSSIPARAMETER, MASKDWORD,  			      0x00010000);  	}  	/* MAC settings */  	_rtl92d_phy_mac_setting_calibration(hw, iqk_mac_reg,  					    rtlphy->iqk_mac_backup);  	/* Page B init */ -	rtl_set_bbreg(hw, 0xb68, BMASKDWORD, 0x0f600000); +	rtl_set_bbreg(hw, 0xb68, MASKDWORD, 0x0f600000);  	if (is2t) -		rtl_set_bbreg(hw, 0xb6c, BMASKDWORD, 0x0f600000); +		rtl_set_bbreg(hw, 0xb6c, MASKDWORD, 0x0f600000);  	/* IQ calibration setting */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "IQK setting!\n"); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0x80800000); -	rtl_set_bbreg(hw, 0xe40, BMASKDWORD, 0x01007c00); -	rtl_set_bbreg(hw, 0xe44, BMASKDWORD, 0x01004800); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0x80800000); +	rtl_set_bbreg(hw, 0xe40, MASKDWORD, 0x01007c00); +	rtl_set_bbreg(hw, 0xe44, MASKDWORD, 0x01004800);  	for (i = 0; i < retrycount; i++) {  		patha_ok = _rtl92d_phy_patha_iqk(hw, is2t);  		if (patha_ok == 0x03) {  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  				"Path A IQK Success!!\n"); -			result[t][0] = (rtl_get_bbreg(hw, 0xe94, BMASKDWORD) & +			result[t][0] = (rtl_get_bbreg(hw, 0xe94, MASKDWORD) &  					0x3FF0000) >> 16; -			result[t][1] = (rtl_get_bbreg(hw, 0xe9c, BMASKDWORD) & +			result[t][1] = (rtl_get_bbreg(hw, 0xe9c, MASKDWORD) &  					0x3FF0000) >> 16; -			result[t][2] = (rtl_get_bbreg(hw, 0xea4, BMASKDWORD) & +			result[t][2] = (rtl_get_bbreg(hw, 0xea4, MASKDWORD) &  					0x3FF0000) >> 16; -			result[t][3] = (rtl_get_bbreg(hw, 0xeac, BMASKDWORD) & +			result[t][3] = (rtl_get_bbreg(hw, 0xeac, MASKDWORD) &  					0x3FF0000) >> 16;  			break;  		} else if (i == (retrycount - 1) && patha_ok == 0x01) { @@ -1967,9 +1880,9 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  				"Path A IQK Only  Tx Success!!\n"); -			result[t][0] = (rtl_get_bbreg(hw, 0xe94, BMASKDWORD) & +			result[t][0] = (rtl_get_bbreg(hw, 0xe94, MASKDWORD) &  					0x3FF0000) >> 16; -			result[t][1] = (rtl_get_bbreg(hw, 0xe9c, BMASKDWORD) & +			result[t][1] = (rtl_get_bbreg(hw, 0xe9c, MASKDWORD) &  					0x3FF0000) >> 16;  		}  	} @@ -1985,22 +1898,22 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  				RTPRINT(rtlpriv, FINIT, INIT_IQK,  					"Path B IQK Success!!\n");  				result[t][4] = (rtl_get_bbreg(hw, 0xeb4, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  				result[t][5] = (rtl_get_bbreg(hw, 0xebc, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  				result[t][6] = (rtl_get_bbreg(hw, 0xec4, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  				result[t][7] = (rtl_get_bbreg(hw, 0xecc, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  				break;  			} else if (i == (retrycount - 1) && pathb_ok == 0x01) {  				/* Tx IQK OK */  				RTPRINT(rtlpriv, FINIT, INIT_IQK,  					"Path B Only Tx IQK Success!!\n");  				result[t][4] = (rtl_get_bbreg(hw, 0xeb4, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  				result[t][5] = (rtl_get_bbreg(hw, 0xebc, -					       BMASKDWORD) & 0x3FF0000) >> 16; +					       MASKDWORD) & 0x3FF0000) >> 16;  			}  		}  		if (0x00 == pathb_ok) @@ -2012,7 +1925,7 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"IQK:Back to BB mode, load original value!\n"); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0);  	if (t != 0) {  		/* Switch back BB to SI mode after finish IQ Calibration. */  		if (!rtlphy->rfpi_enable) @@ -2032,8 +1945,8 @@ static void _rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw, long result[][8],  							  rtlphy->iqk_bb_backup,  							  IQK_BB_REG_NUM - 1);  		/* load 0xe30 IQC default value */ -		rtl_set_bbreg(hw, 0xe30, BMASKDWORD, 0x01008c00); -		rtl_set_bbreg(hw, 0xe34, BMASKDWORD, 0x01008c00); +		rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x01008c00); +		rtl_set_bbreg(hw, 0xe34, MASKDWORD, 0x01008c00);  	}  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "<==\n");  } @@ -2070,7 +1983,7 @@ static void _rtl92d_phy_iq_calibrate_5g_normal(struct ieee80211_hw *hw,  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "IQK for 5G NORMAL:Start!!!\n");  	mdelay(IQK_DELAY_TIME * 20);  	if (t == 0) { -		bbvalue = rtl_get_bbreg(hw, RFPGA0_RFMOD, BMASKDWORD); +		bbvalue = rtl_get_bbreg(hw, RFPGA0_RFMOD, MASKDWORD);  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "==>0x%08x\n", bbvalue);  		RTPRINT(rtlpriv, FINIT, INIT_IQK, "IQ Calibration for %s\n",  			is2t ? "2T2R" : "1T1R"); @@ -2100,38 +2013,38 @@ static void _rtl92d_phy_iq_calibrate_5g_normal(struct ieee80211_hw *hw,  	if (!rtlphy->rfpi_enable)  		_rtl92d_phy_pimode_switch(hw, true);  	rtl_set_bbreg(hw, RFPGA0_RFMOD, BIT(24), 0x00); -	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKDWORD, 0x03a05600); -	rtl_set_bbreg(hw, ROFDM0_TRMUXPAR, BMASKDWORD, 0x000800e4); -	rtl_set_bbreg(hw, RFPGA0_XCD_RFINTERFACESW, BMASKDWORD, 0x22208000); +	rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKDWORD, 0x03a05600); +	rtl_set_bbreg(hw, ROFDM0_TRMUXPAR, MASKDWORD, 0x000800e4); +	rtl_set_bbreg(hw, RFPGA0_XCD_RFINTERFACESW, MASKDWORD, 0x22208000);  	rtl_set_bbreg(hw, RFPGA0_ANALOGPARAMETER4, 0xf00000, 0x0f);  	/* Page B init */ -	rtl_set_bbreg(hw, 0xb68, BMASKDWORD, 0x0f600000); +	rtl_set_bbreg(hw, 0xb68, MASKDWORD, 0x0f600000);  	if (is2t) -		rtl_set_bbreg(hw, 0xb6c, BMASKDWORD, 0x0f600000); +		rtl_set_bbreg(hw, 0xb6c, MASKDWORD, 0x0f600000);  	/* IQ calibration setting  */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  "IQK setting!\n"); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0x80800000); -	rtl_set_bbreg(hw, 0xe40, BMASKDWORD, 0x10007c00); -	rtl_set_bbreg(hw, 0xe44, BMASKDWORD, 0x01004800); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0x80800000); +	rtl_set_bbreg(hw, 0xe40, MASKDWORD, 0x10007c00); +	rtl_set_bbreg(hw, 0xe44, MASKDWORD, 0x01004800);  	patha_ok = _rtl92d_phy_patha_iqk_5g_normal(hw, is2t);  	if (patha_ok == 0x03) {  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path A IQK Success!!\n"); -		result[t][0] = (rtl_get_bbreg(hw, 0xe94, BMASKDWORD) & +		result[t][0] = (rtl_get_bbreg(hw, 0xe94, MASKDWORD) &  				0x3FF0000) >> 16; -		result[t][1] = (rtl_get_bbreg(hw, 0xe9c, BMASKDWORD) & +		result[t][1] = (rtl_get_bbreg(hw, 0xe9c, MASKDWORD) &  				0x3FF0000) >> 16; -		result[t][2] = (rtl_get_bbreg(hw, 0xea4, BMASKDWORD) & +		result[t][2] = (rtl_get_bbreg(hw, 0xea4, MASKDWORD) &  				0x3FF0000) >> 16; -		result[t][3] = (rtl_get_bbreg(hw, 0xeac, BMASKDWORD) & +		result[t][3] = (rtl_get_bbreg(hw, 0xeac, MASKDWORD) &  				0x3FF0000) >> 16;  	} else if (patha_ok == 0x01) {	/* Tx IQK OK */  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"Path A IQK Only  Tx Success!!\n"); -		result[t][0] = (rtl_get_bbreg(hw, 0xe94, BMASKDWORD) & +		result[t][0] = (rtl_get_bbreg(hw, 0xe94, MASKDWORD) &  				0x3FF0000) >> 16; -		result[t][1] = (rtl_get_bbreg(hw, 0xe9c, BMASKDWORD) & +		result[t][1] = (rtl_get_bbreg(hw, 0xe9c, MASKDWORD) &  				0x3FF0000) >> 16;  	} else {  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  "Path A IQK Fail!!\n"); @@ -2144,20 +2057,20 @@ static void _rtl92d_phy_iq_calibrate_5g_normal(struct ieee80211_hw *hw,  		if (pathb_ok == 0x03) {  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  				"Path B IQK Success!!\n"); -			result[t][4] = (rtl_get_bbreg(hw, 0xeb4, BMASKDWORD) & +			result[t][4] = (rtl_get_bbreg(hw, 0xeb4, MASKDWORD) &  			     0x3FF0000) >> 16; -			result[t][5] = (rtl_get_bbreg(hw, 0xebc, BMASKDWORD) & +			result[t][5] = (rtl_get_bbreg(hw, 0xebc, MASKDWORD) &  			     0x3FF0000) >> 16; -			result[t][6] = (rtl_get_bbreg(hw, 0xec4, BMASKDWORD) & +			result[t][6] = (rtl_get_bbreg(hw, 0xec4, MASKDWORD) &  			     0x3FF0000) >> 16; -			result[t][7] = (rtl_get_bbreg(hw, 0xecc, BMASKDWORD) & +			result[t][7] = (rtl_get_bbreg(hw, 0xecc, MASKDWORD) &  			     0x3FF0000) >> 16;  		} else if (pathb_ok == 0x01) { /* Tx IQK OK */  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  				"Path B Only Tx IQK Success!!\n"); -			result[t][4] = (rtl_get_bbreg(hw, 0xeb4, BMASKDWORD) & +			result[t][4] = (rtl_get_bbreg(hw, 0xeb4, MASKDWORD) &  			     0x3FF0000) >> 16; -			result[t][5] = (rtl_get_bbreg(hw, 0xebc, BMASKDWORD) & +			result[t][5] = (rtl_get_bbreg(hw, 0xebc, MASKDWORD) &  			     0x3FF0000) >> 16;  		} else {  			RTPRINT(rtlpriv, FINIT, INIT_IQK, @@ -2168,7 +2081,7 @@ static void _rtl92d_phy_iq_calibrate_5g_normal(struct ieee80211_hw *hw,  	/* Back to BB mode, load original value */  	RTPRINT(rtlpriv, FINIT, INIT_IQK,  		"IQK:Back to BB mode, load original value!\n"); -	rtl_set_bbreg(hw, 0xe28, BMASKDWORD, 0); +	rtl_set_bbreg(hw, 0xe28, MASKDWORD, 0);  	if (t != 0) {  		if (is2t)  			_rtl92d_phy_reload_adda_registers(hw, iqk_bb_reg, @@ -2268,7 +2181,7 @@ static void _rtl92d_phy_patha_fill_iqk_matrix(struct ieee80211_hw *hw,  		return;  	} else if (iqk_ok) {  		oldval_0 = (rtl_get_bbreg(hw, ROFDM0_XATxIQIMBALANCE, -			BMASKDWORD) >> 22) & 0x3FF;	/* OFDM0_D */ +			MASKDWORD) >> 22) & 0x3FF;	/* OFDM0_D */  		val_x = result[final_candidate][0];  		if ((val_x & 0x00000200) != 0)  			val_x = val_x | 0xFFFFFC00; @@ -2299,7 +2212,7 @@ static void _rtl92d_phy_patha_fill_iqk_matrix(struct ieee80211_hw *hw,  				      ((val_y * oldval_0 >> 7) & 0x1));  		RTPRINT(rtlpriv, FINIT, INIT_IQK, "0xC80 = 0x%x\n",  			rtl_get_bbreg(hw, ROFDM0_XATxIQIMBALANCE, -				      BMASKDWORD)); +				      MASKDWORD));  		if (txonly) {  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  "only Tx OK\n");  			return; @@ -2327,7 +2240,7 @@ static void _rtl92d_phy_pathb_fill_iqk_matrix(struct ieee80211_hw *hw,  		return;  	} else if (iqk_ok) {  		oldval_1 = (rtl_get_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, -					  BMASKDWORD) >> 22) & 0x3FF; +					  MASKDWORD) >> 22) & 0x3FF;  		val_x = result[final_candidate][4];  		if ((val_x & 0x00000200) != 0)  			val_x = val_x | 0xFFFFFC00; @@ -2685,7 +2598,7 @@ static void _rtl92d_phy_lc_calibrate_sw(struct ieee80211_hw *hw, bool is2t)  		rf_mode[index] = rtl_read_byte(rtlpriv, offset);  		/* 2. Set RF mode = standby mode */  		rtl_set_rfreg(hw, (enum radio_path)index, RF_AC, -			      BRFREGOFFSETMASK, 0x010000); +			      RFREG_OFFSET_MASK, 0x010000);  		if (rtlpci->init_ready) {  			/* switch CV-curve control by LC-calibration */  			rtl_set_rfreg(hw, (enum radio_path)index, RF_SYN_G7, @@ -2695,16 +2608,16 @@ static void _rtl92d_phy_lc_calibrate_sw(struct ieee80211_hw *hw, bool is2t)  				      0x08000, 0x01);  		}  		u4tmp = rtl_get_rfreg(hw, (enum radio_path)index, RF_SYN_G6, -				  BRFREGOFFSETMASK); +				  RFREG_OFFSET_MASK);  		while ((!(u4tmp & BIT(11))) && timecount <= timeout) {  			mdelay(50);  			timecount += 50;  			u4tmp = rtl_get_rfreg(hw, (enum radio_path)index, -					      RF_SYN_G6, BRFREGOFFSETMASK); +					      RF_SYN_G6, RFREG_OFFSET_MASK);  		}  		RTPRINT(rtlpriv, FINIT, INIT_IQK,  			"PHY_LCK finish delay for %d ms=2\n", timecount); -		u4tmp = rtl_get_rfreg(hw, index, RF_SYN_G4, BRFREGOFFSETMASK); +		u4tmp = rtl_get_rfreg(hw, index, RF_SYN_G4, RFREG_OFFSET_MASK);  		if (index == 0 && rtlhal->interfaceindex == 0) {  			RTPRINT(rtlpriv, FINIT, INIT_IQK,  				"path-A / 5G LCK\n"); @@ -2724,9 +2637,9 @@ static void _rtl92d_phy_lc_calibrate_sw(struct ieee80211_hw *hw, bool is2t)  				      0x7f, i);  			rtl_set_rfreg(hw, (enum radio_path)index, 0x4D, -				BRFREGOFFSETMASK, 0x0); +				RFREG_OFFSET_MASK, 0x0);  			readval = rtl_get_rfreg(hw, (enum radio_path)index, -					  0x4F, BRFREGOFFSETMASK); +					  0x4F, RFREG_OFFSET_MASK);  			curvecount_val[2 * i + 1] = (readval & 0xfffe0) >> 5;  			/* reg 0x4f [4:0] */  			/* reg 0x50 [19:10] */ @@ -2940,7 +2853,7 @@ static bool _rtl92d_phy_sw_chnl_step_by_step(struct ieee80211_hw *hw,  				}  				rtl_set_rfreg(hw, (enum radio_path)rfpath,  					      currentcmd->para1, -					      BRFREGOFFSETMASK, +					      RFREG_OFFSET_MASK,  					      rtlphy->rfreg_chnlval[rfpath]);  				_rtl92d_phy_reload_imr_setting(hw, channel,  							       rfpath); @@ -2988,7 +2901,7 @@ u8 rtl92d_phy_sw_chnl(struct ieee80211_hw *hw)  	if (rtlhal->macphymode == SINGLEMAC_SINGLEPHY &&  	    rtlhal->bandset == BAND_ON_BOTH) {  		ret_value = rtl_get_bbreg(hw, RFPGA0_XAB_RFPARAMETER, -					  BMASKDWORD); +					  MASKDWORD);  		if (rtlphy->current_channel > 14 && !(ret_value & BIT(0)))  			rtl92d_phy_switch_wirelessband(hw, BAND_ON_5G);  		else if (rtlphy->current_channel <= 14 && (ret_value & BIT(0))) @@ -3140,7 +3053,7 @@ static void _rtl92d_phy_set_rfsleep(struct ieee80211_hw *hw)  	/* a.   TXPAUSE 0x522[7:0] = 0xFF  Pause MAC TX queue  */  	rtl_write_byte(rtlpriv, REG_TXPAUSE, 0xFF);  	/* b.   RF path 0 offset 0x00 = 0x00  disable RF  */ -	rtl_set_rfreg(hw, RF90_PATH_A, 0x00, BRFREGOFFSETMASK, 0x00); +	rtl_set_rfreg(hw, RF90_PATH_A, 0x00, RFREG_OFFSET_MASK, 0x00);  	/* c.   APSD_CTRL 0x600[7:0] = 0x40 */  	rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x40);  	/* d. APSD_CTRL 0x600[7:0] = 0x00 @@ -3148,12 +3061,12 @@ static void _rtl92d_phy_set_rfsleep(struct ieee80211_hw *hw)  	 * RF path 0 offset 0x00 = 0x00  	 * APSD_CTRL 0x600[7:0] = 0x40  	 * */ -	u4btmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, BRFREGOFFSETMASK); +	u4btmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, RFREG_OFFSET_MASK);  	while (u4btmp != 0 && delay > 0) {  		rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x0); -		rtl_set_rfreg(hw, RF90_PATH_A, 0x00, BRFREGOFFSETMASK, 0x00); +		rtl_set_rfreg(hw, RF90_PATH_A, 0x00, RFREG_OFFSET_MASK, 0x00);  		rtl_write_byte(rtlpriv, REG_APSD_CTRL, 0x40); -		u4btmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, BRFREGOFFSETMASK); +		u4btmp = rtl_get_rfreg(hw, RF90_PATH_A, 0, RFREG_OFFSET_MASK);  		delay--;  	}  	if (delay == 0) { @@ -3496,9 +3409,9 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  		/* 5G LAN ON */  		rtl_set_bbreg(hw, 0xB30, 0x00F00000, 0xa);  		/* TX BB gain shift*1,Just for testchip,0xc80,0xc88 */ -		rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, BMASKDWORD, +		rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, MASKDWORD,  			      0x40000100); -		rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, BMASKDWORD, +		rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, MASKDWORD,  			      0x40000100);  		if (rtlhal->macphymode == DUALMAC_DUALPHY) {  			rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, @@ -3552,16 +3465,16 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  		rtl_set_bbreg(hw, 0xB30, 0x00F00000, 0x0);  		/* TX BB gain shift,Just for testchip,0xc80,0xc88 */  		if (rtlefuse->internal_pa_5g[0]) -			rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, BMASKDWORD, +			rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, MASKDWORD,  				      0x2d4000b5);  		else -			rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, BMASKDWORD, +			rtl_set_bbreg(hw, ROFDM0_XATxIQIMBALANCE, MASKDWORD,  				      0x20000080);  		if (rtlefuse->internal_pa_5g[1]) -			rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, BMASKDWORD, +			rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, MASKDWORD,  				      0x2d4000b5);  		else -			rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, BMASKDWORD, +			rtl_set_bbreg(hw, ROFDM0_XBTxIQIMBALANCE, MASKDWORD,  				      0x20000080);  		if (rtlhal->macphymode == DUALMAC_DUALPHY) {  			rtl_set_bbreg(hw, RFPGA0_XAB_RFINTERFACESW, @@ -3588,8 +3501,8 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  		}  	}  	/* update IQK related settings */ -	rtl_set_bbreg(hw, ROFDM0_XARXIQIMBALANCE, BMASKDWORD, 0x40000100); -	rtl_set_bbreg(hw, ROFDM0_XBRXIQIMBALANCE, BMASKDWORD, 0x40000100); +	rtl_set_bbreg(hw, ROFDM0_XARXIQIMBALANCE, MASKDWORD, 0x40000100); +	rtl_set_bbreg(hw, ROFDM0_XBRXIQIMBALANCE, MASKDWORD, 0x40000100);  	rtl_set_bbreg(hw, ROFDM0_XCTxAFE, 0xF0000000, 0x00);  	rtl_set_bbreg(hw, ROFDM0_ECCATHRESHOLD, BIT(30) | BIT(28) |  		      BIT(26) | BIT(24), 0x00); @@ -3618,7 +3531,7 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  	/* DMDP */  	if (rtlphy->rf_type == RF_1T1R) {  		/* Use antenna 0,0xc04,0xd04 */ -		rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKBYTE0, 0x11); +		rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKBYTE0, 0x11);  		rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE, BDWORD, 0x1);  		/* enable ad/da clock1 for dual-phy reg0x888 */ @@ -3640,7 +3553,7 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  	} else {  		/* Single PHY */  		/* Use antenna 0 & 1,0xc04,0xd04 */ -		rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, BMASKBYTE0, 0x33); +		rtl_set_bbreg(hw, ROFDM0_TRXPATHENABLE, MASKBYTE0, 0x33);  		rtl_set_bbreg(hw, ROFDM1_TRXPATHENABLE, BDWORD, 0x3);  		/* disable ad/da clock1,0x888 */  		rtl_set_bbreg(hw, RFPGA0_ADDALLOCKEN, BIT(12) | BIT(13), 0); @@ -3648,9 +3561,9 @@ void rtl92d_update_bbrf_configuration(struct ieee80211_hw *hw)  	for (rfpath = RF90_PATH_A; rfpath < rtlphy->num_total_rfpath;  	     rfpath++) {  		rtlphy->rfreg_chnlval[rfpath] = rtl_get_rfreg(hw, rfpath, -						RF_CHNLBW, BRFREGOFFSETMASK); +						RF_CHNLBW, RFREG_OFFSET_MASK);  		rtlphy->reg_rf3c[rfpath] = rtl_get_rfreg(hw, rfpath, 0x3C, -			BRFREGOFFSETMASK); +			RFREG_OFFSET_MASK);  	}  	for (i = 0; i < 2; i++)  		RT_TRACE(rtlpriv, COMP_RF, DBG_LOUD, "RF 0x18 = 0x%x\n", diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.h b/drivers/net/wireless/rtlwifi/rtl8192de/phy.h index f074952bf25..48d5c6835b6 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/phy.h +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.h @@ -39,9 +39,7 @@  #define RT_CANNOT_IO(hw)			false  #define HIGHPOWER_RADIOA_ARRAYLEN		22 -#define IQK_ADDA_REG_NUM			16  #define MAX_TOLERANCE				5 -#define	IQK_DELAY_TIME				1  #define	APK_BB_REG_NUM				5  #define	APK_AFE_REG_NUM				16 @@ -127,34 +125,32 @@ static inline void rtl92d_release_cckandrw_pagea_ctl(struct ieee80211_hw *hw,  			*flag);  } -extern u32 rtl92d_phy_query_bb_reg(struct ieee80211_hw *hw, -				   u32 regaddr, u32 bitmask); -extern void rtl92d_phy_set_bb_reg(struct ieee80211_hw *hw, -				  u32 regaddr, u32 bitmask, u32 data); -extern u32 rtl92d_phy_query_rf_reg(struct ieee80211_hw *hw, -				   enum radio_path rfpath, u32 regaddr, -				   u32 bitmask); -extern void rtl92d_phy_set_rf_reg(struct ieee80211_hw *hw, -				  enum radio_path rfpath, u32 regaddr, -				  u32 bitmask, u32 data); -extern bool rtl92d_phy_mac_config(struct ieee80211_hw *hw); -extern bool rtl92d_phy_bb_config(struct ieee80211_hw *hw); -extern bool rtl92d_phy_rf_config(struct ieee80211_hw *hw); -extern bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw, -						 enum radio_path rfpath); -extern void rtl92d_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw); -extern void rtl92d_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel); -extern void rtl92d_phy_scan_operation_backup(struct ieee80211_hw *hw, -					     u8 operation); -extern void rtl92d_phy_set_bw_mode(struct ieee80211_hw *hw, -				   enum nl80211_channel_type ch_type); -extern u8 rtl92d_phy_sw_chnl(struct ieee80211_hw *hw); +u32 rtl92d_phy_query_bb_reg(struct ieee80211_hw *hw, +			    u32 regaddr, u32 bitmask); +void rtl92d_phy_set_bb_reg(struct ieee80211_hw *hw, +			   u32 regaddr, u32 bitmask, u32 data); +u32 rtl92d_phy_query_rf_reg(struct ieee80211_hw *hw, +			    enum radio_path rfpath, u32 regaddr, +			    u32 bitmask); +void rtl92d_phy_set_rf_reg(struct ieee80211_hw *hw, +			   enum radio_path rfpath, u32 regaddr, +			   u32 bitmask, u32 data); +bool rtl92d_phy_mac_config(struct ieee80211_hw *hw); +bool rtl92d_phy_bb_config(struct ieee80211_hw *hw); +bool rtl92d_phy_rf_config(struct ieee80211_hw *hw); +bool rtl92c_phy_config_rf_with_feaderfile(struct ieee80211_hw *hw, +					  enum radio_path rfpath); +void rtl92d_phy_get_hw_reg_originalvalue(struct ieee80211_hw *hw); +void rtl92d_phy_set_txpower_level(struct ieee80211_hw *hw, u8 channel); +void rtl92d_phy_set_bw_mode(struct ieee80211_hw *hw, +			    enum nl80211_channel_type ch_type); +u8 rtl92d_phy_sw_chnl(struct ieee80211_hw *hw);  bool rtl92d_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,  					  enum rf_content content,  					  enum radio_path rfpath);  bool rtl92d_phy_set_io_cmd(struct ieee80211_hw *hw, enum io_type iotype); -extern bool rtl92d_phy_set_rf_power_state(struct ieee80211_hw *hw, -					  enum rf_pwrstate rfpwr_state); +bool rtl92d_phy_set_rf_power_state(struct ieee80211_hw *hw, +				   enum rf_pwrstate rfpwr_state);  void rtl92d_phy_config_macphymode(struct ieee80211_hw *hw);  void rtl92d_phy_config_macphymode_info(struct ieee80211_hw *hw); @@ -173,6 +169,5 @@ void rtl92d_acquire_cckandrw_pagea_ctl(struct ieee80211_hw *hw,  				       unsigned long *flag);  u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl);  void rtl92d_phy_reload_iqk_setting(struct ieee80211_hw *hw, u8 channel); -void rtl92d_phy_iq_calibrate(struct ieee80211_hw *hw);  #endif diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/reg.h b/drivers/net/wireless/rtlwifi/rtl8192de/reg.h index b7498c5bafc..7f29b8d765b 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/reg.h +++ b/drivers/net/wireless/rtlwifi/rtl8192de/reg.h @@ -1295,18 +1295,4 @@  #define	BWORD1					0xc  #define	BDWORD					0xf -#define	BMASKBYTE0				0xff -#define	BMASKBYTE1				0xff00 -#define	BMASKBYTE2				0xff0000 -#define	BMASKBYTE3				0xff000000 -#define	BMASKHWORD				0xffff0000 -#define	BMASKLWORD				0x0000ffff -#define	BMASKDWORD				0xffffffff -#define	BMASK12BITS				0xfff -#define	BMASKH4BITS				0xf0000000 -#define BMASKOFDM_D				0xffc00000 -#define	BMASKCCK				0x3f3f3f3f - -#define BRFREGOFFSETMASK			0xfffff -  #endif diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/rf.c b/drivers/net/wireless/rtlwifi/rtl8192de/rf.c index 20144e0b414..6a6ac540d5b 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/rf.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/rf.c @@ -125,7 +125,7 @@ void rtl92d_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,  	}  	tmpval = tx_agc[RF90_PATH_A] & 0xff; -	rtl_set_bbreg(hw, RTXAGC_A_CCK1_MCS32, BMASKBYTE1, tmpval); +	rtl_set_bbreg(hw, RTXAGC_A_CCK1_MCS32, MASKBYTE1, tmpval);  	RTPRINT(rtlpriv, FPHY, PHY_TXPWR,  		"CCK PWR 1M (rf-A) = 0x%x (reg 0x%x)\n",  		tmpval, RTXAGC_A_CCK1_MCS32); @@ -135,7 +135,7 @@ void rtl92d_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,  		"CCK PWR 2~11M (rf-A) = 0x%x (reg 0x%x)\n",  		tmpval, RTXAGC_B_CCK11_A_CCK2_11);  	tmpval = tx_agc[RF90_PATH_B] >> 24; -	rtl_set_bbreg(hw, RTXAGC_B_CCK11_A_CCK2_11, BMASKBYTE0, tmpval); +	rtl_set_bbreg(hw, RTXAGC_B_CCK11_A_CCK2_11, MASKBYTE0, tmpval);  	RTPRINT(rtlpriv, FPHY, PHY_TXPWR,  		"CCK PWR 11M (rf-B) = 0x%x (reg 0x%x)\n",  		tmpval, RTXAGC_B_CCK11_A_CCK2_11); @@ -360,7 +360,7 @@ static void _rtl92d_write_ofdm_power_reg(struct ieee80211_hw *hw,  			regoffset = regoffset_a[index];  		else  			regoffset = regoffset_b[index]; -		rtl_set_bbreg(hw, regoffset, BMASKDWORD, writeval); +		rtl_set_bbreg(hw, regoffset, MASKDWORD, writeval);  		RTPRINT(rtlpriv, FPHY, PHY_TXPWR,  			"Set 0x%x = %08x\n", regoffset, writeval);  		if (((get_rf_type(rtlphy) == RF_2T2R) && diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/rf.h b/drivers/net/wireless/rtlwifi/rtl8192de/rf.h index 0fe1a48593e..7303d12c266 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/rf.h +++ b/drivers/net/wireless/rtlwifi/rtl8192de/rf.h @@ -30,15 +30,13 @@  #ifndef __RTL92D_RF_H__  #define __RTL92D_RF_H__ -extern void rtl92d_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, -					    u8 bandwidth); -extern void rtl92d_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw, -					      u8 *ppowerlevel); -extern void rtl92d_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw, -					       u8 *ppowerlevel, u8 channel); -extern bool rtl92d_phy_rf6052_config(struct ieee80211_hw *hw); -extern bool rtl92d_phy_enable_anotherphy(struct ieee80211_hw *hw, bool bmac0); -extern void rtl92d_phy_powerdown_anotherphy(struct ieee80211_hw *hw, -					    bool bmac0); +void rtl92d_phy_rf6052_set_bandwidth(struct ieee80211_hw *hw, u8 bandwidth); +void rtl92d_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw, +				       u8 *ppowerlevel); +void rtl92d_phy_rf6052_set_ofdm_txpower(struct ieee80211_hw *hw, +					u8 *ppowerlevel, u8 channel); +bool rtl92d_phy_rf6052_config(struct ieee80211_hw *hw); +bool rtl92d_phy_enable_anotherphy(struct ieee80211_hw *hw, bool bmac0); +void rtl92d_phy_powerdown_anotherphy(struct ieee80211_hw *hw, bool bmac0);  #endif diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/sw.c b/drivers/net/wireless/rtlwifi/rtl8192de/sw.c index c18c04bf0c1..edab5a5351b 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/sw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/sw.c @@ -30,6 +30,7 @@  #include "../wifi.h"  #include "../core.h"  #include "../pci.h" +#include "../base.h"  #include "reg.h"  #include "def.h"  #include "phy.h" @@ -236,7 +237,7 @@ static struct rtl_hal_ops rtl8192de_hal_ops = {  	.set_bw_mode = rtl92d_phy_set_bw_mode,  	.switch_channel = rtl92d_phy_sw_chnl,  	.dm_watchdog = rtl92d_dm_watchdog, -	.scan_operation_backup = rtl92d_phy_scan_operation_backup, +	.scan_operation_backup = rtl_phy_scan_operation_backup,  	.set_rf_power_state = rtl92d_phy_set_rf_power_state,  	.led_control = rtl92de_led_control,  	.set_desc = rtl92de_set_desc, diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c index b8ec718a0fa..99c2ab5dfce 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/trx.c @@ -525,8 +525,7 @@ bool rtl92de_rx_query_desc(struct ieee80211_hw *hw,	struct rtl_stats *stats,  						   p_drvinfo);  	}  	/*rx_status->qual = stats->signal; */ -	rx_status->signal = stats->rssi + 10; -	/*rx_status->noise = -stats->noise; */ +	rx_status->signal = stats->recvsignalpower + 10;  	return true;  } @@ -546,7 +545,7 @@ static void _rtl92de_insert_emcontent(struct rtl_tcb_desc *ptcb_desc,  void rtl92de_tx_fill_desc(struct ieee80211_hw *hw,  			  struct ieee80211_hdr *hdr, u8 *pdesc_tx, -			  struct ieee80211_tx_info *info, +			  u8 *pbd_desc_tx, struct ieee80211_tx_info *info,  			  struct ieee80211_sta *sta,  			  struct sk_buff *skb,  			  u8 hw_queue, struct rtl_tcb_desc *ptcb_desc) @@ -787,7 +786,8 @@ void rtl92de_tx_fill_cmddesc(struct ieee80211_hw *hw,  	SET_TX_DESC_OWN(pdesc, 1);  } -void rtl92de_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val) +void rtl92de_set_desc(struct ieee80211_hw *hw, u8 *pdesc, bool istx, +		      u8 desc_name, u8 *val)  {  	if (istx) {  		switch (desc_name) { diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/trx.h b/drivers/net/wireless/rtlwifi/rtl8192de/trx.h index c1b5dfb79d5..fb5cf0634e8 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/trx.h +++ b/drivers/net/wireless/rtlwifi/rtl8192de/trx.h @@ -728,8 +728,8 @@ struct rx_desc_92d {  } __packed;  void rtl92de_tx_fill_desc(struct ieee80211_hw *hw, -			  struct ieee80211_hdr *hdr, -			  u8 *pdesc, struct ieee80211_tx_info *info, +			  struct ieee80211_hdr *hdr, u8 *pdesc, +			  u8 *pbd_desc_tx, struct ieee80211_tx_info *info,  			  struct ieee80211_sta *sta,  			  struct sk_buff *skb, u8 hw_queue,  			  struct rtl_tcb_desc *ptcb_desc); @@ -737,7 +737,8 @@ bool rtl92de_rx_query_desc(struct ieee80211_hw *hw,  			   struct rtl_stats *stats,  			   struct ieee80211_rx_status *rx_status,  			   u8 *pdesc, struct sk_buff *skb); -void rtl92de_set_desc(u8 *pdesc, bool istx, u8 desc_name, u8 *val); +void rtl92de_set_desc(struct ieee80211_hw *hw, u8 *pdesc, bool istx, +		      u8 desc_name, u8 *val);  u32 rtl92de_get_desc(u8 *pdesc, bool istx, u8 desc_name);  void rtl92de_tx_polling(struct ieee80211_hw *hw, u8 hw_queue);  void rtl92de_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc,  | 
