diff options
Diffstat (limited to 'drivers/gpu/drm/savage')
| -rw-r--r-- | drivers/gpu/drm/savage/savage_bci.c | 12 | ||||
| -rw-r--r-- | drivers/gpu/drm/savage/savage_state.c | 8 | 
2 files changed, 10 insertions, 10 deletions
diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c index b17d0710871..c97cdc9ab23 100644 --- a/drivers/gpu/drm/savage/savage_bci.c +++ b/drivers/gpu/drm/savage/savage_bci.c @@ -49,7 +49,7 @@ savage_bci_wait_fifo_shadow(drm_savage_private_t * dev_priv, unsigned int n)  #endif  	for (i = 0; i < SAVAGE_DEFAULT_USEC_TIMEOUT; i++) { -		DRM_MEMORYBARRIER(); +		mb();  		status = dev_priv->status_ptr[0];  		if ((status & mask) < threshold)  			return 0; @@ -123,7 +123,7 @@ savage_bci_wait_event_shadow(drm_savage_private_t * dev_priv, uint16_t e)  	int i;  	for (i = 0; i < SAVAGE_EVENT_USEC_TIMEOUT; i++) { -		DRM_MEMORYBARRIER(); +		mb();  		status = dev_priv->status_ptr[1];  		if ((((status & 0xffff) - e) & 0xffff) <= 0x7fff ||  		    (status & 0xffff) == 0) @@ -449,7 +449,7 @@ static void savage_dma_flush(drm_savage_private_t * dev_priv)  		}  	} -	DRM_MEMORYBARRIER(); +	mb();  	/* do flush ... */  	phys_addr = dev_priv->cmd_dma->offset + @@ -990,10 +990,10 @@ static int savage_bci_get_buffers(struct drm_device *dev,  		buf->file_priv = file_priv; -		if (DRM_COPY_TO_USER(&d->request_indices[i], +		if (copy_to_user(&d->request_indices[i],  				     &buf->idx, sizeof(buf->idx)))  			return -EFAULT; -		if (DRM_COPY_TO_USER(&d->request_sizes[i], +		if (copy_to_user(&d->request_sizes[i],  				     &buf->total, sizeof(buf->total)))  			return -EFAULT; @@ -1079,4 +1079,4 @@ const struct drm_ioctl_desc savage_ioctls[] = {  	DRM_IOCTL_DEF_DRV(SAVAGE_BCI_EVENT_WAIT, savage_bci_event_wait, DRM_AUTH),  }; -int savage_max_ioctl = DRM_ARRAY_SIZE(savage_ioctls); +int savage_max_ioctl = ARRAY_SIZE(savage_ioctls); diff --git a/drivers/gpu/drm/savage/savage_state.c b/drivers/gpu/drm/savage/savage_state.c index b35e75ed890..c01ad0aeaa5 100644 --- a/drivers/gpu/drm/savage/savage_state.c +++ b/drivers/gpu/drm/savage/savage_state.c @@ -992,7 +992,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_  		if (kcmd_addr == NULL)  			return -ENOMEM; -		if (DRM_COPY_FROM_USER(kcmd_addr, cmdbuf->cmd_addr, +		if (copy_from_user(kcmd_addr, cmdbuf->cmd_addr,  				       cmdbuf->size * 8))  		{  			kfree(kcmd_addr); @@ -1007,7 +1007,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_  			goto done;  		} -		if (DRM_COPY_FROM_USER(kvb_addr, cmdbuf->vb_addr, +		if (copy_from_user(kvb_addr, cmdbuf->vb_addr,  				       cmdbuf->vb_size)) {  			ret = -EFAULT;  			goto done; @@ -1022,7 +1022,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_  			goto done;  		} -		if (DRM_COPY_FROM_USER(kbox_addr, cmdbuf->box_addr, +		if (copy_from_user(kbox_addr, cmdbuf->box_addr,  				       cmdbuf->nbox * sizeof(struct drm_clip_rect))) {  			ret = -EFAULT;  			goto done; @@ -1032,7 +1032,7 @@ int savage_bci_cmdbuf(struct drm_device *dev, void *data, struct drm_file *file_  	/* Make sure writes to DMA buffers are finished before sending  	 * DMA commands to the graphics hardware. */ -	DRM_MEMORYBARRIER(); +	mb();  	/* Coming from user space. Don't know if the Xserver has  	 * emitted wait commands. Assuming the worst. */  | 
