diff options
Diffstat (limited to 'arch/um/kernel')
| -rw-r--r-- | arch/um/kernel/exitcode.c | 4 | ||||
| -rw-r--r-- | arch/um/kernel/mem.c | 8 | ||||
| -rw-r--r-- | arch/um/kernel/physmem.c | 1 | ||||
| -rw-r--r-- | arch/um/kernel/process.c | 17 | ||||
| -rw-r--r-- | arch/um/kernel/sysrq.c | 102 | ||||
| -rw-r--r-- | arch/um/kernel/tlb.c | 9 | ||||
| -rw-r--r-- | arch/um/kernel/trap.c | 14 | ||||
| -rw-r--r-- | arch/um/kernel/um_arch.c | 2 | 
8 files changed, 100 insertions, 57 deletions
diff --git a/arch/um/kernel/exitcode.c b/arch/um/kernel/exitcode.c index 829df49dee9..41ebbfebb33 100644 --- a/arch/um/kernel/exitcode.c +++ b/arch/um/kernel/exitcode.c @@ -40,9 +40,11 @@ static ssize_t exitcode_proc_write(struct file *file,  		const char __user *buffer, size_t count, loff_t *pos)  {  	char *end, buf[sizeof("nnnnn\0")]; +	size_t size;  	int tmp; -	if (copy_from_user(buf, buffer, count)) +	size = min(count, sizeof(buf)); +	if (copy_from_user(buf, buffer, size))  		return -EFAULT;  	tmp = simple_strtol(buf, &end, 0); diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c index 7ddb64baf32..8636e905426 100644 --- a/arch/um/kernel/mem.c +++ b/arch/um/kernel/mem.c @@ -279,8 +279,12 @@ pgtable_t pte_alloc_one(struct mm_struct *mm, unsigned long address)  	struct page *pte;  	pte = alloc_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO); -	if (pte) -		pgtable_page_ctor(pte); +	if (!pte) +		return NULL; +	if (!pgtable_page_ctor(pte)) { +		__free_page(pte); +		return NULL; +	}  	return pte;  } diff --git a/arch/um/kernel/physmem.c b/arch/um/kernel/physmem.c index f116db15d40..30fdd5d0067 100644 --- a/arch/um/kernel/physmem.c +++ b/arch/um/kernel/physmem.c @@ -103,6 +103,7 @@ void __init setup_physmem(unsigned long start, unsigned long reserve_end,  	 */  	os_seek_file(physmem_fd, __pa(&__syscall_stub_start));  	os_write_file(physmem_fd, &__syscall_stub_start, PAGE_SIZE); +	os_fsync_file(physmem_fd);  	bootmap_size = init_bootmem(pfn, pfn + delta);  	free_bootmem(__pa(reserve_end) + bootmap_size, diff --git a/arch/um/kernel/process.c b/arch/um/kernel/process.c index bbcef522bcb..f17bca8ed2c 100644 --- a/arch/um/kernel/process.c +++ b/arch/um/kernel/process.c @@ -82,19 +82,8 @@ void *__switch_to(struct task_struct *from, struct task_struct *to)  	to->thread.prev_sched = from;  	set_current(to); -	do { -		current->thread.saved_task = NULL; - -		switch_threads(&from->thread.switch_buf, -			       &to->thread.switch_buf); - -		arch_switch_to(current); - -		if (current->thread.saved_task) -			show_regs(&(current->thread.regs)); -		to = current->thread.saved_task; -		from = current; -	} while (current->thread.saved_task); +	switch_threads(&from->thread.switch_buf, &to->thread.switch_buf); +	arch_switch_to(current);  	return current->thread.prev_sched;  } @@ -370,7 +359,7 @@ int singlestepping(void * t)  /*   * Only x86 and x86_64 have an arch_align_stack().   * All other arches have "#define arch_align_stack(x) (x)" - * in their asm/system.h + * in their asm/exec.h   * As this is included in UML from asm-um/system-generic.h,   * we can use it to behave as the subarch does.   */ diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c index 0dc4d1c6f98..799d7e413bf 100644 --- a/arch/um/kernel/sysrq.c +++ b/arch/um/kernel/sysrq.c @@ -1,6 +1,10 @@  /*   * Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) - * Licensed under the GPL + * Copyright (C) 2013 Richard Weinberger <richrd@nod.at> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation.   */  #include <linux/kallsyms.h> @@ -8,59 +12,87 @@  #include <linux/module.h>  #include <linux/sched.h>  #include <asm/sysrq.h> +#include <os.h> -/* Catch non-i386 SUBARCH's. */ -#if !defined(CONFIG_UML_X86) || defined(CONFIG_64BIT) -void show_trace(struct task_struct *task, unsigned long * stack) +struct stack_frame { +	struct stack_frame *next_frame; +	unsigned long return_address; +}; + +static void do_stack_trace(unsigned long *sp, unsigned long bp)  { +	int reliable;  	unsigned long addr; +	struct stack_frame *frame = (struct stack_frame *)bp; -	if (!stack) { -		stack = (unsigned long*) &stack; -		WARN_ON(1); -	} - -	printk(KERN_INFO "Call Trace: \n"); -	while (((long) stack & (THREAD_SIZE-1)) != 0) { -		addr = *stack; +	printk(KERN_INFO "Call Trace:\n"); +	while (((long) sp & (THREAD_SIZE-1)) != 0) { +		addr = *sp;  		if (__kernel_text_address(addr)) { -			printk(KERN_INFO "%08lx:  [<%08lx>]", -			       (unsigned long) stack, addr); -			print_symbol(KERN_CONT " %s", addr); +			reliable = 0; +			if ((unsigned long) sp == bp + sizeof(long)) { +				frame = frame ? frame->next_frame : NULL; +				bp = (unsigned long)frame; +				reliable = 1; +			} + +			printk(KERN_INFO " [<%08lx>]", addr); +			printk(KERN_CONT " %s", reliable ? "" : "? "); +			print_symbol(KERN_CONT "%s", addr);  			printk(KERN_CONT "\n");  		} -		stack++; +		sp++;  	}  	printk(KERN_INFO "\n");  } -#endif -/*Stolen from arch/i386/kernel/traps.c */ -static const int kstack_depth_to_print = 24; +static unsigned long get_frame_pointer(struct task_struct *task, +				       struct pt_regs *segv_regs) +{ +	if (!task || task == current) +		return segv_regs ? PT_REGS_BP(segv_regs) : current_bp(); +	else +		return KSTK_EBP(task); +} -/* This recently started being used in arch-independent code too, as in - * kernel/sched/core.c.*/ -void show_stack(struct task_struct *task, unsigned long *esp) +static unsigned long *get_stack_pointer(struct task_struct *task, +					struct pt_regs *segv_regs)  { -	unsigned long *stack; +	if (!task || task == current) +		return segv_regs ? (unsigned long *)PT_REGS_SP(segv_regs) : current_sp(); +	else +		return (unsigned long *)KSTK_ESP(task); +} + +void show_stack(struct task_struct *task, unsigned long *stack) +{ +	unsigned long *sp = stack, bp = 0; +	struct pt_regs *segv_regs = current->thread.segv_regs;  	int i; -	if (esp == NULL) { -		if (task != current && task != NULL) { -			esp = (unsigned long *) KSTK_ESP(task); -		} else { -			esp = (unsigned long *) &esp; -		} +	if (!segv_regs && os_is_signal_stack()) { +		printk(KERN_ERR "Received SIGSEGV in SIGSEGV handler," +				" aborting stack trace!\n"); +		return;  	} -	stack = esp; -	for (i = 0; i < kstack_depth_to_print; i++) { +#ifdef CONFIG_FRAME_POINTER +	bp = get_frame_pointer(task, segv_regs); +#endif + +	if (!stack) +		sp = get_stack_pointer(task, segv_regs); + +	printk(KERN_INFO "Stack:\n"); +	stack = sp; +	for (i = 0; i < 3 * STACKSLOTS_PER_LINE; i++) {  		if (kstack_end(stack))  			break; -		if (i && ((i % 8) == 0)) -			printk(KERN_INFO "       "); -		printk(KERN_CONT "%08lx ", *stack++); +		if (i && ((i % STACKSLOTS_PER_LINE) == 0)) +			printk(KERN_CONT "\n"); +		printk(KERN_CONT " %08lx", *stack++);  	} +	printk(KERN_CONT "\n"); -	show_trace(task, esp); +	do_stack_trace(sp, bp);  } diff --git a/arch/um/kernel/tlb.c b/arch/um/kernel/tlb.c index 9472079471b..f1b3eb14b85 100644 --- a/arch/um/kernel/tlb.c +++ b/arch/um/kernel/tlb.c @@ -12,6 +12,7 @@  #include <mem_user.h>  #include <os.h>  #include <skas.h> +#include <kern_util.h>  struct host_vm_change {  	struct host_vm_op { @@ -124,6 +125,9 @@ static int add_munmap(unsigned long addr, unsigned long len,  	struct host_vm_op *last;  	int ret = 0; +	if ((addr >= STUB_START) && (addr < STUB_END)) +		return -EINVAL; +  	if (hvc->index != 0) {  		last = &hvc->ops[hvc->index - 1];  		if ((last->type == MUNMAP) && @@ -283,8 +287,11 @@ void fix_range_common(struct mm_struct *mm, unsigned long start_addr,  	/* This is not an else because ret is modified above */  	if (ret) {  		printk(KERN_ERR "fix_range_common: failed, killing current " -		       "process\n"); +		       "process: %d\n", task_tgid_vnr(current)); +		/* We are under mmap_sem, release it such that current can terminate */ +		up_write(¤t->mm->mmap_sem);  		force_sig(SIGKILL, current); +		do_signal();  	}  } diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c index 5c3aef74237..5678c3571e7 100644 --- a/arch/um/kernel/trap.c +++ b/arch/um/kernel/trap.c @@ -206,9 +206,12 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,  	int is_write = FAULT_WRITE(fi);  	unsigned long address = FAULT_ADDRESS(fi); +	if (!is_user && regs) +		current->thread.segv_regs = container_of(regs, struct pt_regs, regs); +  	if (!is_user && (address >= start_vm) && (address < end_vm)) {  		flush_tlb_kernel_vm(); -		return 0; +		goto out;  	}  	else if (current->mm == NULL) {  		show_regs(container_of(regs, struct pt_regs, regs)); @@ -230,7 +233,7 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,  	catcher = current->thread.fault_catcher;  	if (!err) -		return 0; +		goto out;  	else if (catcher != NULL) {  		current->thread.fault_addr = (void *) address;  		UML_LONGJMP(catcher, 1); @@ -238,7 +241,7 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,  	else if (current->thread.fault_addr != NULL)  		panic("fault_addr set but no fault catcher");  	else if (!is_user && arch_fixup(ip, regs)) -		return 0; +		goto out;  	if (!is_user) {  		show_regs(container_of(regs, struct pt_regs, regs)); @@ -262,6 +265,11 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,  		current->thread.arch.faultinfo = fi;  		force_sig_info(SIGSEGV, &si, current);  	} + +out: +	if (regs) +		current->thread.segv_regs = NULL; +  	return 0;  } diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c index 87df5e3acc2..016adf0985d 100644 --- a/arch/um/kernel/um_arch.c +++ b/arch/um/kernel/um_arch.c @@ -13,6 +13,7 @@  #include <linux/sched.h>  #include <asm/pgtable.h>  #include <asm/processor.h> +#include <asm/sections.h>  #include <asm/setup.h>  #include <as-layout.h>  #include <arch.h> @@ -234,7 +235,6 @@ static int panic_exit(struct notifier_block *self, unsigned long unused1,  		      void *unused2)  {  	bust_spinlocks(1); -	show_regs(&(current->thread.regs));  	bust_spinlocks(0);  	uml_exitcode = 1;  	os_dump_core();  | 
