diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-10-07 12:59:29 -0700 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-04-17 16:15:55 -0400 |
| commit | 9b8796a9ce81ddc365946858d85a7656e66b0e59 (patch) | |
| tree | e1d6cd8afd55c4e7ef4e4f8e40ba611ba58adc28 /kernel | |
| parent | ba6929c72ac7d900504d9c355b2e84fe27533198 (diff) | |
sysctl: fix min/max handling in __do_proc_doulongvec_minmax()
commit 27b3d80a7b6adcf069b5e869e4efcc3a79f88a91 upstream.
When proc_doulongvec_minmax() is used with an array of longs, and no
min/max check requested (.extra1 or .extra2 being NULL), we dereference a
NULL pointer for the second element of the array.
Noticed while doing some changes in network stack for the "16TB problem"
Fix is to not change min & max pointers in __do_proc_doulongvec_minmax(),
so that all elements of the vector share an unique min/max limit, like
proc_dointvec_minmax().
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Americo Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 8686b0f5fc1..d2cededc2bd 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -2314,7 +2314,7 @@ static int __do_proc_doulongvec_minmax(void *data, struct ctl_table *table, int vleft = table->maxlen / sizeof(unsigned long); left = *lenp; - for (; left && vleft--; i++, min++, max++, first=0) { + for (; left && vleft--; i++, first = 0) { if (write) { while (left) { char c; |