diff options
| author | Denys Vlasenko <vda.linux@googlemail.com> | 2012-09-26 11:34:50 +1000 |
|---|---|---|
| committer | Willy Tarreau <w@1wt.eu> | 2013-06-10 11:42:23 +0200 |
| commit | 8b7435d260ce2dce26751e5477c339eb02ad07e7 (patch) | |
| tree | a5671edb33e1e1ca6408eed5a16ecff6cfce7928 /kernel/sys.c | |
| parent | 16365e5badcb314f350c47d4a9be90ed8a61b71a (diff) | |
coredump: prevent double-free on an error path in core dumper
commit f34f9d186df35e5c39163444c43b4fc6255e39c5 upstream.
In !CORE_DUMP_USE_REGSET case, if elf_note_info_init fails to allocate
memory for info->fields, it frees already allocated stuff and returns
error to its caller, fill_note_info. Which in turn returns error to its
caller, elf_core_dump. Which jumps to cleanup label and calls
free_note_info, which will happily try to free all info->fields again.
BOOM.
This is the fix.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Diffstat (limited to 'kernel/sys.c')
0 files changed, 0 insertions, 0 deletions