diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2008-02-23 15:23:27 -0800 |
|---|---|---|
| committer | Chris Wright <chrisw@sous-sol.org> | 2008-03-24 11:47:13 -0700 |
| commit | 759be208409db44bdc81bd28156c38e4f9501ecd (patch) | |
| tree | a928417d7383000a5616134a62a83397d5872b8d /drivers/usb/storage/protocol.c | |
| parent | 7c0f76561fdc0a24ebfae4ee4112d62473eb3bdc (diff) | |
fuse: fix permission checking
[upstream commit 1a823ac9ff09cbdf39201df37b7ede1f9395de83]
I added a nasty local variable shadowing bug to fuse in 2.6.24, with the
result, that the 'default_permissions' mount option is basically ignored.
How did this happen?
- old err declaration in inner scope
- new err getting declared in outer scope
- 'return err' from inner scope getting removed
- old declaration not being noticed
-Wshadow would have saved us, but it doesn't seem practical for
the kernel :(
More testing would have also saved us :((
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage/protocol.c')
0 files changed, 0 insertions, 0 deletions