diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-27 16:30:03 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-28 01:57:18 -0700 |
| commit | 17d95640034c4e0f12e5f1c9d1097d8dba6484ea (patch) | |
| tree | f92fa3410410b827405c4b259f8353b6e696b869 /drivers/net/3c507.c | |
| parent | 89dc0be68f4aaa06dba1b5d6ea9ecfe8fa9b7bf0 (diff) | |
drivers/net: Eliminate a NULL pointer dereference
At the point of the print, dev is NULL.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@
if ((E == NULL && ...) || ...)
{
... when != if (...) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/3c507.c')
| -rw-r--r-- | drivers/net/3c507.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/3c507.c b/drivers/net/3c507.c index 82eaf65d2d8..ea9b7a098c9 100644 --- a/drivers/net/3c507.c +++ b/drivers/net/3c507.c @@ -551,8 +551,7 @@ static irqreturn_t el16_interrupt(int irq, void *dev_id) void __iomem *shmem; if (dev == NULL) { - pr_err("%s: net_interrupt(): irq %d for unknown device.\n", - dev->name, irq); + pr_err("net_interrupt(): irq %d for unknown device.\n", irq); return IRQ_NONE; } |