diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-07-01 22:01:04 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2013-07-04 10:01:12 +1000 |
| commit | e5ad449be684492f4f58dc169f20926670da7cae (patch) | |
| tree | 2d62da579b6ba7f7b9cbf32129591db46700fd22 | |
| parent | 2c54b133576fefaa54a0ab939a94af348ec54499 (diff) | |
drm/mm: WARN for unclean mm takedown
The usual drm driver has tons of different drm_mm memory managers so the drm
error message in dmesg is pretty useless. WARN instead so that we have the full
backtrace.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Dave Airlie <airlied@redhat.com>
| -rw-r--r-- | drivers/gpu/drm/drm_mm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index e05c3cea322..543b9b3171d 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm/drm_mm.c @@ -697,8 +697,8 @@ void drm_mm_takedown(struct drm_mm * mm) { struct drm_mm_node *entry, *next; - if (!list_empty(&mm->head_node.node_list)) { - DRM_ERROR("Memory manager not clean. Delaying takedown\n"); + if (WARN(!list_empty(&mm->head_node.node_list), + "Memory manager not clean. Delaying takedown\n")) { return; } |