aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBill Pemberton <wfp5p@virginia.edu>2010-05-03 17:50:45 -0400
committerGreg Kroah-Hartman <gregkh@suse.de>2010-05-11 11:36:04 -0700
commit8566ea7c6f9660623a6f04bc73431f761dee32c7 (patch)
tree2b20227082b225b0f9f021e4823dcace4082ce56
parent9e629075ac694ab4d4971d4e62dfb749118bce70 (diff)
Staging: hv: move ASSERT(scmnd) to a more useful location
There's not much point to make sure scmnd is not NULL after an assert that would dereference scmnd. The ASSERT()'s should be removed, but until they are at least they at least can be in the right order. Signed-off-by: Bill Pemberton <wfp5p@virginia.edu> Cc: Hank Janssen <hjanssen@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/staging/hv/storvsc_drv.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 5e28e4c3643..26b35a6c679 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -386,9 +386,9 @@ static void storvsc_commmand_completion(struct hv_storvsc_request *request)
struct scsi_sense_hdr sense_hdr;
ASSERT(request == &cmd_request->request);
+ ASSERT(scmnd);
ASSERT((unsigned long)scmnd->host_scribble ==
(unsigned long)cmd_request);
- ASSERT(scmnd);
ASSERT(scmnd->scsi_done);
DPRINT_ENTER(STORVSC_DRV);