aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSalva Peiró <speiro@ai2.upv.es>2013-10-11 12:50:03 +0300
committerBen Hutchings <ben@decadent.org.uk>2013-11-28 14:01:57 +0000
commit5bf019ebfa38379d51698b7f0fefcd44d6f0447d (patch)
tree1299d158869abcb8bf6ec38752c4d662efd746f3
parentd9aab1cfdd30ff43df1e45f9430c30d99c2c6e47 (diff)
farsync: fix info leak in ioctl
[ Upstream commit 96b340406724d87e4621284ebac5e059d67b2194 ] The fst_get_iface() code fails to initialize the two padding bytes of struct sync_serial_settings after the ->loopback member. Add an explicit memset(0) before filling the structure to avoid the info leak. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r--drivers/net/wan/farsync.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
index ebb9f24eefb..7a4c4914503 100644
--- a/drivers/net/wan/farsync.c
+++ b/drivers/net/wan/farsync.c
@@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card, struct fst_port_info *port,
}
i = port->index;
+ memset(&sync, 0, sizeof(sync));
sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);
/* Lucky card and linux use same encoding here */
sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==