diff options
| author | Joe Jin <joe.jin@oracle.com> | 2010-12-06 03:00:59 +0000 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-04-17 16:16:03 -0400 |
| commit | 4beaa7e56f75121da2acd9bbc3b9b115db0323d5 (patch) | |
| tree | b8d0a2f7391770e3a1e7522f3b0b9153593688e9 | |
| parent | 9812927a368cf5e7be0d060405ad45a17922db05 (diff) | |
driver/net/benet: fix be_cmd_multicast_set() memcpy bug
commit 408cc293c29ada769ae772420a39961320da1854 upstream
Regarding benet be_cmd_multicast_set() function, now using
netdev_for_each_mc_addr() helper for mac address copy, but
when copying to req->mac[] did not increase of the index.
Cc: Sathya Perla <sathyap@serverengines.com>
Cc: Subbu Seetharaman <subbus@serverengines.com>
Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Cc: Ajit Khaparde <ajitk@serverengines.com>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
| -rw-r--r-- | drivers/net/benet/be_cmds.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index d0ef4ac987c..e0578d192da 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1163,7 +1163,7 @@ int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id, i = 0; netdev_for_each_mc_addr(mc, netdev) - memcpy(req->mac[i].byte, mc->dmi_addr, ETH_ALEN); + memcpy(req->mac[i++].byte, mc->dmi_addr, ETH_ALEN); } else { req->promiscuous = 1; } |