aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Gates <matthew.gates@hp.com>2013-12-04 17:10:36 -0600
committerJames Bottomley <JBottomley@Parallels.com>2013-12-19 20:56:30 -0800
commit3ce438df106826edde7ad724f3819716a3f0cf56 (patch)
tree3cfd390bb4d67907f0d9f1c4ed145beb3d19eb0c
parent0ddf1d77505fd97daa7fc70bb0498c54a5c33725 (diff)
[SCSI] hpsa: allow SCSI mid layer to handle unit attention
We were clobbering the SCSI status and setting cmd->result = DID_SOFT_ERROR << 16; to get a retry, but better to let the mid layer handle the unit attention. Signed-off-by: Matt Gates <matthew.gates@hp.com> Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r--drivers/scsi/hpsa.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index d5f2ff9918f..868318a7067 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -1241,10 +1241,8 @@ static void complete_scsi_command(struct CommandList *cp)
}
if (ei->ScsiStatus == SAM_STAT_CHECK_CONDITION) {
- if (check_for_unit_attention(h, cp)) {
- cmd->result = DID_SOFT_ERROR << 16;
+ if (check_for_unit_attention(h, cp))
break;
- }
if (sense_key == ILLEGAL_REQUEST) {
/*
* SCSI REPORT_LUNS is commonly unsupported on