diff options
| author | David S. Miller <davem@davemloft.net> | 2010-11-10 21:35:37 -0800 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2011-04-17 16:16:02 -0400 |
| commit | 1315b700e593535a1a5ede8ea77859a155c0a3b2 (patch) | |
| tree | 51e9d9860efb9c2231f5cbe5cdf492ec606c3b62 | |
| parent | 7be07193f5663cd1a4657062c47c07282fbc3f3b (diff) | |
tcp: Increase TCP_MAXSEG socket option minimum.
commit 7a1abd08d52fdeddb3e9a5a33f2f15cc6a5674d2 upstream
As noted by Steve Chen, since commit
f5fff5dc8a7a3f395b0525c02ba92c95d42b7390 ("tcp: advertise MSS
requested by user") we can end up with a situation where
tcp_select_initial_window() does a divide by a zero (or
even negative) mss value.
The problem is that sometimes we effectively subtract
TCPOLEN_TSTAMP_ALIGNED and/or TCPOLEN_MD5SIG_ALIGNED from the mss.
Fix this by increasing the minimum from 8 to 64.
Reported-by: Steve Chen <schen@mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 68cd2995429..5ad716bd06d 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2234,7 +2234,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level, /* Values greater than interface MTU won't take effect. However * at the point when this call is done we typically don't yet * know which interface is going to be used */ - if (val < 8 || val > MAX_TCP_WINDOW) { + if (val < 64 || val > MAX_TCP_WINDOW) { err = -EINVAL; break; } |