diff options
author | Mathias Krause <minipli@googlemail.com> | 2012-08-15 11:31:44 +0000 |
---|---|---|
committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-10 16:10:49 -0500 |
commit | 105253a4736e72ea28cffdd7143f204837b1a2e6 (patch) | |
tree | 8b97b364a46dd70469d4bc5b4a86bba6407d45f8 | |
parent | c327aec64e7ddd03b70e357331de5350ed2fe220 (diff) |
atm: fix info leak in getsockopt(SO_ATMPVC)
commit e862f1a9b7df4e8196ebec45ac62295138aa3fc2 upstream.
The ATM code fails to initialize the two padding bytes of struct
sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
before filling the structure to avoid the info leak.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r-- | net/atm/common.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/atm/common.c b/net/atm/common.c index 97ed94aa0cb..ec2cb8f3c8d 100644 --- a/net/atm/common.c +++ b/net/atm/common.c @@ -759,6 +759,7 @@ int vcc_getsockopt(struct socket *sock, int level, int optname, if (!vcc->dev || !test_bit(ATM_VF_ADDR, &vcc->flags)) return -ENOTCONN; + memset(&pvc, 0, sizeof(pvc)); pvc.sap_family = AF_ATMPVC; pvc.sap_addr.itf = vcc->dev->number; pvc.sap_addr.vpi = vcc->vpi; |