Age | Commit message (Collapse) | Author |
|
|
|
with some added fixes for strict compiler checks
|
|
|
|
|
|
In order to get advantage of the fix in the previous commit.
Fixes: NB#174382 (Only filtered contacts are picked from contact list)
|
|
This is because calls to hildon_live_search_set_text() followed by a
retrieval of the selection will then break, and at least addressbook
assumes that this will happen synchronously.
Since we only want to give better responsiveness in the case when the
user is typing, no need to go fully asynchronously.
|
|
|
|
|
|
There is no need to do a blocking call to refilter(), so simply
connect an idle callback. This improves responsiveness in huge lists.
|
|
|
|
Need to remove a row reference from the hash table when it's
no longer in the model.
|
|
|
|
This fixes a bug when the underlying model changes and the selection
becomes corrupt.
Also, this patch uses a more efficient approach when creating and
using the mapping, avoiding iterating the whole model but the selected
items only instead.
Fixes: NB#165952 (HildonLiveSearch selection is not consistent when
the model changes)
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
Fixes: NB#162288 (Changing the presence continously will lead to
multiple GLIB Criticals in syslog)
|
|
These happen when convert_child_path_to_path() returns a NULL
pointer.
|
|
It is not necessary to maintain a selection mapping when the GtkTreeView's
selection mode is GTK_SELECTION_NONE, so don't waste time on it.
|
|
|
|
This allows IM to do its work and switch the keyboard layout.
Fixes: NB#155362 (Cannot change language in Contacts from keyboard)
|
|
This reverts commit fc750821842df60096068c9c9e4b33085a1eecbf. That
commit is broken since the filter is set to NULL. Also, it is not
really possible to change or unset the visible function, so we
are doomed.
|
|
This prevents a crasher when the model changes after the live search is
disposed.
|
|
|
|
Fixes NB#158744 (1st selected contact from the list is replaced with
the next one instead of appending both to the list)
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
Create the selection map when the filter is set and there is already a
prefix text in the live search.
|
|
This enables HildonLiveSearch:text to be set before the filter or
visible function, and make it work accordingly.
|
|
There is a critical warning when HildonLiveSearch:text is
set right after creation.
|
|
|
|
|
|
|
|
Since HildonLiveSearch:text is a proxy for GtkEntry:text, it
makes sense to do it in the handler for GtkEntry::changed.
|
|
|
|
These were introduced by the virtual-root work.
|
|
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
Don't assume that the GtkTreeModel given to HildonLiveSearch
is the one used by the GtkTreeView. hildon-fm uses a
GtkTreeModelSort after the GtkTreeModelFilter, so it makes
the necessary conversions of iterators if the application has a
GtkTreeModelSort.
Don't assume that items in the view have a deepness of 0.
In selection_map_update_selection_from_map and
selection_map_update_map_from_selection, it
makes the conversions of GtkTreePath.
Fixes: NB#140251, Livesearch for File Manager
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
|
|
|
|
This will allow GtkIconView users to plug a HildonLiveSearch together
with it. Also, add a new example of this.
|
|
This patch solves a couple of problems in HildonLiveSearch's key-press
handler:
1) Don't show the live search entry if the treeview is hidden
2) If the live search is hidden, pass all presses using the Ctrl key
to the treeview, so shortcuts (e.g. Ctrl+A) still work.
Fixes: NB#151707 (HildonLiveSearch breaks keyboard shortcuts)
|
|
Prevents unwanted consumption of unhandled key presses like keyboard
shortcuts.
Fixes: NB#151707 (HildonLiveSearch breaks keyboard shortcuts)
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
This method allows to clean up the selection map kept internally
in HildonLiveSearch, for cases in which restoring the previous
selection would cause inconsistences.
|
|
|
|
|
|
Since there is no need to set the visible function more than once, do
it only once. This fixes some critical warnings.
|
|
Avoiding this way critical warnings in HildonTouchSelector.
|
|
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
During the mapping of the selection, visible_func() was heavily used
to find out whether a model row is visible or not. Instead, this could
be done by checking whether filter_path is valid, then saving many
calls to the visible_func().
|
|
|
|
Adds a signal emitted when it is necessary to refilter the items
in the GtkTreeModel in a live search widget. This adds the
possibility for the user to stop the filtering or to filter
it himself.
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
This matches better the terminology in GtkTreeModelFilter.
Also, slightly improve the documentation.
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|
|
Signed-off-by: Claudio Saavedra <csaavedra@igalia.com>
|