aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBoris Gjenero <boris.gjenero@gmail.com>2014-02-06 00:09:12 -0500
committerBoris Gjenero <boris.gjenero@gmail.com>2014-02-06 00:19:02 -0500
commit8a0e08a1e5b27a7c0ee7afe9564f80c3fa5f04b1 (patch)
tree7cdd17205227631572ec92d49330a293e9247f3c
parent3605f8cc21d082b3e509811c87d04b1370d88623 (diff)
Always preventDefault() on keydown if keypress is not needed.
Some browser shortcut keys activate if event.preventDefault() is not called for the keydown event. This will prevent all such hotkeys when keypress events aren't needed.
-rw-r--r--src/library_sdl.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/library_sdl.js b/src/library_sdl.js
index 04e8fc18..caba9b74 100644
--- a/src/library_sdl.js
+++ b/src/library_sdl.js
@@ -406,7 +406,7 @@ var LibrarySDL = {
// won't fire. However, it's fine (and in some cases necessary) to
// preventDefault for keys that don't generate a character. Otherwise,
// preventDefault is the right thing to do in general.
- if (event.type !== 'keydown' || (event.keyCode === 8 /* backspace */ || event.keyCode === 9 /* tab */)) {
+ if (event.type !== 'keydown' || (!SDL.unicode && !SDL.textInput) || (event.keyCode === 8 /* backspace */ || event.keyCode === 9 /* tab */)) {
event.preventDefault();
}