From 8a0e08a1e5b27a7c0ee7afe9564f80c3fa5f04b1 Mon Sep 17 00:00:00 2001 From: Boris Gjenero Date: Thu, 6 Feb 2014 00:09:12 -0500 Subject: Always preventDefault() on keydown if keypress is not needed. Some browser shortcut keys activate if event.preventDefault() is not called for the keydown event. This will prevent all such hotkeys when keypress events aren't needed. --- src/library_sdl.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/library_sdl.js b/src/library_sdl.js index 04e8fc18..caba9b74 100644 --- a/src/library_sdl.js +++ b/src/library_sdl.js @@ -406,7 +406,7 @@ var LibrarySDL = { // won't fire. However, it's fine (and in some cases necessary) to // preventDefault for keys that don't generate a character. Otherwise, // preventDefault is the right thing to do in general. - if (event.type !== 'keydown' || (event.keyCode === 8 /* backspace */ || event.keyCode === 9 /* tab */)) { + if (event.type !== 'keydown' || (!SDL.unicode && !SDL.textInput) || (event.keyCode === 8 /* backspace */ || event.keyCode === 9 /* tab */)) { event.preventDefault(); } -- cgit v1.2.3-18-g5258