1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
|
//===- PNaClABIVerifyModule.cpp - Verify PNaCl ABI rules ------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
//
// Verify module-level PNaCl ABI requirements (specifically those that do not
// require looking at the function bodies)
//
//
//===----------------------------------------------------------------------===//
#include "llvm/Pass.h"
#include "llvm/ADT/Twine.h"
#include "llvm/Analysis/NaCl.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DerivedTypes.h"
#include "llvm/IR/Intrinsics.h"
#include "llvm/IR/Module.h"
#include "llvm/Support/Debug.h"
#include "llvm/Support/raw_ostream.h"
#include "PNaClABITypeChecker.h"
using namespace llvm;
namespace llvm {
cl::opt<bool>
PNaClABIAllowDebugMetadata("pnaclabi-allow-debug-metadata",
cl::desc("Allow debug metadata during PNaCl ABI verification."),
cl::init(false));
}
static cl::opt<bool>
PNaClABIAllowDevIntrinsics("pnaclabi-allow-dev-intrinsics",
cl::desc("Allow all LLVM intrinsics during PNaCl ABI verification."),
cl::init(true)); // TODO(jvoung): Make this false by default.
namespace {
// This pass should not touch function bodies, to stay streaming-friendly
class PNaClABIVerifyModule : public ModulePass {
public:
static char ID;
PNaClABIVerifyModule() :
ModulePass(ID),
Reporter(new PNaClABIErrorReporter),
ReporterIsOwned(true) {
initializePNaClABIVerifyModulePass(*PassRegistry::getPassRegistry());
}
explicit PNaClABIVerifyModule(PNaClABIErrorReporter *Reporter_,
bool StreamingMode) :
ModulePass(ID),
Reporter(Reporter_),
ReporterIsOwned(false),
StreamingMode(StreamingMode) {
initializePNaClABIVerifyModulePass(*PassRegistry::getPassRegistry());
}
~PNaClABIVerifyModule() {
if (ReporterIsOwned)
delete Reporter;
}
bool runOnModule(Module &M);
virtual void print(raw_ostream &O, const Module *M) const;
private:
void checkGlobalValueCommon(const GlobalValue *GV);
bool isWhitelistedIntrinsic(const Function *F, unsigned ID);
bool isWhitelistedMetadata(const NamedMDNode *MD);
void checkGlobalIsFlattened(const GlobalVariable *GV);
PNaClABIErrorReporter *Reporter;
bool ReporterIsOwned;
bool StreamingMode;
};
static const char *linkageName(GlobalValue::LinkageTypes LT) {
// This logic is taken from PrintLinkage in lib/VMCore/AsmWriter.cpp
switch (LT) {
case GlobalValue::ExternalLinkage: return "external";
case GlobalValue::PrivateLinkage: return "private ";
case GlobalValue::LinkerPrivateLinkage: return "linker_private ";
case GlobalValue::LinkerPrivateWeakLinkage: return "linker_private_weak ";
case GlobalValue::InternalLinkage: return "internal ";
case GlobalValue::LinkOnceAnyLinkage: return "linkonce ";
case GlobalValue::LinkOnceODRLinkage: return "linkonce_odr ";
case GlobalValue::LinkOnceODRAutoHideLinkage:
return "linkonce_odr_auto_hide ";
case GlobalValue::WeakAnyLinkage: return "weak ";
case GlobalValue::WeakODRLinkage: return "weak_odr ";
case GlobalValue::CommonLinkage: return "common ";
case GlobalValue::AppendingLinkage: return "appending ";
case GlobalValue::DLLImportLinkage: return "dllimport ";
case GlobalValue::DLLExportLinkage: return "dllexport ";
case GlobalValue::ExternalWeakLinkage: return "extern_weak ";
case GlobalValue::AvailableExternallyLinkage:
return "available_externally ";
default:
return "unknown";
}
}
} // end anonymous namespace
// Check linkage type and section attributes, which are the same for
// GlobalVariables and Functions.
void PNaClABIVerifyModule::checkGlobalValueCommon(const GlobalValue *GV) {
assert(!isa<GlobalAlias>(GV));
const char *GVTypeName = isa<GlobalVariable>(GV) ?
"Variable " : "Function ";
switch (GV->getLinkage()) {
// TODO(dschuff): Disallow external linkage
case GlobalValue::ExternalLinkage:
case GlobalValue::InternalLinkage:
break;
default:
Reporter->addError() << GVTypeName << GV->getName()
<< " has disallowed linkage type: "
<< linkageName(GV->getLinkage()) << "\n";
}
if (GV->getVisibility() != GlobalValue::DefaultVisibility) {
std::string Text = "unknown";
if (GV->getVisibility() == GlobalValue::HiddenVisibility) {
Text = "hidden";
} else if (GV->getVisibility() == GlobalValue::ProtectedVisibility) {
Text = "protected";
}
Reporter->addError() << GVTypeName << GV->getName()
<< " has disallowed visibility: " << Text << "\n";
}
if (GV->hasSection()) {
Reporter->addError() << GVTypeName << GV->getName() <<
" has disallowed \"section\" attribute\n";
}
if (GV->getType()->getAddressSpace() != 0) {
Reporter->addError() << GVTypeName << GV->getName()
<< " has addrspace attribute (disallowed)\n";
}
// The "unnamed_addr" attribute can be used to merge duplicate
// definitions, but that should be done by user-toolchain
// optimization passes, not by the PNaCl translator.
if (GV->hasUnnamedAddr()) {
Reporter->addError() << GVTypeName << GV->getName()
<< " has disallowed \"unnamed_addr\" attribute\n";
}
}
static bool TypeAcceptable(const Type *T,
const ArrayRef<Type*> &AcceptableTypes) {
for (ArrayRef<Type*>::iterator I = AcceptableTypes.begin(),
E = AcceptableTypes.end(); I != E; ++I)
if (*I == T)
return true;
return false;
}
// We accept bswap for a limited set of types (i16, i32, i64).
// The various backends are able to generate instructions to
// implement the intrinsic. Also, i16 and i64 are easy to
// implement as along as there is a way to do i32.
static bool isWhitelistedBswap(const Function *F) {
FunctionType *FT = F->getFunctionType();
if (FT->getNumParams() != 1)
return false;
Type *ParamType = FT->getParamType(0);
LLVMContext &C = F->getContext();
Type *AcceptableTypes[] = { Type::getInt16Ty(C),
Type::getInt32Ty(C),
Type::getInt64Ty(C) };
return TypeAcceptable(ParamType, AcceptableTypes);
}
// We accept cttz, ctlz, and ctpop for a limited set of types (i32, i64).
static bool isWhitelistedCountBits(const Function *F, unsigned num_params) {
FunctionType *FT = F->getFunctionType();
if (FT->getNumParams() != num_params)
return false;
Type *ParamType = FT->getParamType(0);
LLVMContext &C = F->getContext();
Type *AcceptableTypes[] = { Type::getInt32Ty(C), Type::getInt64Ty(C) };
return TypeAcceptable(ParamType, AcceptableTypes);
}
bool PNaClABIVerifyModule::isWhitelistedIntrinsic(const Function *F,
unsigned ID) {
// Keep 3 categories of intrinsics for now.
// (1) Allowed always
// (2) Never allowed
// (3) "Dev" intrinsics, which may or may not be allowed.
// "Dev" intrinsics are controlled by the PNaClABIAllowDevIntrinsics flag.
// Please keep these sorted or grouped in a sensible way, within
// each category.
switch(ID) {
// Disallow by default.
default: return false;
// (1) Always allowed.
case Intrinsic::bswap: return isWhitelistedBswap(F);
case Intrinsic::ctlz:
case Intrinsic::cttz: return isWhitelistedCountBits(F, 2);
case Intrinsic::ctpop: return isWhitelistedCountBits(F, 1);
case Intrinsic::memcpy:
case Intrinsic::memmove:
case Intrinsic::memset:
case Intrinsic::nacl_read_tp:
case Intrinsic::nacl_setjmp:
case Intrinsic::nacl_longjmp:
// Stack save and restore are used to support C99 VLAs.
case Intrinsic::stackrestore:
case Intrinsic::stacksave:
case Intrinsic::trap:
return true;
// (2) Known to be never allowed.
case Intrinsic::not_intrinsic:
// Trampolines depend on a target-specific-sized/aligned buffer.
case Intrinsic::adjust_trampoline:
case Intrinsic::init_trampoline:
// CXX exception handling is not stable.
case Intrinsic::eh_dwarf_cfa:
case Intrinsic::eh_return_i32:
case Intrinsic::eh_return_i64:
case Intrinsic::eh_sjlj_callsite:
case Intrinsic::eh_sjlj_functioncontext:
case Intrinsic::eh_sjlj_longjmp:
case Intrinsic::eh_sjlj_lsda:
case Intrinsic::eh_sjlj_setjmp:
case Intrinsic::eh_typeid_for:
case Intrinsic::eh_unwind_init:
// We do not want to expose addresses to the user.
case Intrinsic::frameaddress:
case Intrinsic::returnaddress:
// Not supporting stack protectors.
case Intrinsic::stackprotector:
// Var-args handling is done w/out intrinsics.
case Intrinsic::vacopy:
case Intrinsic::vaend:
case Intrinsic::vastart:
// Disallow the *_with_overflow intrinsics because they return
// struct types. All of them can be introduced by passing -ftrapv
// to Clang, which we do not support for now. umul_with_overflow
// and uadd_with_overflow are introduced by Clang for C++'s new[],
// but ExpandArithWithOverflow expands out this use.
case Intrinsic::sadd_with_overflow:
case Intrinsic::ssub_with_overflow:
case Intrinsic::uadd_with_overflow:
case Intrinsic::usub_with_overflow:
case Intrinsic::smul_with_overflow:
case Intrinsic::umul_with_overflow:
// Disallow lifetime.start/end because the semantics of what
// arguments they accept are not very well defined, and because it
// would be better to do merging of stack slots in the user
// toolchain than in the PNaCl translator.
// See https://code.google.com/p/nativeclient/issues/detail?id=3443
case Intrinsic::lifetime_end:
case Intrinsic::lifetime_start:
case Intrinsic::invariant_end:
case Intrinsic::invariant_start:
// Some transcendental functions not needed yet.
case Intrinsic::cos:
case Intrinsic::exp:
case Intrinsic::exp2:
case Intrinsic::log:
case Intrinsic::log2:
case Intrinsic::log10:
case Intrinsic::pow:
case Intrinsic::sin:
// We run -lower-expect to convert Intrinsic::expect into branch weights
// and consume in the middle-end. The backend just ignores llvm.expect.
case Intrinsic::expect:
// For FLT_ROUNDS macro from float.h. It works for ARM and X86
// (but not MIPS). Also, wait until we add a set_flt_rounds intrinsic
// before we bless this.
case Intrinsic::flt_rounds:
return false;
// (3) Dev intrinsics.
case Intrinsic::dbg_declare:
case Intrinsic::dbg_value:
return PNaClABIAllowDevIntrinsics || PNaClABIAllowDebugMetadata;
case Intrinsic::nacl_target_arch: // Used by translator self-build.
case Intrinsic::powi: // Rounding not defined: support with fast-math?
case Intrinsic::prefetch: // TODO(jfb): Use our own data-prefetch intrinsic instead.
case Intrinsic::sqrt: // Rounding is defined, but setting errno up to libm.
return PNaClABIAllowDevIntrinsics;
}
}
bool PNaClABIVerifyModule::isWhitelistedMetadata(const NamedMDNode *MD) {
return MD->getName().startswith("llvm.dbg.") && PNaClABIAllowDebugMetadata;
}
static bool isPtrToIntOfGlobal(const Constant *C) {
if (const ConstantExpr *CE = dyn_cast<ConstantExpr>(C)) {
return CE->getOpcode() == Instruction::PtrToInt &&
isa<GlobalValue>(CE->getOperand(0));
}
return false;
}
// This checks for part of the normal form produced by FlattenGlobals.
static bool isSimpleElement(const Constant *C) {
// A SimpleElement is one of the following:
// 1) An i8 array literal or zeroinitializer:
// [SIZE x i8] c"DATA"
// [SIZE x i8] zeroinitializer
if (ArrayType *Ty = dyn_cast<ArrayType>(C->getType())) {
return Ty->getElementType()->isIntegerTy(8) &&
(isa<ConstantAggregateZero>(C) ||
isa<ConstantDataSequential>(C));
}
// 2) A reference to a GlobalValue (a function or global variable)
// with an optional byte offset added to it (the addend).
if (C->getType()->isIntegerTy(32)) {
const ConstantExpr *CE = dyn_cast<ConstantExpr>(C);
if (!CE)
return false;
// Without addend: ptrtoint (TYPE* @GLOBAL to i32)
if (isPtrToIntOfGlobal(CE))
return true;
// With addend: add (i32 ptrtoint (TYPE* @GLOBAL to i32), i32 ADDEND)
if (CE->getOpcode() == Instruction::Add &&
isPtrToIntOfGlobal(CE->getOperand(0)) &&
isa<ConstantInt>(CE->getOperand(1)))
return true;
}
return false;
}
// This checks for part of the normal form produced by FlattenGlobals.
static bool isCompoundElement(const Constant *C) {
const ConstantStruct *CS = dyn_cast<ConstantStruct>(C);
if (!CS || !CS->getType()->isPacked() || CS->getType()->hasName() ||
CS->getNumOperands() <= 1)
return false;
for (unsigned I = 0; I < CS->getNumOperands(); ++I) {
if (!isSimpleElement(CS->getOperand(I)))
return false;
}
return true;
}
static std::string getAttributesAsString(AttributeSet Attrs) {
std::string AttrsAsString;
for (unsigned Slot = 0; Slot < Attrs.getNumSlots(); ++Slot) {
for (AttributeSet::iterator Attr = Attrs.begin(Slot),
E = Attrs.end(Slot); Attr != E; ++Attr) {
AttrsAsString += " ";
AttrsAsString += Attr->getAsString();
}
}
return AttrsAsString;
}
// This checks that the GlobalVariable has the normal form produced by
// the FlattenGlobals pass.
void PNaClABIVerifyModule::checkGlobalIsFlattened(const GlobalVariable *GV) {
if (!GV->hasInitializer()) {
Reporter->addError() << "Global variable " << GV->getName()
<< " has no initializer (disallowed)\n";
return;
}
const Constant *InitVal = GV->getInitializer();
if (isSimpleElement(InitVal) || isCompoundElement(InitVal))
return;
Reporter->addError() << "Global variable " << GV->getName()
<< " has non-flattened initializer (disallowed): "
<< *InitVal << "\n";
}
bool PNaClABIVerifyModule::runOnModule(Module &M) {
if (!M.getModuleInlineAsm().empty()) {
Reporter->addError() <<
"Module contains disallowed top-level inline assembly\n";
}
for (Module::const_global_iterator MI = M.global_begin(), ME = M.global_end();
MI != ME; ++MI) {
checkGlobalIsFlattened(MI);
checkGlobalValueCommon(MI);
if (MI->isThreadLocal()) {
Reporter->addError() << "Variable " << MI->getName() <<
" has disallowed \"thread_local\" attribute\n";
}
if (MI->isExternallyInitialized()) {
Reporter->addError() << "Variable " << MI->getName() <<
" has disallowed \"externally_initialized\" attribute\n";
}
}
// No aliases allowed for now.
for (Module::alias_iterator MI = M.alias_begin(),
E = M.alias_end(); MI != E; ++MI) {
Reporter->addError() << "Variable " << MI->getName() <<
" is an alias (disallowed)\n";
}
for (Module::const_iterator MI = M.begin(), ME = M.end(); MI != ME; ++MI) {
if (MI->isIntrinsic()) {
// Check intrinsics.
if (!isWhitelistedIntrinsic(MI, MI->getIntrinsicID())) {
Reporter->addError() << "Function " << MI->getName()
<< " is a disallowed LLVM intrinsic\n";
}
} else {
// Check types of functions and their arguments. Not necessary
// for intrinsics, whose types are fixed anyway, and which have
// argument types that we disallow such as i8.
if (!PNaClABITypeChecker::isValidFunctionType(MI->getFunctionType())) {
Reporter->addError() << "Function " << MI->getName()
<< " has disallowed type: "
<< PNaClABITypeChecker::getTypeName(MI->getFunctionType())
<< "\n";
}
// This check is disabled in streaming mode because it would
// reject a function that is defined but not read in yet.
// Unfortunately this means we simply don't check this property
// when translating a pexe in the browser.
// TODO(mseaborn): Enforce this property in the bitcode reader.
if (!StreamingMode && MI->isDeclaration()) {
Reporter->addError() << "Function " << MI->getName()
<< " is declared but not defined (disallowed)\n";
}
if (!MI->getAttributes().isEmpty()) {
Reporter->addError()
<< "Function " << MI->getName() << " has disallowed attributes:"
<< getAttributesAsString(MI->getAttributes()) << "\n";
}
if (MI->getCallingConv() != CallingConv::C) {
Reporter->addError()
<< "Function " << MI->getName()
<< " has disallowed calling convention: "
<< MI->getCallingConv() << "\n";
}
}
checkGlobalValueCommon(MI);
if (MI->hasGC()) {
Reporter->addError() << "Function " << MI->getName() <<
" has disallowed \"gc\" attribute\n";
}
// Knowledge of what function alignments are useful is
// architecture-specific and sandbox-specific, so PNaCl pexes
// should not be able to specify function alignment.
if (MI->getAlignment() != 0) {
Reporter->addError() << "Function " << MI->getName() <<
" has disallowed \"align\" attribute\n";
}
}
// Check named metadata nodes
for (Module::const_named_metadata_iterator I = M.named_metadata_begin(),
E = M.named_metadata_end(); I != E; ++I) {
if (!isWhitelistedMetadata(I)) {
Reporter->addError() << "Named metadata node " << I->getName()
<< " is disallowed\n";
}
}
Reporter->checkForFatalErrors();
return false;
}
// This method exists so that the passes can easily be run with opt -analyze.
// In this case the default constructor is used and we want to reset the error
// messages after each print (this is more of an issue for the FunctionPass
// than the ModulePass)
void PNaClABIVerifyModule::print(llvm::raw_ostream &O, const Module *M) const {
Reporter->printErrors(O);
Reporter->reset();
}
char PNaClABIVerifyModule::ID = 0;
INITIALIZE_PASS(PNaClABIVerifyModule, "verify-pnaclabi-module",
"Verify module for PNaCl", false, true)
ModulePass *llvm::createPNaClABIVerifyModulePass(
PNaClABIErrorReporter *Reporter, bool StreamingMode) {
return new PNaClABIVerifyModule(Reporter, StreamingMode);
}
|