aboutsummaryrefslogtreecommitdiff
path: root/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
diff options
context:
space:
mode:
Diffstat (limited to 'lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp')
-rw-r--r--lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp12
1 files changed, 11 insertions, 1 deletions
diff --git a/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp b/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
index 4c4c935ec5..54e2e19340 100644
--- a/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
+++ b/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
@@ -67,6 +67,8 @@ bool PNaClABIVerifyFunctions::runOnFunction(Function &F) {
default:
// We expand GetElementPtr out into arithmetic.
case Instruction::GetElementPtr:
+ // VAArg is expanded out by ExpandVarArgs.
+ case Instruction::VAArg:
// Zero-cost C++ exception handling is not supported yet.
case Instruction::Invoke:
case Instruction::LandingPad:
@@ -134,8 +136,16 @@ bool PNaClABIVerifyFunctions::runOnFunction(Function &F) {
case Instruction::FCmp:
case Instruction::PHI:
case Instruction::Select:
+ break;
case Instruction::Call:
- case Instruction::VAArg:
+ // Pointers to varargs function types are not yet
+ // disallowed, but we do disallow defining or calling
+ // functions of varargs types.
+ if (cast<CallInst>(BBI)->getCalledValue()->getType()
+ ->getPointerElementType()->isFunctionVarArg()) {
+ Reporter->addError() << "Function " << F.getName() <<
+ " contains a disallowed varargs function call\n";
+ }
break;
}
// Check the types. First check the type of the instruction.