diff options
| author | Jan Voung <jvoung@chromium.org> | 2013-04-26 14:12:49 -0700 |
|---|---|---|
| committer | Jan Voung <jvoung@chromium.org> | 2013-04-26 14:12:49 -0700 |
| commit | f8b761e8e49cf46f796510e5ef946b2a261dd45b (patch) | |
| tree | 8bf885cc463da5d57ca37ef28802c83e869c61ba /tools | |
| parent | 7564114a66c3d5401f5b63c6a940e7c2c2c329b6 (diff) | |
Check for metadata in PNaCl ABI checker.
Disallow all metadata by default. There is a flag "-allow-debug-metadata",
which will be used in pnacl-ld driver, to not change the debugging workflow.
That flag will not be present in the pnacl-abicheck driver though.
We'll also run -strip-metadata within pnacl-ld, after optimizations are run,
so that at least that part is checked inside pnacl-ld.
CL for driver changes:
https://codereview.chromium.org/14358048/
BUG= http://code.google.com/p/nativeclient/issues/detail?id=3348
R=dschuff@chromium.org
Review URL: https://codereview.chromium.org/14329025
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/pnacl-abicheck/pnacl-abicheck.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/pnacl-abicheck/pnacl-abicheck.cpp b/tools/pnacl-abicheck/pnacl-abicheck.cpp index e8fce66acd..06b174d1b8 100644 --- a/tools/pnacl-abicheck/pnacl-abicheck.cpp +++ b/tools/pnacl-abicheck/pnacl-abicheck.cpp @@ -26,7 +26,7 @@ using namespace llvm; static cl::opt<std::string> InputFilename(cl::Positional, cl::desc("<input bitcode>"), cl::init("-")); -static cl::opt<bool, false> +static cl::opt<bool> Quiet("q", cl::desc("Do not print error messages")); // Print any errors collected by the error reporter. Return true if @@ -59,7 +59,8 @@ int main(int argc, char **argv) { bool ErrorsFound = false; // Manually run the passes so we can tell the user which function had the // error. No need for a pass manager since it's just one pass. - OwningPtr<ModulePass> ModuleChecker(createPNaClABIVerifyModulePass(&ABIErrorReporter)); + OwningPtr<ModulePass> ModuleChecker( + createPNaClABIVerifyModulePass(&ABIErrorReporter)); ModuleChecker->runOnModule(*Mod); ErrorsFound |= CheckABIVerifyErrors(ABIErrorReporter, "Module"); OwningPtr<FunctionPass> FunctionChecker( |