aboutsummaryrefslogtreecommitdiff
path: root/tools/macho-dump
diff options
context:
space:
mode:
authorJim Stichnoth <stichnot@chromium.org>2013-07-17 12:13:48 -0700
committerJim Stichnoth <stichnot@chromium.org>2013-07-17 12:13:48 -0700
commitcc8deaf49f79eb22c4edc8c0f44ef64668b3be4a (patch)
tree24e2b88702daa994195a1531d790510207589766 /tools/macho-dump
parent5a4bc23e85f58fecbc4e0a6d6fec3c1193bbc350 (diff)
Disallow a global address in the x86-64 displacement field.
This applies only to %r15 sandboxed memory references. The problem is that if the index register is negative, the sandboxing operation will cause the index to become a large positive 32-bit value, which combined with the displacement, will overflow and try to reference memory outside the sandbox. This situation may legitimately occur if the compiler happens to construct a (constant) interior pointer to the middle of the global struct/array, and then dereferences it with a variable offset. After this fix, pnacl/scripts/testsuite_known_failures_pnacl.txt can be updated to remove the "aha x86-64" known failure. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3517 R=eliben@chromium.org Review URL: https://codereview.chromium.org/17987002
Diffstat (limited to 'tools/macho-dump')
0 files changed, 0 insertions, 0 deletions