diff options
| author | Mark Seaborn <mseaborn@chromium.org> | 2013-07-09 11:02:56 -0700 |
|---|---|---|
| committer | Mark Seaborn <mseaborn@chromium.org> | 2013-07-09 11:02:56 -0700 |
| commit | af49991972c1ca2364cd7377f4781893ffb3ffc5 (patch) | |
| tree | 8dfd6ea97b0edc31e0771c2933df3f936956280a /test | |
| parent | d7676885204bbc165a8b27a537777bfe450e6323 (diff) | |
PNaCl: Fix negative relocation addends on x86-32
Disable an assertion. This assertion made the behaviour on x86-32
inconsistent with x86-64 and ARM.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3548
TEST=*.ll tests + PNaCl toolchain trybots
Review URL: https://codereview.chromium.org/18261008
Diffstat (limited to 'test')
| -rw-r--r-- | test/NaCl/ARM/negative-addend.ll | 19 | ||||
| -rw-r--r-- | test/NaCl/X86/negative-addend.ll | 27 |
2 files changed, 46 insertions, 0 deletions
diff --git a/test/NaCl/ARM/negative-addend.ll b/test/NaCl/ARM/negative-addend.ll new file mode 100644 index 0000000000..41d7eba43c --- /dev/null +++ b/test/NaCl/ARM/negative-addend.ll @@ -0,0 +1,19 @@ +; RUN: pnacl-llc -mtriple=arm-unknown-nacl -filetype=obj %s -o - \ +; RUN: | llvm-objdump -r - | FileCheck %s -check-prefix=ARM + +; Check that "add" works for negative values when used as a +; ConstantExpr in a global variable initializer. +; See: https://code.google.com/p/nativeclient/issues/detail?id=3548 + + +; @spacer and @var end up in the BSS section. +; @spacer is at offset 0. @var is at offset 4096 = 0x1000. + +@spacer = internal global [4096 x i8] zeroinitializer +@var = internal global i32 zeroinitializer + +@negative_offset = internal global i32 add + (i32 ptrtoint (i32* @var to i32), i32 -8) + +; ARM: RELOCATION RECORDS FOR [.data.rel.local]: +; ARM-NEXT: 0 R_ARM_ABS32 .bss diff --git a/test/NaCl/X86/negative-addend.ll b/test/NaCl/X86/negative-addend.ll new file mode 100644 index 0000000000..e46f091cc0 --- /dev/null +++ b/test/NaCl/X86/negative-addend.ll @@ -0,0 +1,27 @@ +; RUN: pnacl-llc -mtriple=i386-unknown-nacl -filetype=obj %s -o - \ +; RUN: | llvm-objdump -r - | FileCheck %s -check-prefix=X8632 +; RUN: pnacl-llc -mtriple=x86_64-unknown-nacl -filetype=obj %s -o - \ +; RUN: | llvm-objdump -r - | FileCheck %s -check-prefix=X8664 + +; Check that "add" works for negative values when used as a +; ConstantExpr in a global variable initializer. +; See: https://code.google.com/p/nativeclient/issues/detail?id=3548 + + +; @spacer and @var end up in the BSS section. +; @spacer is at offset 0. @var is at offset 4096 = 0x1000. + +@spacer = internal global [4096 x i8] zeroinitializer +@var = internal global i32 zeroinitializer + +@negative_offset = internal global i32 add + (i32 ptrtoint (i32* @var to i32), i32 -8) + +; Note that the addend 4294971384 below equals 0x100000ff8, where +; 0xff8 comes from subtracting 8 from the offset of @var. + +; X8632: RELOCATION RECORDS FOR [.data]: +; X8632-NEXT: 0 R_386_32 Unknown + +; X8664: RELOCATION RECORDS FOR [.data]: +; X8664-NEXT: 0 R_X86_64_32 .bss+4294971384 |