diff options
author | Derek Schuff <dschuff@google.com> | 2012-02-29 01:09:06 +0000 |
---|---|---|
committer | Derek Schuff <dschuff@google.com> | 2012-02-29 01:09:06 +0000 |
commit | adef06a71458ded0716935a61b3d43d164d4df12 (patch) | |
tree | d56aeec7dde89874b58254175d112ba1e5fddcb5 /lib | |
parent | 95fe7b9b7251d33ad4128603087edac70cec7c72 (diff) |
Make MemoryObject accessor members const again
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151687 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/MC/MCDisassembler/Disassembler.cpp | 4 | ||||
-rw-r--r-- | lib/MC/MCDisassembler/EDDisassembler.cpp | 4 | ||||
-rw-r--r-- | lib/Support/MemoryObject.cpp | 2 | ||||
-rw-r--r-- | lib/Support/StreamableMemoryObject.cpp | 35 | ||||
-rw-r--r-- | lib/Target/ARM/Disassembler/ARMDisassembler.cpp | 8 | ||||
-rw-r--r-- | lib/Target/MBlaze/Disassembler/MBlazeDisassembler.cpp | 2 | ||||
-rw-r--r-- | lib/Target/MBlaze/Disassembler/MBlazeDisassembler.h | 2 | ||||
-rw-r--r-- | lib/Target/X86/Disassembler/X86Disassembler.cpp | 2 | ||||
-rw-r--r-- | lib/Target/X86/Disassembler/X86Disassembler.h | 2 |
9 files changed, 32 insertions, 29 deletions
diff --git a/lib/MC/MCDisassembler/Disassembler.cpp b/lib/MC/MCDisassembler/Disassembler.cpp index 3de6f64e97..605cf88ff2 100644 --- a/lib/MC/MCDisassembler/Disassembler.cpp +++ b/lib/MC/MCDisassembler/Disassembler.cpp @@ -113,9 +113,9 @@ public: Bytes(bytes), Size(size), BasePC(basePC) {} uint64_t getBase() const { return BasePC; } - uint64_t getExtent() { return Size; } + uint64_t getExtent() const { return Size; } - int readByte(uint64_t Addr, uint8_t *Byte) { + int readByte(uint64_t Addr, uint8_t *Byte) const { if (Addr - BasePC >= Size) return -1; *Byte = Bytes[Addr - BasePC]; diff --git a/lib/MC/MCDisassembler/EDDisassembler.cpp b/lib/MC/MCDisassembler/EDDisassembler.cpp index 35cd3d77f8..b1f0e5bc03 100644 --- a/lib/MC/MCDisassembler/EDDisassembler.cpp +++ b/lib/MC/MCDisassembler/EDDisassembler.cpp @@ -199,8 +199,8 @@ namespace { void *arg) : Callback(callback), Arg(arg) { } ~EDMemoryObject() { } uint64_t getBase() const { return 0x0; } - uint64_t getExtent() { return (uint64_t)-1; } - int readByte(uint64_t address, uint8_t *ptr) { + uint64_t getExtent() const { return (uint64_t)-1; } + int readByte(uint64_t address, uint8_t *ptr) const { if (!Callback) return -1; diff --git a/lib/Support/MemoryObject.cpp b/lib/Support/MemoryObject.cpp index c82f46ae79..b20ab89238 100644 --- a/lib/Support/MemoryObject.cpp +++ b/lib/Support/MemoryObject.cpp @@ -16,7 +16,7 @@ MemoryObject::~MemoryObject() { int MemoryObject::readBytes(uint64_t address, uint64_t size, uint8_t* buf, - uint64_t* copied) { + uint64_t* copied) const { uint64_t current = address; uint64_t limit = getBase() + getExtent(); diff --git a/lib/Support/StreamableMemoryObject.cpp b/lib/Support/StreamableMemoryObject.cpp index 0f2acb4c86..c23f07b8fc 100644 --- a/lib/Support/StreamableMemoryObject.cpp +++ b/lib/Support/StreamableMemoryObject.cpp @@ -24,15 +24,17 @@ public: } virtual uint64_t getBase() const { return 0; } - virtual uint64_t getExtent() { return LastChar - FirstChar; } - virtual int readByte(uint64_t address, uint8_t* ptr); + virtual uint64_t getExtent() const { return LastChar - FirstChar; } + virtual int readByte(uint64_t address, uint8_t* ptr) const; virtual int readBytes(uint64_t address, uint64_t size, uint8_t* buf, - uint64_t* copied); - virtual const uint8_t *getPointer(uint64_t address, uint64_t size); - virtual bool isValidAddress(uint64_t address) {return validAddress(address);} - virtual bool isObjectEnd(uint64_t address) {return objectEnd(address);} + uint64_t* copied) const; + virtual const uint8_t *getPointer(uint64_t address, uint64_t size) const; + virtual bool isValidAddress(uint64_t address) const { + return validAddress(address); + } + virtual bool isObjectEnd(uint64_t address) const {return objectEnd(address);} private: const uint8_t* const FirstChar; @@ -40,10 +42,10 @@ private: // These are implemented as inline functions here to avoid multiple virtual // calls per public function - bool validAddress(uint64_t address) { + bool validAddress(uint64_t address) const { return static_cast<ptrdiff_t>(address) < LastChar - FirstChar; } - bool objectEnd(uint64_t address) { + bool objectEnd(uint64_t address) const { return static_cast<ptrdiff_t>(address) == LastChar - FirstChar; } @@ -51,7 +53,7 @@ private: void operator=(const RawMemoryObject&); // DO NOT IMPLEMENT }; -int RawMemoryObject::readByte(uint64_t address, uint8_t* ptr) { +int RawMemoryObject::readByte(uint64_t address, uint8_t* ptr) const { if (!validAddress(address)) return -1; *ptr = *((uint8_t *)(uintptr_t)(address + FirstChar)); return 0; @@ -60,14 +62,15 @@ int RawMemoryObject::readByte(uint64_t address, uint8_t* ptr) { int RawMemoryObject::readBytes(uint64_t address, uint64_t size, uint8_t* buf, - uint64_t* copied) { + uint64_t* copied) const { if (!validAddress(address) || !validAddress(address + size - 1)) return -1; memcpy(buf, (uint8_t *)(uintptr_t)(address + FirstChar), size); if (copied) *copied = size; return size; } -const uint8_t *RawMemoryObject::getPointer(uint64_t address, uint64_t size) { +const uint8_t *RawMemoryObject::getPointer(uint64_t address, + uint64_t size) const { return FirstChar + address; } } // anonymous namespace @@ -75,18 +78,18 @@ const uint8_t *RawMemoryObject::getPointer(uint64_t address, uint64_t size) { namespace llvm { // If the bitcode has a header, then its size is known, and we don't have to // block until we actually want to read it. -bool StreamingMemoryObject::isValidAddress(uint64_t address) { +bool StreamingMemoryObject::isValidAddress(uint64_t address) const { if (ObjectSize && address < ObjectSize) return true; return fetchToPos(address); } -bool StreamingMemoryObject::isObjectEnd(uint64_t address) { +bool StreamingMemoryObject::isObjectEnd(uint64_t address) const { if (ObjectSize) return address == ObjectSize; fetchToPos(address); return address == ObjectSize && address != 0; } -uint64_t StreamingMemoryObject::getExtent() { +uint64_t StreamingMemoryObject::getExtent() const { if (ObjectSize) return ObjectSize; size_t pos = BytesRead + kChunkSize; // keep fetching until we run out of bytes @@ -94,7 +97,7 @@ uint64_t StreamingMemoryObject::getExtent() { return ObjectSize; } -int StreamingMemoryObject::readByte(uint64_t address, uint8_t* ptr) { +int StreamingMemoryObject::readByte(uint64_t address, uint8_t* ptr) const { if (!fetchToPos(address)) return -1; *ptr = Bytes[address + BytesSkipped]; return 0; @@ -103,7 +106,7 @@ int StreamingMemoryObject::readByte(uint64_t address, uint8_t* ptr) { int StreamingMemoryObject::readBytes(uint64_t address, uint64_t size, uint8_t* buf, - uint64_t* copied) { + uint64_t* copied) const { if (!fetchToPos(address + size - 1)) return -1; memcpy(buf, &Bytes[address + BytesSkipped], size); if (copied) *copied = size; diff --git a/lib/Target/ARM/Disassembler/ARMDisassembler.cpp b/lib/Target/ARM/Disassembler/ARMDisassembler.cpp index e570cd5ea6..fc6b9a11f8 100644 --- a/lib/Target/ARM/Disassembler/ARMDisassembler.cpp +++ b/lib/Target/ARM/Disassembler/ARMDisassembler.cpp @@ -46,7 +46,7 @@ public: /// getInstruction - See MCDisassembler. DecodeStatus getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const; @@ -71,7 +71,7 @@ public: /// getInstruction - See MCDisassembler. DecodeStatus getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const; @@ -341,7 +341,7 @@ const EDInstInfo *ThumbDisassembler::getEDInfo() const { } DecodeStatus ARMDisassembler::getInstruction(MCInst &MI, uint64_t &Size, - MemoryObject &Region, + const MemoryObject &Region, uint64_t Address, raw_ostream &os, raw_ostream &cs) const { @@ -689,7 +689,7 @@ void ThumbDisassembler::UpdateThumbVFPPredicate(MCInst &MI) const { } DecodeStatus ThumbDisassembler::getInstruction(MCInst &MI, uint64_t &Size, - MemoryObject &Region, + const MemoryObject &Region, uint64_t Address, raw_ostream &os, raw_ostream &cs) const { diff --git a/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.cpp b/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.cpp index 77a77974d8..adedf93750 100644 --- a/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.cpp +++ b/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.cpp @@ -502,7 +502,7 @@ const EDInstInfo *MBlazeDisassembler::getEDInfo() const { MCDisassembler::DecodeStatus MBlazeDisassembler::getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const { diff --git a/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.h b/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.h index 97c4af963c..5c4ae3b1ac 100644 --- a/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.h +++ b/lib/Target/MBlaze/Disassembler/MBlazeDisassembler.h @@ -40,7 +40,7 @@ public: /// getInstruction - See MCDisassembler. MCDisassembler::DecodeStatus getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const; diff --git a/lib/Target/X86/Disassembler/X86Disassembler.cpp b/lib/Target/X86/Disassembler/X86Disassembler.cpp index efbe326eec..676321a181 100644 --- a/lib/Target/X86/Disassembler/X86Disassembler.cpp +++ b/lib/Target/X86/Disassembler/X86Disassembler.cpp @@ -121,7 +121,7 @@ static void logger(void* arg, const char* log) { MCDisassembler::DecodeStatus X86GenericDisassembler::getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const { diff --git a/lib/Target/X86/Disassembler/X86Disassembler.h b/lib/Target/X86/Disassembler/X86Disassembler.h index 85e8ab63a3..c11f51c6a9 100644 --- a/lib/Target/X86/Disassembler/X86Disassembler.h +++ b/lib/Target/X86/Disassembler/X86Disassembler.h @@ -117,7 +117,7 @@ public: /// getInstruction - See MCDisassembler. DecodeStatus getInstruction(MCInst &instr, uint64_t &size, - MemoryObject ®ion, + const MemoryObject ®ion, uint64_t address, raw_ostream &vStream, raw_ostream &cStream) const; |