PNaCl: Allow the ABI checker to be used from "opt"

This allows the ABI checker passes to be used in the same way as
LLVM's "-verify" pass.  It allows the checker to be run between other
passes, and without launching pnacl-abicheck as a separate process (so
without the overhead of reading bitcode into memory again).

Make the ABI checker passes produce fatal errors by default, to match
"-verify".  This is overridden for pnacl-abicheck's use.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2309
TEST=tested with pnacl-ld.py changes to use the ABI checker passes

Review URL: https://codereview.chromium.org/13323006

2 files changed, 3 insertions, 0 deletions

diff --git a/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp b/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
index 8404a4cafc..55269dc9fe 100644
--- a/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
+++ b/lib/Analysis/NaCl/PNaClABIVerifyFunctions.cpp
@@ -175,6 +175,7 @@ bool PNaClABIVerifyFunctions::runOnFunction(Function &F) {
     }
   }
 
+  Reporter->checkForFatalErrors();
   return false;
 }
 
diff --git a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp
index 660fa9f8fe..23699860b0 100644
--- a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp
+++ b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp
@@ -149,6 +149,8 @@ bool PNaClABIVerifyModule::runOnModule(Module &M) {
       }
     }
   }
+
+  Reporter->checkForFatalErrors();
   return false;
 }