diff options
author | Evan Cheng <evan.cheng@apple.com> | 2011-02-08 03:07:03 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2011-02-08 03:07:03 +0000 |
commit | 75396a998887220074b90f176e29054a35b6c0ed (patch) | |
tree | 3611809d85c90f77432ba92492cdc8dff5fb2013 /lib/Target/ARM/Thumb2SizeReduction.cpp | |
parent | 3ef9838f89617fc471b6b84a64c7af824a070e50 (diff) |
Temporary workaround for a bad bug introduced by r121082 which replaced
t2LDRpci with t2LDRi12.
There are a couple of problems with this.
1. The encoding for the literal and immediate constant are different.
Note bit 7 of the literal case is 'U' so it can be negative.
2. t2LDRi12 is now narrowed to tLDRpci before constant island pass is run.
So we end up never using the Thumb2 instruction, which ends up creating a
lot more constant islands.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@125074 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/ARM/Thumb2SizeReduction.cpp')
-rw-r--r-- | lib/Target/ARM/Thumb2SizeReduction.cpp | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/lib/Target/ARM/Thumb2SizeReduction.cpp b/lib/Target/ARM/Thumb2SizeReduction.cpp index a8badf7173..3d7bcb23f8 100644 --- a/lib/Target/ARM/Thumb2SizeReduction.cpp +++ b/lib/Target/ARM/Thumb2SizeReduction.cpp @@ -294,14 +294,11 @@ Thumb2SizeReduce::ReduceLoadStore(MachineBasicBlock &MBB, MachineInstr *MI, HasImmOffset = true; HasOffReg = false; } else { - if (Entry.WideOpc == ARM::t2LDRi12) { - Opc = ARM::tLDRpci; - OpNum = 2; - } - - HasImmOffset = false; - HasBaseReg = false; - HasOffReg = false; + // FIXME: Temporary workaround for a bug introduced by r121082. + // We should use t2LDRpci for loads from constantpools. + // We don't want to narrow this to tLDRpci until constant island pass + // for fear of pessimizing code. + return false; } break; case ARM::t2LDRBi12: |