diff options
author | Owen Anderson <resistor@mac.com> | 2010-12-07 07:56:20 +0000 |
---|---|---|
committer | Owen Anderson <resistor@mac.com> | 2010-12-07 07:56:20 +0000 |
commit | 0ea112f104215ccba8d89c839cdeded6e3d49e59 (patch) | |
tree | c558fef34299934cddbf97715475c6f8fc1fe765 /lib/Support/DynamicLibrary.cpp | |
parent | 280423558dc9004ed686f474b0508ac7a298108a (diff) |
Don't leak the mutex when loading dynamic libraries.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121119 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/DynamicLibrary.cpp')
-rw-r--r-- | lib/Support/DynamicLibrary.cpp | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/lib/Support/DynamicLibrary.cpp b/lib/Support/DynamicLibrary.cpp index cd9927a193..455c3801cc 100644 --- a/lib/Support/DynamicLibrary.cpp +++ b/lib/Support/DynamicLibrary.cpp @@ -61,17 +61,12 @@ using namespace llvm::sys; //=== independent code. //===----------------------------------------------------------------------===// -static SmartMutex<true>* HandlesMutex; static std::vector<void *> *OpenedHandles = 0; -static bool InitializeMutex() { - HandlesMutex = new SmartMutex<true>; - return HandlesMutex != 0; -} -static bool EnsureMutexInitialized() { - static bool result = InitializeMutex(); - return result; +static SmartMutex<true>& getMutex() { + static SmartMutex<true> HandlesMutex; + return HandlesMutex; } @@ -88,8 +83,7 @@ bool DynamicLibrary::LoadLibraryPermanently(const char *Filename, if (Filename == NULL) H = RTLD_DEFAULT; #endif - EnsureMutexInitialized(); - SmartScopedLock<true> Lock(*HandlesMutex); + SmartScopedLock<true> Lock(getMutex()); if (OpenedHandles == 0) OpenedHandles = new std::vector<void *>(); OpenedHandles->push_back(H); @@ -124,8 +118,7 @@ void* DynamicLibrary::SearchForAddressOfSymbol(const char* symbolName) { #if HAVE_DLFCN_H // Now search the libraries. - EnsureMutexInitialized(); - SmartScopedLock<true> Lock(*HandlesMutex); + SmartScopedLock<true> Lock(getMutex()); if (OpenedHandles) { for (std::vector<void *>::iterator I = OpenedHandles->begin(), E = OpenedHandles->end(); I != E; ++I) { |