diff options
author | Chris Lattner <sabre@nondot.org> | 2009-11-01 18:16:30 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-11-01 18:16:30 +0000 |
commit | 66588707acf54750dd2e3d79352df61a59be967e (patch) | |
tree | 95c23495636080affcd385152c90cedf8535fa89 /lib/Analysis/InlineCost.cpp | |
parent | 1107f03ef43b4777f0289030e1ee1b38980a7b32 (diff) |
add a comment about why we don't allow inlining indbr.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@85724 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/InlineCost.cpp')
-rw-r--r-- | lib/Analysis/InlineCost.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/lib/Analysis/InlineCost.cpp b/lib/Analysis/InlineCost.cpp index f6664ed788..4f0b337807 100644 --- a/lib/Analysis/InlineCost.cpp +++ b/lib/Analysis/InlineCost.cpp @@ -159,6 +159,11 @@ void CodeMetrics::analyzeBasicBlock(const BasicBlock *BB) { if (isa<ReturnInst>(BB->getTerminator())) ++NumRets; + // We never want to inline functions that contain an indirectbr. This is + // incorrect because all the blockaddress's (e.g. in static global + // initializers would be referring to the original function, and this indirect + // jump would jump from the inlined copy of the function into the original + // function which is extremely undefined behavior. if (isa<IndirectBrInst>(BB->getTerminator())) NeverInline = true; } |