diff options
Diffstat (limited to 'lib/Sema/AnalysisBasedWarnings.cpp')
-rw-r--r-- | lib/Sema/AnalysisBasedWarnings.cpp | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/lib/Sema/AnalysisBasedWarnings.cpp b/lib/Sema/AnalysisBasedWarnings.cpp index 06e42b7728..3dae7b4d7e 100644 --- a/lib/Sema/AnalysisBasedWarnings.cpp +++ b/lib/Sema/AnalysisBasedWarnings.cpp @@ -560,8 +560,6 @@ public: const VarDecl *vd = i->first; UsesVec *vec = i->second; - bool fixitIssued = false; - // Sort the uses by their SourceLocations. While not strictly // guaranteed to produce them in line/column order, this will provide // a stable ordering. @@ -573,11 +571,11 @@ public: /*isAlwaysUninit=*/vi->second)) continue; - // Suggest a fixit hint the first time we diagnose a use of a variable. - if (!fixitIssued) { - SuggestInitializationFixit(S, vd); - fixitIssued = true; - } + SuggestInitializationFixit(S, vd); + + // Skip further diagnostics for this variable. We try to warn only on + // the first point at which a variable is used uninitialized. + break; } delete vec; |